[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v2 02/13] PPC: Fix lswx bounds checks
From: |
Mark Cave-Ayland |
Subject: |
[Qemu-ppc] [PATCH v2 02/13] PPC: Fix lswx bounds checks |
Date: |
Wed, 11 Nov 2015 22:49:40 +0000 |
From: Alexander Graf <address@hidden>
The lswx instruction checks whether the desired string actually fits
into all defined registers. Unfortunately it does the calculation wrong,
resulting in illegal instruction traps for loads that really should fit.
Fix it up, making Mac OS happier.
Signed-off-by: Alexander Graf <address@hidden>
Signed-off-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: David Gibson <address@hidden>
---
target-ppc/mem_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target-ppc/mem_helper.c b/target-ppc/mem_helper.c
index 6d37dae..7e1f234 100644
--- a/target-ppc/mem_helper.c
+++ b/target-ppc/mem_helper.c
@@ -100,8 +100,9 @@ void helper_lswx(CPUPPCState *env, target_ulong addr,
uint32_t reg,
uint32_t ra, uint32_t rb)
{
if (likely(xer_bc != 0)) {
- if (unlikely((ra != 0 && reg < ra && (reg + xer_bc) > ra) ||
- (reg < rb && (reg + xer_bc) > rb))) {
+ int num_used_regs = (xer_bc + 3) / 4;
+ if (unlikely((ra != 0 && reg < ra && (reg + num_used_regs) > ra) ||
+ (reg < rb && (reg + num_used_regs) > rb))) {
helper_raise_exception_err(env, POWERPC_EXCP_PROGRAM,
POWERPC_EXCP_INVAL |
POWERPC_EXCP_INVAL_LSWX);
--
1.7.10.4
- [Qemu-ppc] [PATCH v2 00/13] Mac OS 9 compatibility improvements (upstream rework), Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 01/13] PPC: Allow Rc bit to be set on mtspr, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 02/13] PPC: Fix lswx bounds checks,
Mark Cave-Ayland <=
- [Qemu-ppc] [PATCH v2 04/13] cuda.c: fix CUDA ADB error packet format, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 03/13] PPC: mac99: Always add USB controller, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 05/13] cuda.c: fix CUDA_PACKET response packet format, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 06/13] cuda.c: implement simple CUDA_GET_6805_ADDR command, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 07/13] cuda.c: implement dummy IIC access commands, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 08/13] cuda.c: fix CUDA SR interrupt clearing, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 09/13] cuda.c: add defines for CUDA registers, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 13/13] cuda.c: add delay to setting of SR_INT bit, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 10/13] cuda.c: refactor get_tb() so that the time can be passed in, Mark Cave-Ayland, 2015/11/11
- [Qemu-ppc] [PATCH v2 11/13] cuda.c: rename get_counter() state variable from s to ti for consistency, Mark Cave-Ayland, 2015/11/11