[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 02/14] PPC: Fix lswx bounds checks
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 02/14] PPC: Fix lswx bounds checks |
Date: |
Thu, 12 Nov 2015 15:38:31 +1100 |
From: Alexander Graf <address@hidden>
The lswx instruction checks whether the desired string actually fits
into all defined registers. Unfortunately it does the calculation wrong,
resulting in illegal instruction traps for loads that really should fit.
Fix it up, making Mac OS happier.
Signed-off-by: Alexander Graf <address@hidden>
Signed-off-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
target-ppc/mem_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target-ppc/mem_helper.c b/target-ppc/mem_helper.c
index 6d37dae..7e1f234 100644
--- a/target-ppc/mem_helper.c
+++ b/target-ppc/mem_helper.c
@@ -100,8 +100,9 @@ void helper_lswx(CPUPPCState *env, target_ulong addr,
uint32_t reg,
uint32_t ra, uint32_t rb)
{
if (likely(xer_bc != 0)) {
- if (unlikely((ra != 0 && reg < ra && (reg + xer_bc) > ra) ||
- (reg < rb && (reg + xer_bc) > rb))) {
+ int num_used_regs = (xer_bc + 3) / 4;
+ if (unlikely((ra != 0 && reg < ra && (reg + num_used_regs) > ra) ||
+ (reg < rb && (reg + num_used_regs) > rb))) {
helper_raise_exception_err(env, POWERPC_EXCP_PROGRAM,
POWERPC_EXCP_INVAL |
POWERPC_EXCP_INVAL_LSWX);
--
2.5.0
- [Qemu-ppc] [PULL 00/14] ppc-next queue 20151112, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 01/14] PPC: Allow Rc bit to be set on mtspr, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 00/14] ppc-next queue 20151112, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 02/14] PPC: Fix lswx bounds checks,
David Gibson <=
- [Qemu-ppc] [PULL 07/14] cuda.c: implement dummy IIC access commands, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 04/14] cuda.c: fix CUDA ADB error packet format, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 08/14] cuda.c: fix CUDA SR interrupt clearing, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 05/14] cuda.c: fix CUDA_PACKET response packet format, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 03/14] PPC: mac99: Always add USB controller, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 06/14] cuda.c: implement simple CUDA_GET_6805_ADDR command, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 09/14] cuda.c: add defines for CUDA registers, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 12/14] cuda.c: fix T2 timer and enable its interrupt, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 13/14] cuda.c: add delay to setting of SR_INT bit, David Gibson, 2015/11/11
- [Qemu-ppc] [PULL 11/14] cuda.c: rename get_counter() state variable from s to ti for consistency, David Gibson, 2015/11/11