Re: [Qemu-ppc] [Qemu-devel] [PATCH v10 21/25] qapi: Drop unused 'kind' for struct/enum visit

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> visit_start_struct() and visit_type_enum() had a 'kind' argument
> that was usually set to either the stringized version of the
> corresponding qapi type name, or to NULL (although some clients
> didn't even get that right).  But nothing ever used the argument.
> It's even hard to argue that it would be useful in a debugger,
> as a stack backtrace also tells which type is being visited.
>
> Therefore, drop the 'kind' argument as dead.
>
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
>
> ---
> v10: rebase to earlier changes, tweak copyright
> v9: no change
> v8: rebase to 'name' motion
> v7: new patch
[...]
> diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c
> index 23ff6a9..2999995 100644
> --- a/qapi/qapi-visit-core.c
> +++ b/qapi/qapi-visit-core.c
> @@ -3,6 +3,7 @@
>   *
>   * Copyright (C) 2012-2016 Red Hat, Inc.
>   * Copyright IBM, Corp. 2011
> + * Copyright (C) 2015 Red Hat, Inc.

Rebase mistake.  Can drop the hunk on commit.

>   *
>   * Authors:
>   *  Anthony Liguori   <address@hidden>
[...]