[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v6 4/5] util: [ppc] Use new error_report_abort() i
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-ppc] [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort() |
|
Date: |
Tue, 2 Feb 2016 12:34:12 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/02/2016 09:14 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> target-ppc/kvm.c | 4 ++--
> target-ppc/kvm_ppc.h | 15 +++++++++------
> target-ppc/mmu-hash32.c | 5 +++--
> target-ppc/mmu_helper.c | 3 +--
> 4 files changed, 15 insertions(+), 12 deletions(-)
>
> @@ -215,36 +218,36 @@ static inline int kvmppc_get_htab_fd(bool write)
> static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize,
> int64_t max_ns)
> {
> - abort();
> + error_report_abort(" ");
> }
I still strongly dislike this. Reporting an error message with nothing
but a trailing whitespace is NOT helpful. Straight 'abort()' is better
than this; if we can't come up with a useful message, then it is not
worth using the message-handling interface.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature