[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 5/5] ppc/kvm: Tell the user what might be wrong when us
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 5/5] ppc/kvm: Tell the user what might be wrong when using bad CPU types with kvm-hv |
Date: |
Thu, 25 Feb 2016 14:02:10 +1100 |
From: Thomas Huth <address@hidden>
Using a CPU type that does not match the host is not possible when using
the kvm-hv kernel module - the PVR is checked in the kernel function
kvm_arch_vcpu_ioctl_set_sregs_hv() and rejected with -EINVAL if it
does not match the host.
However, when the user tries to specify a non-matching CPU type, QEMU
currently only reports "kvm_init_vcpu failed: Invalid argument", and
this is of course not very helpful for the user to solve the problem.
So this patch adds a more descriptive error message that tells the
user to specify "-cpu host" instead.
Signed-off-by: Thomas Huth <address@hidden>
[Removed melodramatic '!' :)]
Signed-off-by: David Gibson <address@hidden>
---
target-ppc/kvm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 762d6cf..d67c169 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -513,6 +513,10 @@ int kvm_arch_init_vcpu(CPUState *cs)
/* Synchronize sregs with kvm */
ret = kvm_arch_sync_sregs(cpu);
if (ret) {
+ if (ret == -EINVAL) {
+ error_report("Register sync failed... If you're using kvm-hv.ko,"
+ " only \"-cpu host\" is possible");
+ }
return ret;
}
--
2.5.0
- [Qemu-ppc] [PULL 0/5] ppc-for-2.6 queue 20160225, David Gibson, 2016/02/24
- [Qemu-ppc] [PULL 5/5] ppc/kvm: Tell the user what might be wrong when using bad CPU types with kvm-hv,
David Gibson <=
- [Qemu-ppc] [PULL 4/5] ppc/kvm: Use error_report() instead of cpu_abort() for user-triggerable errors, David Gibson, 2016/02/24
- [Qemu-ppc] [PULL 2/5] hw/ppc/spapr: Implement the h_page_init hypercall, David Gibson, 2016/02/24
- [Qemu-ppc] [PULL 3/5] spapr: initialize local Error pointer, David Gibson, 2016/02/24
- [Qemu-ppc] [PULL 1/5] pseries: Update SLOF firmware image to 20160223, David Gibson, 2016/02/25
- Re: [Qemu-ppc] [PULL 0/5] ppc-for-2.6 queue 20160225, Peter Maydell, 2016/02/25