Re: [Qemu-ppc] [PATCH 10/12] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge

[Alexey Kardashevskiy]

On 02/26/2016 10:32 PM, David Gibson wrote:
> Now that the regular spapr-pci-host-bridge can handle EEH, there are only
> two things that spapr-pci-vfio-host-bridge does differently:
>      1. automatically sizes its DMA window to match the host IOMMU
>      2. checks if the attached VFIO container is backed by the
>         VFIO_SPAPR_TCE_IOMMU type on the host
>
> (1) is not particularly useful, since the default window used by the
> regular host bridge will work with the host IOMMU configuration on all
> current systems anyway.
>
> Plus, automatically changing guest visible configuration (such as the DMA
> window) based on host settings is generally a bad idea.

btw why exactly is it a bad idea?


Anyway,
Reviewed-by: Alexey Kardashevskiy <address@hidden>


--
Alexey