[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 4/6] ppc: Fix fault PC reporting for lve*/stve* VMX ins
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 4/6] ppc: Fix fault PC reporting for lve*/stve* VMX instructions |
Date: |
Fri, 29 Jul 2016 14:53:42 +1000 |
From: Benjamin Herrenschmidt <address@hidden>
We forgot to do gen_update_nip() for these like we do with other
helpers. Fix this, but in a more efficient way by passing the RA
to the accessors instead so the overhead is only taken on faults.
Signed-off-by: Benjamin Herrenschmidt <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
target-ppc/mem_helper.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/target-ppc/mem_helper.c b/target-ppc/mem_helper.c
index e4de86b..e4ed377 100644
--- a/target-ppc/mem_helper.c
+++ b/target-ppc/mem_helper.c
@@ -232,16 +232,16 @@ target_ulong helper_lscbx(CPUPPCState *env, target_ulong
addr, uint32_t reg,
\
if (needs_byteswap(env)) { \
r->element[LO_IDX ? index : (adjust - index)] = \
- swap(access(env, addr)); \
+ swap(access(env, addr, GETPC())); \
} else { \
r->element[LO_IDX ? index : (adjust - index)] = \
- access(env, addr); \
+ access(env, addr, GETPC()); \
} \
}
#define I(x) (x)
-LVE(lvebx, cpu_ldub_data, I, u8)
-LVE(lvehx, cpu_lduw_data, bswap16, u16)
-LVE(lvewx, cpu_ldl_data, bswap32, u32)
+LVE(lvebx, cpu_ldub_data_ra, I, u8)
+LVE(lvehx, cpu_lduw_data_ra, bswap16, u16)
+LVE(lvewx, cpu_ldl_data_ra, bswap32, u32)
#undef I
#undef LVE
@@ -259,16 +259,17 @@ LVE(lvewx, cpu_ldl_data, bswap32, u32)
\
if (needs_byteswap(env)) { \
access(env, addr, swap(r->element[LO_IDX ? index : \
- (adjust - index)])); \
+ (adjust - index)]), \
+ GETPC()); \
} else { \
access(env, addr, r->element[LO_IDX ? index : \
- (adjust - index)]); \
+ (adjust - index)], GETPC()); \
} \
}
#define I(x) (x)
-STVE(stvebx, cpu_stb_data, I, u8)
-STVE(stvehx, cpu_stw_data, bswap16, u16)
-STVE(stvewx, cpu_stl_data, bswap32, u32)
+STVE(stvebx, cpu_stb_data_ra, I, u8)
+STVE(stvehx, cpu_stw_data_ra, bswap16, u16)
+STVE(stvewx, cpu_stl_data_ra, bswap32, u32)
#undef I
#undef LVE
--
2.7.4
- [Qemu-ppc] [PULL 0/6] ppc-for-2.7 queue 20160729, David Gibson, 2016/07/29
- [Qemu-ppc] [PULL 5/6] spapr: Prevent boot CPU core removal, David Gibson, 2016/07/29
- [Qemu-ppc] [PULL 6/6] tests: add drive_del-test to ppc/ppc64, David Gibson, 2016/07/29
- [Qemu-ppc] [PULL 4/6] ppc: Fix fault PC reporting for lve*/stve* VMX instructions,
David Gibson <=
- [Qemu-ppc] [PULL 1/6] spapr: init CPUState->cpu_index with index relative to core-id, David Gibson, 2016/07/29
- [Qemu-ppc] [PULL 2/6] Revert "spapr: Ensure CPU cores are added contiguously and removed in LIFO order", David Gibson, 2016/07/29
- [Qemu-ppc] [PULL 3/6] test: port postcopy test to ppc64, David Gibson, 2016/07/29
- Re: [Qemu-ppc] [PULL 0/6] ppc-for-2.7 queue 20160729, Peter Maydell, 2016/07/29