[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH RFC v1 3/3] target-ppc: tlbie should have global e
|
From: |
Nikunj A Dadhania |
|
Subject: |
Re: [Qemu-ppc] [PATCH RFC v1 3/3] target-ppc: tlbie should have global effect |
|
Date: |
Fri, 09 Sep 2016 17:27:22 +0530 |
|
User-agent: |
Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) |
Benjamin Herrenschmidt <address@hidden> writes:
> On Fri, 2016-09-09 at 16:15 +0530, Nikunj A Dadhania wrote:
>>
>> + env->tlb_need_flush = TLB_NEED_GLOBAL_FLUSH | TLB_NEED_LOCAL_FLUSH;
>> check_tlb_flush(env th, 1);
>>
>
> Hrm... how did that work bore ? IE. check_tlb_flush won't do anything
> if tlb_need_flush is 0, isn't it already set elsewhere ?
Error of my judgement, it is set in remove_hpte, so the above condition
is not required. Good catch.
Regards
Nikunj