[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/13] target-ppc: implement stxvl in
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/13] target-ppc: implement stxvl instruction |
|
Date: |
Mon, 5 Dec 2016 09:55:18 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote:
> + for (i = 15; i > 15 - end; i--) {
> + cpu_stb_data_ra(env, addr, xt.u8[i], GETPC());
> + addr = addr_add(env, addr, 1);
> + }
(1) you need to handle nb > 16.
(2) don't you need different byte indexing for little-endian?
r~
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 02/13] target-ppc: add mask_u128 routine, (continued)
- [Qemu-ppc] [PATCH 03/13] target-ppc: implement lxvl instruction, Nikunj A Dadhania, 2016/12/05
- [Qemu-ppc] [PATCH 04/13] target-ppc: implement lxvll instruction, Nikunj A Dadhania, 2016/12/05
- [Qemu-ppc] [PATCH 05/13] target-ppc: implement stxvl instruction, Nikunj A Dadhania, 2016/12/05
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/13] target-ppc: implement stxvl instruction,
Richard Henderson <=
- [Qemu-ppc] [PATCH 07/13] target-ppc: implement xxextractuw instruction, Nikunj A Dadhania, 2016/12/05
- [Qemu-ppc] [PATCH 09/13] target-ppc: implement stop instruction, Nikunj A Dadhania, 2016/12/05
- [Qemu-ppc] [PATCH 06/13] target-ppc: implement stxvll instructions, Nikunj A Dadhania, 2016/12/05
- [Qemu-ppc] [PATCH 08/13] target-ppc: implement xxinsertw instruction, Nikunj A Dadhania, 2016/12/05
- [Qemu-ppc] [PATCH 10/13] target-ppc: implement xsabsqp/xsnabsqp instruction, Nikunj A Dadhania, 2016/12/05