[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] spapr: fix leak in h_client_arch
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] spapr: fix leak in h_client_architecture_support() |
Date: |
Tue, 12 Jun 2018 17:13:15 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/12/2018 02:01 PM, Greg Kurz wrote:
> If the negotiated compat mode can't be set, but raw mode is supported,
> we decide to ignore the error. An so, we should free it to prevent a
> memory leak.
>
> Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/ppc/spapr_hcall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 022f6d810182..8b9a4b577fbf 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1547,6 +1547,7 @@ static target_ulong
> h_client_architecture_support(PowerPCCPU *cpu,
> error_report_err(local_err);
> return H_HARDWARE;
> }
> + error_free(local_err);
> local_err = NULL;
> }
> }
>
>
- [Qemu-ppc] [PATCH 1/3] target/ppc: drop empty #if/#endif block, Greg Kurz, 2018/06/12
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/3] target/ppc: drop empty #if/#endif block, Philippe Mathieu-Daudé, 2018/06/12
- [Qemu-ppc] [PATCH 2/3] spapr: fix leak in h_client_architecture_support(), Greg Kurz, 2018/06/12
- [Qemu-ppc] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG, Greg Kurz, 2018/06/12
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG, Richard Henderson, 2018/06/14
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG, Greg Kurz, 2018/06/14
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG, David Gibson, 2018/06/14