[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot()
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot() from header |
Date: |
Mon, 18 Jun 2018 10:41:46 +1000 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Fri, Jun 15, 2018 at 04:04:39PM +0200, David Hildenbrand wrote:
> Not used outside of pc-dimm.c and there shouldn't be other users. If
> other devices (e.g. memory devices) ever have to also use slots, then we
> will have to factor this out.
>
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/mem/pc-dimm.c | 4 +++-
> include/hw/mem/pc-dimm.h | 2 --
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 9e0c83e415..7387963cf1 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -27,6 +27,8 @@
> #include "sysemu/numa.h"
> #include "trace.h"
>
> +static int pc_dimm_get_free_slot(const int *hint, int max_slots, Error
> **errp);
> +
> void pc_dimm_plug(DeviceState *dev, MachineState *machine, uint64_t align,
> Error **errp)
> {
> @@ -111,7 +113,7 @@ static int pc_dimm_slot2bitmap(Object *obj, void *opaque)
> return 0;
> }
>
> -int pc_dimm_get_free_slot(const int *hint, int max_slots, Error **errp)
> +static int pc_dimm_get_free_slot(const int *hint, int max_slots, Error
> **errp)
> {
> unsigned long *bitmap;
> int slot = 0;
> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> index 860343d64f..cf71247630 100644
> --- a/include/hw/mem/pc-dimm.h
> +++ b/include/hw/mem/pc-dimm.h
> @@ -76,8 +76,6 @@ typedef struct PCDIMMDeviceClass {
> MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm);
> } PCDIMMDeviceClass;
>
> -int pc_dimm_get_free_slot(const int *hint, int max_slots, Error **errp);
> -
> void pc_dimm_plug(DeviceState *dev, MachineState *machine, uint64_t align,
> Error **errp);
> void pc_dimm_unplug(DeviceState *dev, MachineState *machine);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH v3 00/13] pc-dimm: next bunch of cleanups, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 01/13] pc-dimm: remove leftover "struct pc_dimms_capacity", David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 02/13] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 03/13] pc-dimm: rename pc_dimm_memory_* to pc_dimm_*, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot() from header, David Hildenbrand, 2018/06/15
- Re: [Qemu-ppc] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot() from header,
David Gibson <=
- [Qemu-ppc] [PATCH v3 05/13] pc: factor out pc specific dimm checks into pc_memory_pre_plug(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 06/13] nvdimm: no need to overwrite get_vmstate_memory_region(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 07/13] hostmem: drop error variable from host_memory_backend_get_memory(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer, David Hildenbrand, 2018/06/15