[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v4 06/12] nvdimm: no need to overwrite get_vmstate_mem
From: |
David Hildenbrand |
Subject: |
[Qemu-ppc] [PATCH v4 06/12] nvdimm: no need to overwrite get_vmstate_memory_region() |
Date: |
Mon, 18 Jun 2018 16:25:30 +0200 |
Our parent class (PC_DIMM) provides exactly the same function.
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/mem/nvdimm.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index 4087aca25e..f974accbdd 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvdimm.c
@@ -166,11 +166,6 @@ static void nvdimm_write_label_data(NVDIMMDevice *nvdimm,
const void *buf,
memory_region_set_dirty(mr, backend_offset, size);
}
-static MemoryRegion *nvdimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
-{
- return host_memory_backend_get_memory(dimm->hostmem, &error_abort);
-}
-
static void nvdimm_class_init(ObjectClass *oc, void *data)
{
PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc);
@@ -178,7 +173,6 @@ static void nvdimm_class_init(ObjectClass *oc, void *data)
ddc->realize = nvdimm_realize;
ddc->get_memory_region = nvdimm_get_memory_region;
- ddc->get_vmstate_memory_region = nvdimm_get_vmstate_memory_region;
nvc->read_label_data = nvdimm_read_label_data;
nvc->write_label_data = nvdimm_write_label_data;
--
2.17.1
- [Qemu-ppc] [PATCH v4 00/12] pc-dimm: next bunch of cleanups, David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*, David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 01/12] pc-dimm: remove leftover "struct pc_dimms_capacity", David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_*, David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header, David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 05/12] pc: factor out pc specific dimm checks into pc_memory_pre_plug(), David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 06/12] nvdimm: no need to overwrite get_vmstate_memory_region(),
David Hildenbrand <=
- [Qemu-ppc] [PATCH v4 07/12] hostmem: drop error variable from host_memory_backend_get_memory(), David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 11/12] nvdimm: make get_memory_region() perform checks and initialization, David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 09/12] nvdimm: convert "unarmed" into a static property, David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 08/12] pc-dimm: merge get_(vmstate_)memory_region(), David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 10/12] nvdimm: convert nvdimm_mr into a pointer, David Hildenbrand, 2018/06/18
- [Qemu-ppc] [PATCH v4 12/12] pc-dimm: get_memory_region() will not fail after realize, David Hildenbrand, 2018/06/18