[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip m
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models |
Date: |
Tue, 19 Jun 2018 07:24:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
>>> typedef struct PnvChipClass {
>>> /*< private >*/
>>> @@ -75,6 +95,7 @@ typedef struct PnvChipClass {
>>>
>>> hwaddr xscom_base;
>>>
>>> + void (*realize)(PnvChip *chip, Error **errp);
>>
>> This looks the wrong way round from how things are usually done.
>> Rather than having the base class realize() call the subclass specific
>> realize hook, it's more usual for the subclass to set the
>> dc->realize() and have it call a k->parent_realize() to call up the
>> chain. grep for device_class_set_parent_realize() for some more
>> examples.
>
> Ah. That is more to my liking. There are a couple of models following
> the wrong object pattern, xics, vio. I will check them.
So XICS is causing some head-aches because the ics-kvm model inherits
from ics-simple which inherits from ics-base. so we have a grand-parent
class to handle.
if we could affiliate ics-kvm directly to ics-base it would make the
family affair easier. we need to check migration though.
C.
- [Qemu-ppc] [PATCH v2 0/4] ppc/pnv: new Pnv8Chip and Pnv9Chip models, Cédric Le Goater, 2018/06/15
- [Qemu-ppc] [PATCH v2 1/4] ppc/pnv: introduce a new intc_create() operation to the chip model, Cédric Le Goater, 2018/06/15
- [Qemu-ppc] [PATCH v2 2/4] ppc/pnv: introduce a new isa_create() operation to the chip model, Cédric Le Goater, 2018/06/15
- [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models, Cédric Le Goater, 2018/06/15
- Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models, David Gibson, 2018/06/18
- Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models, Cédric Le Goater, 2018/06/18
- Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models, David Gibson, 2018/06/18
- Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models,
Cédric Le Goater <=
- Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models, David Gibson, 2018/06/19
- Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models, Cédric Le Goater, 2018/06/20
- Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models, David Gibson, 2018/06/25
- Re: [Qemu-ppc] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models, Cédric Le Goater, 2018/06/25
[Qemu-ppc] [PATCH v2 4/4] ppc/pnv: consolidate the creation of the ISA bus device tree, Cédric Le Goater, 2018/06/15