Re: [Qemu-ppc] [PATCH] hw/display/cirrus_vga: Add CONFIG option for "isa-cirrus-vga"

[Thomas Huth]

On 2018-10-12 11:31, Gerd Hoffmann wrote:
> On Thu, Oct 11, 2018 at 05:21:45PM +0200, Thomas Huth wrote:
>> In downstream distros like RHEL we'd like to disable some of the "legacy"
>> devices of QEMU. The ISA version of the Cirrus VGA device is one of these
>> legacy devices. So let's make the build process a little bit more flexible
>> here by putting the Cirrus ISA code into a separate file and by providing
>> a proper CONFIG_VGA_CIRRUS_ISA switch which can be used to disable
>> this device.
> 
> We already have a CONFIG_VGA_ISA, how about adding it there instead?

Fine for me, too. I'll send a v2 with that. Note that this will disable
the "isa-cirrus-vga" device on ppc-softmmu and alpha-softmmu, since that
config switch is not use there (while CONFIG_VGA_CIRRUS currently
enables it there). But I assume that's ok since these platforms are
likely only interested in the PCI variant of the Cirrus VGA devices.

 Thomas