[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH 2/5] ppc: Express dependencies of the 'prep' a
From: |
Thomas Huth |
Subject: |
Re: [Qemu-ppc] [RFC PATCH 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig |
Date: |
Wed, 30 Jan 2019 11:25:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-30 11:17, Paolo Bonzini wrote:
> On 30/01/19 10:43, Thomas Huth wrote:
>> + select LSI_SCSI_PCI
>
> Should NE2000_ISA and LSI_SCSI_PCI be handled the same? Either rely on
> "default y" for both, or select both (I think I prefer the former).
Yes. IMHO we should use "select XXX" if the machine has a hard
requirement for a device, and "default y" if it can also somehow work
without the device. In this case, I did not look carefully enough, since
it is apparently possible to use the 40p machine also without the LSI
controller when you specify "-nodefaults". So I'll remove this in v2 and
rely on the "default y" instead.
Thomas
[Qemu-ppc] [RFC PATCH 5/5] ppc: Express dependencies of the embedded machines with kconfig, Thomas Huth, 2019/01/30
[Qemu-ppc] [RFC PATCH 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig, Thomas Huth, 2019/01/30
[Qemu-ppc] [RFC PATCH 3/5] ppc: Express dependencies of the Mac machines with kconfig, Thomas Huth, 2019/01/30
[Qemu-ppc] [RFC PATCH 4/5] ppc: Express dependencies of the Sam460EX machines with kconfig, Thomas Huth, 2019/01/30