Re: [Qemu-ppc] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810

qemu-ppc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810

From:	Paolo Bonzini
Subject:	Re: [Qemu-ppc] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810
Date:	Mon, 15 Apr 2019 11:21:33 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 14/04/19 20:36, Artyom Tarasenko wrote:
>> You can probably remove this change, and replace it by
>> uint16_t type = PCI_DEVICE_GET_CLASS(dev)->device_id;
> Brilliant! Will do in V2, thainks.

Either that, or you could keep the current structure and make mmio_size
the last parameter of lsi_scsi_realize.

Paolo

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-ppc] [PATCH 0/4] Improve 40p, make AIX 5.1 boot, Artyom Tarasenko, 2019/04/12
- [Qemu-ppc] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810, Artyom Tarasenko, 2019/04/12
  - Re: [Qemu-ppc] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810, Hervé Poussineau, 2019/04/14
    - Re: [Qemu-ppc] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810, Artyom Tarasenko, 2019/04/14
    - Re: [Qemu-ppc] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810, Paolo Bonzini <=
- [Qemu-ppc] [PATCH 3/4] target/ppc: improve performance of large BAT invalidations, Artyom Tarasenko, 2019/04/12
  - Re: [Qemu-ppc] [PATCH 3/4] target/ppc: improve performance of large BAT invalidations, Hervé Poussineau, 2019/04/14
  - Re: [Qemu-ppc] [PATCH 3/4] target/ppc: improve performance of large BAT invalidations, David Gibson, 2019/04/14
- [Qemu-ppc] [PATCH 2/4] 40p and prep: implement PCI bus mastering, Artyom Tarasenko, 2019/04/12
  - Re: [Qemu-ppc] [PATCH 2/4] 40p and prep: implement PCI bus mastering, Hervé Poussineau, 2019/04/14
- [Qemu-ppc] [PATCH 4/4] hw/isa/i82378.c: use 1900 as a base year, Artyom Tarasenko, 2019/04/12
  - Re: [Qemu-ppc] [PATCH 4/4] hw/isa/i82378.c: use 1900 as a base year, Hervé Poussineau, 2019/04/14
    - Re: [Qemu-ppc] [PATCH 4/4] hw/isa/i82378.c: use 1900 as a base year, Artyom Tarasenko, 2019/04/14
    - Re: [Qemu-ppc] [PATCH 4/4] hw/isa/i82378.c: use 1900 as a base year, Hervé Poussineau, 2019/04/14
    - Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] hw/isa/i82378.c: use 1900 as a base year, Philippe Mathieu-Daudé, 2019/04/15

Prev by Date: Re: [Qemu-ppc] [PATCH 5/6] memory_ldst: Add atomic ops for PTE updates
Next by Date: Re: [Qemu-ppc] [PATCH v7 5/6] ppc: spapr: Enable FWNMI capability
Previous by thread: Re: [Qemu-ppc] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810
Next by thread: [Qemu-ppc] [PATCH 3/4] target/ppc: improve performance of large BAT invalidations
Index(es):
- Date
- Thread