[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 27/50] target/ppc: fetch code with translator_l
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v3 27/50] target/ppc: fetch code with translator_ld |
Date: |
Wed, 19 Jun 2019 19:39:24 +1000 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Fri, Jun 14, 2019 at 06:11:37PM +0100, Alex Bennée wrote:
> From: "Emilio G. Cota" <address@hidden>
>
> Signed-off-by: Emilio G. Cota <address@hidden>
Acked-by: David Gibson <address@hidden>
> ---
> target/ppc/translate.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 4a5de28036..a27b5659f4 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -7864,11 +7864,9 @@ static void ppc_tr_translate_insn(DisasContextBase
> *dcbase, CPUState *cs)
> LOG_DISAS("nip=" TARGET_FMT_lx " super=%d ir=%d\n",
> ctx->base.pc_next, ctx->mem_idx, (int)msr_ir);
>
> - if (unlikely(need_byteswap(ctx))) {
> - ctx->opcode = bswap32(cpu_ldl_code(env, ctx->base.pc_next));
> - } else {
> - ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);
> - }
> + ctx->opcode = translator_ldl_swap(env, ctx->base.pc_next,
> + need_byteswap(ctx));
> +
> LOG_DISAS("translate opcode %08x (%02x %02x %02x %02x) (%s)\n",
> ctx->opcode, opc1(ctx->opcode), opc2(ctx->opcode),
> opc3(ctx->opcode), opc4(ctx->opcode),
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature