[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/6] target/ppc: Pass const pointer to ppc_radix64_get_pro
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH v2 1/6] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr() |
Date: |
Thu, 14 May 2020 08:29:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/14/20 12:56 AM, Greg Kurz wrote:
> This doesn't require write access to the CPU structure.
>
> Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
> ---
> target/ppc/mmu-radix64.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/mmu-radix64.h b/target/ppc/mmu-radix64.h
> index 96228546aa85..f28c5794d071 100644
> --- a/target/ppc/mmu-radix64.h
> +++ b/target/ppc/mmu-radix64.h
> @@ -55,9 +55,9 @@ static inline int ppc_radix64_get_prot_eaa(uint64_t pte)
> (pte & R_PTE_EAA_X ? PAGE_EXEC : 0);
> }
>
> -static inline int ppc_radix64_get_prot_amr(PowerPCCPU *cpu)
> +static inline int ppc_radix64_get_prot_amr(const PowerPCCPU *cpu)
> {
> - CPUPPCState *env = &cpu->env;
> + const CPUPPCState *env = &cpu->env;
> int amr = env->spr[SPR_AMR] >> 62; /* We only care about key0 AMR63:62 */
> int iamr = env->spr[SPR_IAMR] >> 62; /* We only care about key0
> IAMR63:62 */
>
>
- [PATCH v2 0/6] target/ppc: Various clean-up and fixes for radix64, Greg Kurz, 2020/05/13
- [PATCH v2 1/6] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr(), Greg Kurz, 2020/05/13
- Re: [PATCH v2 1/6] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr(),
Cédric Le Goater <=
- [PATCH v2 2/6] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr(), Greg Kurz, 2020/05/13
- [PATCH v2 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate(), Greg Kurz, 2020/05/13
- [PATCH v2 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate(), Greg Kurz, 2020/05/13
- [PATCH v2 4/6] target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate(), Greg Kurz, 2020/05/13
- [PATCH v2 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub, Greg Kurz, 2020/05/13