[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc"
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc" |
Date: |
Tue, 19 May 2020 08:30:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
BALATON Zoltan <address@hidden> writes:
> On Mon, 18 May 2020, Markus Armbruster wrote:
>> sm501_init() and ati_vga_realize() create an "i2c-ddc" device, but
>> neglect to realize it. Affects machines sam460ex, shix, r2d, and
>> fulong2e.
>>
>> I wonder how this ever worked. If the "device becomes real only on
>> realize" thing actually works, then we've always been missing the
>> device, yet nobody noticed.
>
> No idea why it worked but guests can read EDID info fine with or
> without this patch, so
>
> Tested-by: BALATON Zoltan <address@hidden>
Thanks!
> Maybe device is created and working after init as it has nothing
> special to do at realize (it doesn't even have a realize method) so
> all realize would do is to link it in qtree?
Plausible.