[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/ppc: Fix argument to ppc_radix64_partition_scoped_xla
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again |
Date: |
Tue, 26 May 2020 18:35:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/26/20 6:20 PM, Greg Kurz wrote:
> The penultimate argument of function ppc_radix64_partition_scoped_xlate()
> has the bool type.
>
> Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped
> translation"
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>
> A patch fixing the same issue in other places was merged recently in
> ppc-for-5.1. Maybe worth squashing the two patches into one ?
>
> commit 372ef6e9b803ef10c3200c45311d218e2c97b218
> Author: Greg Kurz <address@hidden>
> Date: Thu May 14 00:57:13 2020 +0200
>
> target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate()
> ---
> target/ppc/mmu-radix64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 0d3922537c4c..c60bf3135734 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -513,7 +513,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr
> eaddr, int rwx,
>
> ret = ppc_radix64_partition_scoped_xlate(cpu, rwx, eaddr,
> g_raddr,
> pate, raddr, &prot,
> &psize,
> - 0, guest_visible);
> + false, guest_visible);
> if (ret) {
> return ret;
> }
>
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>