[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/21] hw/display/edid: Add missing 'qdev-properties.h' header
From: |
Gerd Hoffmann |
Subject: |
[PULL 01/21] hw/display/edid: Add missing 'qdev-properties.h' header |
Date: |
Thu, 28 May 2020 14:35:49 +0200 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
When trying to consume the DEFINE_EDID_PROPERTIES() macro
by including "hw/display/edid.h", we get this build failure:
include/hw/display/edid.h:24:5: error: implicit declaration of
function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration]
24 | DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \
| ^~~~~~~~~~~~~~~~~~
Headers should be self-contained, and one shouldn't have to
dig to find the missing headers.
In this case "hw/qdev-properties.h" is missing. Add it.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-2-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/hw/display/edid.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
index ff99dc0a052b..23371ee82c63 100644
--- a/include/hw/display/edid.h
+++ b/include/hw/display/edid.h
@@ -2,6 +2,7 @@
#define EDID_H
#include "qom/object.h"
+#include "hw/qdev-properties.h"
typedef struct qemu_edid_info {
const char *vendor; /* http://www.uefi.org/pnp_id_list */
--
2.18.4
- [PULL 20/21] sm501: Optimize small overlapping blits, (continued)
- [PULL 20/21] sm501: Optimize small overlapping blits, Gerd Hoffmann, 2020/05/28
- [PULL 17/21] sm501: Use BIT(x) macro to shorten constant, Gerd Hoffmann, 2020/05/28
- [PULL 21/21] sm501: Remove obsolete changelog and todo comment, Gerd Hoffmann, 2020/05/28
- [PULL 16/21] sm501: Shorten long variable names in sm501_2d_operation, Gerd Hoffmann, 2020/05/28
- [PULL 06/21] hw/display/cirrus_vga: Convert debug printf() to trace event, Gerd Hoffmann, 2020/05/28
- [PULL 11/21] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion, Gerd Hoffmann, 2020/05/28
- [PULL 19/21] sm501: Replace hand written implementation with pixman where possible, Gerd Hoffmann, 2020/05/28
- [PULL 14/21] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask(), Gerd Hoffmann, 2020/05/28
- [PULL 07/21] hw/display/dpcd: Fix memory region size, Gerd Hoffmann, 2020/05/28
- [PULL 09/21] hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report(), Gerd Hoffmann, 2020/05/28
- [PULL 01/21] hw/display/edid: Add missing 'qdev-properties.h' header,
Gerd Hoffmann <=
- [PULL 05/21] hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf, Gerd Hoffmann, 2020/05/28
- Re: [PULL 00/21] Vga 20200528 patches, no-reply, 2020/05/28
- Re: [PULL 00/21] Vga 20200528 patches, Peter Maydell, 2020/05/29