[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/8] hw/pci/pci_bridge: Use the IEC binary prefix definitions
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 4/8] hw/pci/pci_bridge: Use the IEC binary prefix definitions |
Date: |
Sun, 31 May 2020 19:38:10 +0200 |
IEC binary prefixes ease code review: the unit is explicit.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/pci/pci_bridge.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index 3ba3203f72..3789c17edc 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -423,14 +423,14 @@ int pci_bridge_qemu_reserve_cap_init(PCIDevice *dev, int
cap_offset,
}
if (res_reserve.mem_non_pref != (uint64_t)-1 &&
- res_reserve.mem_non_pref >= (1ULL << 32)) {
+ res_reserve.mem_non_pref >= 4 * GiB) {
error_setg(errp,
"PCI resource reserve cap: mem-reserve must be less than
4G");
return -EINVAL;
}
if (res_reserve.mem_pref_32 != (uint64_t)-1 &&
- res_reserve.mem_pref_32 >= (1ULL << 32)) {
+ res_reserve.mem_pref_32 >= 4 * GiB) {
error_setg(errp,
"PCI resource reserve cap: pref32-reserve must be less
than 4G");
return -EINVAL;
--
2.21.3
- [PATCH 0/8] hw: Fix some incomplete memory region size, Philippe Mathieu-Daudé, 2020/05/31
- [PATCH 3/8] hw/pci/pci_bridge: Correct pci_bridge_io memory region size, Philippe Mathieu-Daudé, 2020/05/31
- [PATCH 2/8] hw/pci-host/prep: Correct RAVEN bus bridge memory region size, Philippe Mathieu-Daudé, 2020/05/31
- [PATCH 1/8] hw/arm/aspeed: Correct DRAM container region size, Philippe Mathieu-Daudé, 2020/05/31
- [PATCH 6/8] hw/hppa/dino: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2020/05/31
- [PATCH 5/8] hw/pci-host: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2020/05/31
- [PATCH 4/8] hw/pci/pci_bridge: Use the IEC binary prefix definitions,
Philippe Mathieu-Daudé <=
- [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2020/05/31
- [PATCH 8/8] target/i386/cpu: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2020/05/31
- Re: [PATCH 0/8] hw: Fix some incomplete memory region size, Peter Maydell, 2020/05/31