[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code i
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used |
Date: |
Tue, 9 Jun 2020 13:11:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/lm32/lm32_hwsetup.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/lm32/lm32_hwsetup.h b/hw/lm32/lm32_hwsetup.h
> index de94de177a..f4a4d8fe4b 100644
> --- a/hw/lm32/lm32_hwsetup.h
> +++ b/hw/lm32/lm32_hwsetup.h
> @@ -27,6 +27,7 @@
>
> #include "qemu/cutils.h"
> #include "hw/loader.h"
> +#include "hw/qdev-deprecated.h"
>
> typedef struct {
> void *data;
> @@ -57,6 +58,8 @@ static inline HWSetup *hwsetup_init(void)
> {
> HWSetup *hw;
>
> + qdev_warn_deprecated_function_used();
> +
> hw = g_malloc(sizeof(HWSetup));
> hw->data = g_malloc0(TARGET_PAGE_SIZE);
> hw->ptr = hw->data;
>
This one is okay.
Paolo
- RE: [RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is used, (continued)
- [RFC PATCH 13/35] hw/dma/soc_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 16/35] hw/input/lasips2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 19/35] hw/input/tsc2005: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used,
Paolo Bonzini <=
- [RFC PATCH 22/35] hw/m68k/mcf520x: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 24/35] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 25/35] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08