[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/15] spapr: Add a return value to spapr_drc_attach()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 08/15] spapr: Add a return value to spapr_drc_attach() |
|
Date: |
Tue, 15 Sep 2020 15:05:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/14/20 2:34 PM, Greg Kurz wrote:
> As recommended in "qapi/error.h", return true on success and false on
> failure. This allows to reduce error propagation overhead in the callers.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> include/hw/ppc/spapr_drc.h | 2 +-
> hw/ppc/spapr.c | 15 +++------------
> hw/ppc/spapr_drc.c | 5 +++--
> hw/ppc/spapr_nvdimm.c | 5 +----
> hw/ppc/spapr_pci.c | 5 +----
> 5 files changed, 9 insertions(+), 23 deletions(-)
Good cleanup.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- Re: [PATCH 01/15] spapr: Fix error leak in spapr_realize_vcpu(), (continued)
- [PATCH 02/15] ppc: Add a return value to ppc_set_compat() and ppc_set_compat_all(), Greg Kurz, 2020/09/14
- [PATCH 03/15] ppc: Fix return value in cpu_post_load() error path, Greg Kurz, 2020/09/14
- [PATCH 08/15] spapr: Add a return value to spapr_drc_attach(), Greg Kurz, 2020/09/14
- [PATCH 04/15] spapr: Simplify error handling in callers of ppc_set_compat(), Greg Kurz, 2020/09/14
- [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting, Greg Kurz, 2020/09/14
- [PATCH 06/15] spapr: Simplify error handling in do_client_architecture_support(), Greg Kurz, 2020/09/14
- [PATCH 07/15] spapr: Simplify error handling in spapr_vio_busdev_realize(), Greg Kurz, 2020/09/14