Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

[Stefan Berger]

On 10/13/20 4:26 AM, Philippe Mathieu-Daudé wrote:
> On 10/13/20 9:20 AM, Gerd Hoffmann wrote:
> > On Sun, Oct 11, 2020 at 09:32:23PM +0200, Philippe 
> > Mathieu-Daudé wrote:
> > > The TPM TIS device uses IRQ #5 by default. Add this
> > > default definition to the IsaIrqNumber enum.
> >
> > IRQ 5 has no fixed assignment.  All kinds of add-on isa cards (sound,
> > net) used to use irq #5 by default because that one wasn't assigned
> > otherwise.  Seems these days tpm and ipmi use it ...
>
> Yes, I'll drop this patch.

I think this patch is good but maybe the name should be a different one. 
Rather than having these numbers in the code you could maybe call it 
something like this here, which makes grepping through the code a bit 
easier:


    ISA_IRQ_IRQ5 =  5,

Regards,

   Stefan

> Thanks,
>
> Phil.