[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/5] spapr: Fix and cleanups for sPAPR CPU core
From: |
Greg Kurz |
Subject: |
[PATCH v2 0/5] spapr: Fix and cleanups for sPAPR CPU core |
Date: |
Thu, 15 Oct 2020 23:18:18 +0200 |
User-agent: |
StGit/0.21 |
While reading the code _again_ I spotted a memory leak and I realized
that the realize/unrealize paths are uselessly complex and not really
symmetrical.
This series fixes the leak and re-shuffles the code to make it cleaner.
Tested with 'make check', travis-ci and manual hotplug/unplug of CPU
cores. Also tested error paths by simulating failures when creating
interrupt presenters or when setting the vCPU id.
v2: - enforce symmetry between realize and unrealize
- unrealize vCPUs with qdev_unrealize()
- one loop to create/realize and to unrealize/delete vCPUs
---
Greg Kurz (5):
spapr: Fix leak of CPU machine specific data
spapr: Unrealize vCPUs with qdev_unrealize()
spapr: Drop spapr_delete_vcpu() unused argument
spapr: Make spapr_cpu_core_unrealize() idempotent
spapr: Simplify spapr_cpu_core_realize() and spapr_cpu_core_unrealize()
accel/tcg/user-exec-stub.c | 4 ++
hw/ppc/spapr_cpu_core.c | 69 ++++++++++++++++++---------------------
target/ppc/translate_init.c.inc | 2 +
3 files changed, 37 insertions(+), 38 deletions(-)
--
Greg
- [PATCH v2 0/5] spapr: Fix and cleanups for sPAPR CPU core,
Greg Kurz <=
- [PATCH v2 3/5] spapr: Drop spapr_delete_vcpu() unused argument, Greg Kurz, 2020/10/15
- [PATCH v2 4/5] spapr: Make spapr_cpu_core_unrealize() idempotent, Greg Kurz, 2020/10/15
- [PATCH v2 2/5] spapr: Unrealize vCPUs with qdev_unrealize(), Greg Kurz, 2020/10/15
- [PATCH v2 1/5] spapr: Fix leak of CPU machine specific data, Greg Kurz, 2020/10/15
- [PATCH v2 5/5] spapr: Simplify spapr_cpu_core_realize() and spapr_cpu_core_unrealize(), Greg Kurz, 2020/10/15
- Re: [PATCH v2 0/5] spapr: Fix and cleanups for sPAPR CPU core, David Gibson, 2020/10/22