qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC sy


From: David Gibson
Subject: Re: [PATCH v10 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller
Date: Tue, 23 Mar 2021 11:40:57 +1100

On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote:
> The Marvell Discovery II aka. MV64361 is a PowerPC system controller
> chip that is used on the pegasos2 PPC board. This adds emulation of it
> that models the device enough to boot guests on this board. The
> mv643xx.h header with register definitions is taken from Linux 4.15.10
> only fixing white space errors, removing not needed parts and changing
> formatting for QEMU coding style.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  hw/pci-host/Kconfig           |   4 +
>  hw/pci-host/meson.build       |   2 +
>  hw/pci-host/mv64361.c         | 966 ++++++++++++++++++++++++++++++++++
>  hw/pci-host/mv643xx.h         | 918 ++++++++++++++++++++++++++++++++
>  hw/pci-host/trace-events      |   6 +
>  include/hw/pci-host/mv64361.h |   8 +
>  include/hw/pci/pci_ids.h      |   1 +
>  7 files changed, 1905 insertions(+)
>  create mode 100644 hw/pci-host/mv64361.c
>  create mode 100644 hw/pci-host/mv643xx.h
>  create mode 100644 include/hw/pci-host/mv64361.h

Adding yourself to MAINTAINERS for this would be good.

> 
> diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
> index 2ccc96f02c..79c20bf28b 100644
> --- a/hw/pci-host/Kconfig
> +++ b/hw/pci-host/Kconfig
> @@ -72,3 +72,7 @@ config REMOTE_PCIHOST
>  config SH_PCI
>      bool
>      select PCI
> +
> +config MV64361
> +    bool
> +    select PCI
> diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build
> index 87a896973e..34b3538beb 100644
> --- a/hw/pci-host/meson.build
> +++ b/hw/pci-host/meson.build
> @@ -19,6 +19,8 @@ pci_ss.add(when: 'CONFIG_GRACKLE_PCI', if_true: 
> files('grackle.c'))
>  pci_ss.add(when: 'CONFIG_UNIN_PCI', if_true: files('uninorth.c'))
>  # PowerPC E500 boards
>  pci_ss.add(when: 'CONFIG_PPCE500_PCI', if_true: files('ppce500.c'))
> +# Pegasos2
> +pci_ss.add(when: 'CONFIG_MV64361', if_true: files('mv64361.c'))
>  
>  # ARM devices
>  pci_ss.add(when: 'CONFIG_VERSATILE_PCI', if_true: files('versatile.c'))
> diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c
> new file mode 100644
> index 0000000000..d71402f8b5
> --- /dev/null
> +++ b/hw/pci-host/mv64361.c
> @@ -0,0 +1,966 @@
> +/*
> + * Marvell Discovery II MV64361 System Controller for
> + * QEMU PowerPC CHRP (Genesi/bPlan Pegasos II) hardware System Emulator
> + *
> + * Copyright (c) 2018-2020 BALATON Zoltan
> + *
> + * This work is licensed under the GNU GPL license version 2 or later.
> + *
> + */
> +
> +#include "qemu/osdep.h"
> +#include "qemu-common.h"
> +#include "qemu/units.h"
> +#include "qapi/error.h"
> +#include "hw/hw.h"
> +#include "hw/sysbus.h"
> +#include "hw/pci/pci.h"
> +#include "hw/pci/pci_host.h"
> +#include "hw/irq.h"
> +#include "hw/intc/i8259.h"
> +#include "hw/qdev-properties.h"
> +#include "exec/address-spaces.h"
> +#include "qemu/log.h"
> +#include "qemu/error-report.h"
> +#include "trace.h"
> +#include "hw/pci-host/mv64361.h"
> +#include "mv643xx.h"
> +
> +#define TYPE_MV64361_PCI_BRIDGE "mv64361-pcibridge"
> +
> +static void mv64361_pcibridge_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +    PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> +
> +    k->vendor_id = PCI_VENDOR_ID_MARVELL;
> +    k->device_id = PCI_DEVICE_ID_MARVELL_MV6436X;
> +    k->class_id = PCI_CLASS_BRIDGE_HOST;
> +    /*
> +     * PCI-facing part of the host bridge,
> +     * not usable without the host-facing part
> +     */
> +    dc->user_creatable = false;
> +}
> +
> +static const TypeInfo mv64361_pcibridge_info = {
> +    .name          = TYPE_MV64361_PCI_BRIDGE,
> +    .parent        = TYPE_PCI_DEVICE,
> +    .instance_size = sizeof(PCIDevice),
> +    .class_init    = mv64361_pcibridge_class_init,
> +    .interfaces = (InterfaceInfo[]) {
> +        { INTERFACE_CONVENTIONAL_PCI_DEVICE },
> +        { },
> +    },
> +};
> +
> +
> +#define TYPE_MV64361_PCI "mv64361-pcihost"
> +OBJECT_DECLARE_SIMPLE_TYPE(MV64361PCIState, MV64361_PCI)
> +
> +struct MV64361PCIState {
> +    PCIHostState parent_obj;
> +
> +    uint8_t index;
> +    MemoryRegion io;
> +    MemoryRegion mem;
> +    qemu_irq irq[PCI_NUM_PINS];
> +
> +    uint32_t io_base;
> +    uint32_t io_size;
> +    uint32_t mem_base[4];
> +    uint32_t mem_size[4];
> +    uint64_t remap[5];
> +};
> +
> +static int mv64361_pcihost_map_irq(PCIDevice *pci_dev, int n)
> +{
> +    return (n + PCI_SLOT(pci_dev->devfn)) % PCI_NUM_PINS;
> +}
> +
> +static void mv64361_pcihost_set_irq(void *opaque, int n, int level)
> +{
> +    MV64361PCIState *s = opaque;
> +    qemu_set_irq(s->irq[n], level);
> +}
> +
> +static void mv64361_pcihost_realize(DeviceState *dev, Error **errp)
> +{
> +    MV64361PCIState *s = MV64361_PCI(dev);
> +    PCIHostState *h = PCI_HOST_BRIDGE(dev);
> +    char *name;
> +
> +    name = g_strdup_printf("pci%d-io", s->index);
> +    memory_region_init(&s->io, OBJECT(dev), name, 0x10000);
> +    g_free(name);
> +    name = g_strdup_printf("pci%d-mem", s->index);
> +    memory_region_init(&s->mem, OBJECT(dev), name, 1ULL << 32);
> +    g_free(name);
> +    name = g_strdup_printf("pci.%d", s->index);
> +    h->bus = pci_register_root_bus(dev, name, mv64361_pcihost_set_irq,
> +                                   mv64361_pcihost_map_irq, dev,
> +                                   &s->mem, &s->io, 0, 4, TYPE_PCI_BUS);
> +    g_free(name);
> +    pci_create_simple(h->bus, 0, TYPE_MV64361_PCI_BRIDGE);
> +}
> +
> +static Property mv64361_pcihost_props[] = {
> +    DEFINE_PROP_UINT8("index", MV64361PCIState, index, 0),
> +    DEFINE_PROP_END_OF_LIST()
> +};
> +
> +static void mv64361_pcihost_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +
> +    dc->realize = mv64361_pcihost_realize;
> +    device_class_set_props(dc, mv64361_pcihost_props);
> +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> +}
> +
> +static const TypeInfo mv64361_pcihost_info = {
> +       .name          = TYPE_MV64361_PCI,
> +       .parent        = TYPE_PCI_HOST_BRIDGE,
> +       .instance_size = sizeof(MV64361PCIState),
> +       .class_init    = mv64361_pcihost_class_init,
> +};
> +
> +static void mv64361_pci_register_types(void)
> +{
> +   type_register_static(&mv64361_pcihost_info);
> +   type_register_static(&mv64361_pcibridge_info);
> +}
> +
> +type_init(mv64361_pci_register_types)
> +
> +
> +OBJECT_DECLARE_SIMPLE_TYPE(MV64361State, MV64361)
> +
> +struct MV64361State {
> +    SysBusDevice parent_obj;
> +
> +    MemoryRegion regs;
> +    MV64361PCIState pci[2];
> +    MemoryRegion cpu_win[19];
> +    qemu_irq cpu_irq;
> +
> +    /* registers state */
> +    uint32_t cpu_conf;
> +    uint32_t regs_base;
> +    uint32_t base_addr_enable;
> +    uint64_t main_int_cr;
> +    uint64_t cpu0_int_mask;
> +    uint32_t gpp_io;
> +    uint32_t gpp_level;
> +    uint32_t gpp_value;
> +    uint32_t gpp_int_cr;
> +    uint32_t gpp_int_mask;
> +    bool gpp_int_level;
> +};
> +
> +enum mv64361_irq_cause {
> +    MV64361_IRQ_DEVERR = 1,

Since the exact values of each of these matters, I'd prefer to see
explicit values attached to all of them.

> +    MV64361_IRQ_DMAERR,
> +    MV64361_IRQ_CPUERR,
> +    MV64361_IRQ_IDMA0,
> +    MV64361_IRQ_IDMA1,
> +    MV64361_IRQ_IDMA2,
> +    MV64361_IRQ_IDMA3,
> +    MV64361_IRQ_TIMER0,
> +    MV64361_IRQ_TIMER1,
> +    MV64361_IRQ_TIMER2,
> +    MV64361_IRQ_TIMER3,
> +    MV64361_IRQ_PCI0,
> +    MV64361_IRQ_SRAMERR,
> +    MV64361_IRQ_GBEERR,
> +    MV64361_IRQ_CERR,
> +    MV64361_IRQ_PCI1,
> +    MV64361_IRQ_DRAMERR,
> +    MV64361_IRQ_WDNMI,
> +    MV64361_IRQ_WDE,
> +    MV64361_IRQ_PCI0IN,
> +    MV64361_IRQ_PCI0OUT,
> +    MV64361_IRQ_PCI1IN,
> +    MV64361_IRQ_PCI1OUT,
> +    MV64361_IRQ_P1_GPP0_7,
> +    MV64361_IRQ_P1_GPP8_15,
> +    MV64361_IRQ_P1_GPP16_23,
> +    MV64361_IRQ_P1_GPP24_31,
> +    MV64361_IRQ_P1_CPU_DB,
> +    /* 29-31: reserved */
> +    MV64361_IRQ_GBE0 = 32,
> +    MV64361_IRQ_GBE1,
> +    MV64361_IRQ_GBE2,
> +    /* 35: reserved */
> +    MV64361_IRQ_SDMA0 = 36,
> +    MV64361_IRQ_TWSI,
> +    MV64361_IRQ_SDMA1,
> +    MV64361_IRQ_BRG,
> +    MV64361_IRQ_MPSC0,
> +    MV64361_IRQ_MPSC1,
> +    MV64361_IRQ_G0RX,
> +    MV64361_IRQ_G0TX,
> +    MV64361_IRQ_G0MISC,
> +    MV64361_IRQ_G1RX,
> +    MV64361_IRQ_G1TX,
> +    MV64361_IRQ_G1MISC,
> +    MV64361_IRQ_G2RX,
> +    MV64361_IRQ_G2TX,
> +    MV64361_IRQ_G2MISC,
> +    /* 51-55: reserved */
> +    MV64361_IRQ_P0_GPP0_7 = 56,
> +    MV64361_IRQ_P0_GPP8_15,
> +    MV64361_IRQ_P0_GPP16_23,
> +    MV64361_IRQ_P0_GPP24_31,
> +    MV64361_IRQ_P0_CPU_DB,
> +    /* 61-63: reserved */
> +};
> +
> +PCIBus *mv64361_get_pci_bus(DeviceState *dev, int n)
> +{
> +    MV64361State *mv = MV64361(dev);
> +    return PCI_HOST_BRIDGE(&mv->pci[n])->bus;
> +}
> +
> +static void unmap_region(MemoryRegion *mr)
> +{
> +    if (memory_region_is_mapped(mr)) {
> +        memory_region_del_subregion(get_system_memory(), mr);
> +        object_unparent(OBJECT(mr));
> +    }
> +}
> +
> +static void map_pci_region(MemoryRegion *mr, MemoryRegion *parent,
> +                           struct Object *owner, const char *name,
> +                           hwaddr poffs, uint64_t size, hwaddr moffs)
> +{
> +    memory_region_init_alias(mr, owner, name, parent, poffs, size);
> +    memory_region_add_subregion(get_system_memory(), moffs, mr);
> +    trace_mv64361_region_map(name, poffs, size, moffs);
> +}
> +
> +static void setup_mem_windows(MV64361State *s, uint32_t val)
> +{
> +    MV64361PCIState *p;
> +    MemoryRegion *mr;
> +    uint32_t mask;
> +    int i;
> +
> +    val &= 0x1fffff;
> +    for (mask = 1, i = 0; i < 21; i++, mask <<= 1) {

Having a loop, where nearly the entire body is a switch over the loop
variable seems a rather odd choice to me, compared to just unrolling
the whole thing.  Or alternatively, maybe more can be be factored out
of the switch into common body code.

> +        if ((val & mask) != (s->base_addr_enable & mask)) {
> +            trace_mv64361_region_enable(!(val & mask) ? "enable" : 
> "disable", i);
> +            switch (i) {
> +            /*
> +             * 0-3 are SDRAM chip selects but we map all RAM directly
> +             * 4-7 are device chip selects (not sure what those are)
> +             * 8 is Boot device (ROM) chip select but we map that directly 
> too
> +             */
> +            case 9:
> +                p = &s->pci[0];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->io, OBJECT(s), "pci0-io-win",
> +                                   p->remap[4], (p->io_size + 1) << 16,
> +                                   (p->io_base & 0xfffff) << 16);
> +                }
> +                break;
> +            case 10:
> +                p = &s->pci[0];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->mem, OBJECT(s), "pci0-mem0-win",
> +                                   p->remap[0], (p->mem_size[0] + 1) << 16,
> +                                   (p->mem_base[0] & 0xfffff) << 16);
> +                }
> +                break;
> +            case 11:
> +                p = &s->pci[0];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->mem, OBJECT(s), "pci0-mem1-win",
> +                                   p->remap[1], (p->mem_size[1] + 1) << 16,
> +                                   (p->mem_base[1] & 0xfffff) << 16);
> +                }
> +                break;
> +            case 12:
> +                p = &s->pci[0];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->mem, OBJECT(s), "pci0-mem2-win",
> +                                   p->remap[2], (p->mem_size[2] + 1) << 16,
> +                                   (p->mem_base[2] & 0xfffff) << 16);
> +                }
> +                break;
> +            case 13:
> +                p = &s->pci[0];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->mem, OBJECT(s), "pci0-mem3-win",
> +                                   p->remap[3], (p->mem_size[3] + 1) << 16,
> +                                   (p->mem_base[3] & 0xfffff) << 16);
> +                }
> +                break;
> +            case 14:
> +                p = &s->pci[1];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->io, OBJECT(s), "pci1-io-win",
> +                                   p->remap[4], (p->io_size + 1) << 16,
> +                                   (p->io_base & 0xfffff) << 16);
> +                }
> +                break;
> +            case 15:
> +                p = &s->pci[1];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->mem, OBJECT(s), "pci1-mem0-win",
> +                                   p->remap[0], (p->mem_size[0] + 1) << 16,
> +                                   (p->mem_base[0] & 0xfffff) << 16);
> +                }
> +                break;
> +            case 16:
> +                p = &s->pci[1];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->mem, OBJECT(s), "pci1-mem1-win",
> +                                   p->remap[1], (p->mem_size[1] + 1) << 16,
> +                                   (p->mem_base[1] & 0xfffff) << 16);
> +                }
> +                break;
> +            case 17:
> +                p = &s->pci[1];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->mem, OBJECT(s), "pci1-mem2-win",
> +                                   p->remap[2], (p->mem_size[2] + 1) << 16,
> +                                   (p->mem_base[2] & 0xfffff) << 16);
> +                }
> +                break;
> +            case 18:
> +                p = &s->pci[1];
> +                mr = &s->cpu_win[i];
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    map_pci_region(mr, &p->mem, OBJECT(s), "pci1-mem3-win",
> +                                   p->remap[3], (p->mem_size[3] + 1) << 16,
> +                                   (p->mem_base[3] & 0xfffff) << 16);
> +                }
> +                break;
> +            /* 19 is integrated SRAM */
> +            case 20:
> +                mr = &s->regs;
> +                unmap_region(mr);
> +                if (!(val & mask)) {
> +                    memory_region_add_subregion(get_system_memory(),
> +                        (s->regs_base & 0xfffff) << 16, mr);
> +                }
> +                break;
> +            }
> +        }
> +    }
> +}
> +
> +static void mv64361_update_irq(void *opaque, int n, int level)
> +{
> +    MV64361State *s = opaque;
> +    uint64_t val = s->main_int_cr;
> +
> +    if (level) {
> +        val |= BIT_ULL(n);
> +    } else {
> +        val &= ~BIT_ULL(n);
> +    }
> +    if ((s->main_int_cr & s->cpu0_int_mask) != (val & s->cpu0_int_mask)) {
> +        qemu_set_irq(s->cpu_irq, level);
> +    }
> +    s->main_int_cr = val;
> +}
> +
> +static uint64_t mv64361_read(void *opaque, hwaddr addr, unsigned int size)
> +{
> +    MV64361State *s = MV64361(opaque);
> +    uint32_t ret = 0;
> +
> +    switch (addr) {
> +    case MV64340_CPU_CONFIG:
> +        ret = s->cpu_conf;
> +        break;
> +    case MV64340_PCI_0_IO_BASE_ADDR:
> +        ret = s->pci[0].io_base;

Reaching into the PCI internal state here doesn't seem great, although
I'll admit I can't quickly see another way to do it that wouldn't be
horribly verbose.

> +        break;
> +    case MV64340_PCI_0_IO_SIZE:
> +        ret = s->pci[0].io_size;
> +        break;
> +    case MV64340_PCI_0_IO_ADDR_REMAP:
> +        ret = s->pci[0].remap[4] >> 16;
> +        break;
> +    case MV64340_PCI_0_MEMORY0_BASE_ADDR:
> +        ret = s->pci[0].mem_base[0];
> +        break;
> +    case MV64340_PCI_0_MEMORY0_SIZE:
> +        ret = s->pci[0].mem_size[0];
> +        break;
> +    case MV64340_PCI_0_MEMORY0_LOW_ADDR_REMAP:
> +        ret = (s->pci[0].remap[0] & 0xffff0000) >> 16;
> +        break;
> +    case MV64340_PCI_0_MEMORY0_HIGH_ADDR_REMAP:
> +        ret = s->pci[0].remap[0] >> 32;
> +        break;
> +    case MV64340_PCI_0_MEMORY1_BASE_ADDR:
> +        ret = s->pci[0].mem_base[1];
> +        break;
> +    case MV64340_PCI_0_MEMORY1_SIZE:
> +        ret = s->pci[0].mem_size[1];
> +        break;
> +    case MV64340_PCI_0_MEMORY1_LOW_ADDR_REMAP:
> +        ret = (s->pci[0].remap[1] & 0xffff0000) >> 16;
> +        break;
> +    case MV64340_PCI_0_MEMORY1_HIGH_ADDR_REMAP:
> +        ret = s->pci[0].remap[1] >> 32;
> +        break;
> +    case MV64340_PCI_0_MEMORY2_BASE_ADDR:
> +        ret = s->pci[0].mem_base[2];
> +        break;
> +    case MV64340_PCI_0_MEMORY2_SIZE:
> +        ret = s->pci[0].mem_size[2];
> +        break;
> +    case MV64340_PCI_0_MEMORY2_LOW_ADDR_REMAP:
> +        ret = (s->pci[0].remap[2] & 0xffff0000) >> 16;
> +        break;
> +    case MV64340_PCI_0_MEMORY2_HIGH_ADDR_REMAP:
> +        ret = s->pci[0].remap[2] >> 32;
> +        break;
> +    case MV64340_PCI_0_MEMORY3_BASE_ADDR:
> +        ret = s->pci[0].mem_base[3];
> +        break;
> +    case MV64340_PCI_0_MEMORY3_SIZE:
> +        ret = s->pci[0].mem_size[3];
> +        break;
> +    case MV64340_PCI_0_MEMORY3_LOW_ADDR_REMAP:
> +        ret = (s->pci[0].remap[3] & 0xffff0000) >> 16;
> +        break;
> +    case MV64340_PCI_0_MEMORY3_HIGH_ADDR_REMAP:
> +        ret = s->pci[0].remap[3] >> 32;
> +        break;
> +    case MV64340_PCI_1_IO_BASE_ADDR:
> +        ret = s->pci[1].io_base;
> +        break;
> +    case MV64340_PCI_1_IO_SIZE:
> +        ret = s->pci[1].io_size;
> +        break;
> +    case MV64340_PCI_1_IO_ADDR_REMAP:
> +        ret = s->pci[1].remap[4] >> 16;
> +        break;
> +    case MV64340_PCI_1_MEMORY0_BASE_ADDR:
> +        ret = s->pci[1].mem_base[0];
> +        break;
> +    case MV64340_PCI_1_MEMORY0_SIZE:
> +        ret = s->pci[1].mem_size[0];
> +        break;
> +    case MV64340_PCI_1_MEMORY0_LOW_ADDR_REMAP:
> +        ret = (s->pci[1].remap[0] & 0xffff0000) >> 16;
> +        break;
> +    case MV64340_PCI_1_MEMORY0_HIGH_ADDR_REMAP:
> +        ret = s->pci[1].remap[0] >> 32;
> +        break;
> +    case MV64340_PCI_1_MEMORY1_BASE_ADDR:
> +        ret = s->pci[1].mem_base[1];
> +        break;
> +    case MV64340_PCI_1_MEMORY1_SIZE:
> +        ret = s->pci[1].mem_size[1];
> +        break;
> +    case MV64340_PCI_1_MEMORY1_LOW_ADDR_REMAP:
> +        ret = (s->pci[1].remap[1] & 0xffff0000) >> 16;
> +        break;
> +    case MV64340_PCI_1_MEMORY1_HIGH_ADDR_REMAP:
> +        ret = s->pci[1].remap[1] >> 32;
> +        break;
> +    case MV64340_PCI_1_MEMORY2_BASE_ADDR:
> +        ret = s->pci[1].mem_base[2];
> +        break;
> +    case MV64340_PCI_1_MEMORY2_SIZE:
> +        ret = s->pci[1].mem_size[2];
> +        break;
> +    case MV64340_PCI_1_MEMORY2_LOW_ADDR_REMAP:
> +        ret = (s->pci[1].remap[2] & 0xffff0000) >> 16;
> +        break;
> +    case MV64340_PCI_1_MEMORY2_HIGH_ADDR_REMAP:
> +        ret = s->pci[1].remap[2] >> 32;
> +        break;
> +    case MV64340_PCI_1_MEMORY3_BASE_ADDR:
> +        ret = s->pci[1].mem_base[3];
> +        break;
> +    case MV64340_PCI_1_MEMORY3_SIZE:
> +        ret = s->pci[1].mem_size[3];
> +        break;
> +    case MV64340_PCI_1_MEMORY3_LOW_ADDR_REMAP:
> +        ret = (s->pci[1].remap[3] & 0xffff0000) >> 16;
> +        break;
> +    case MV64340_PCI_1_MEMORY3_HIGH_ADDR_REMAP:
> +        ret = s->pci[1].remap[3] >> 32;
> +        break;
> +    case MV64340_INTERNAL_SPACE_BASE_ADDR:
> +        ret = s->regs_base;
> +        break;
> +    case MV64340_BASE_ADDR_ENABLE:
> +        ret = s->base_addr_enable;
> +        break;
> +    case MV64340_PCI_0_CONFIG_ADDR:
> +        ret = pci_host_conf_le_ops.read(PCI_HOST_BRIDGE(&s->pci[0]), 0, 
> size);
> +        break;
> +    case MV64340_PCI_0_CONFIG_DATA_VIRTUAL_REG ...
> +         MV64340_PCI_0_CONFIG_DATA_VIRTUAL_REG + 3:
> +        ret = pci_host_data_le_ops.read(PCI_HOST_BRIDGE(&s->pci[0]),
> +                  addr - MV64340_PCI_0_CONFIG_DATA_VIRTUAL_REG, size);
> +        break;
> +    case MV64340_PCI_1_CONFIG_ADDR:
> +        ret = pci_host_conf_le_ops.read(PCI_HOST_BRIDGE(&s->pci[1]), 0, 
> size);
> +        break;
> +    case MV64340_PCI_1_CONFIG_DATA_VIRTUAL_REG ...
> +         MV64340_PCI_1_CONFIG_DATA_VIRTUAL_REG + 3:
> +        ret = pci_host_data_le_ops.read(PCI_HOST_BRIDGE(&s->pci[1]),
> +                  addr - MV64340_PCI_1_CONFIG_DATA_VIRTUAL_REG, size);
> +        break;
> +    case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG:
> +        /* FIXME: Should this be sent via the PCI bus somehow? */
> +        if (s->gpp_int_level && (s->gpp_value & BIT(31))) {
> +            ret = pic_read_irq(isa_pic);
> +        }
> +        break;
> +    case MV64340_MAIN_INTERRUPT_CAUSE_LOW:
> +        ret = s->main_int_cr;
> +        break;
> +    case MV64340_MAIN_INTERRUPT_CAUSE_HIGH:
> +        ret = s->main_int_cr >> 32;
> +        break;
> +    case MV64340_CPU_INTERRUPT0_MASK_LOW:
> +        ret = s->cpu0_int_mask;
> +        break;
> +    case MV64340_CPU_INTERRUPT0_MASK_HIGH:
> +        ret = s->cpu0_int_mask >> 32;
> +        break;
> +    case MV64340_CPU_INTERRUPT0_SELECT_CAUSE:
> +        ret = s->main_int_cr;
> +        if (s->main_int_cr & s->cpu0_int_mask) {
> +            if (!(s->main_int_cr & s->cpu0_int_mask & 0xffffffff)) {
> +                ret = s->main_int_cr >> 32 | BIT(30);
> +            } else if ((s->main_int_cr & s->cpu0_int_mask) >> 32) {
> +                ret |= BIT(31);
> +            }
> +        }
> +        break;
> +    case MV64340_CUNIT_ARBITER_CONTROL_REG:
> +        ret = 0x11ff0000 | (s->gpp_int_level << 10);
> +        break;
> +    case MV64340_GPP_IO_CONTROL:
> +        ret = s->gpp_io;
> +        break;
> +    case MV64340_GPP_LEVEL_CONTROL:
> +        ret = s->gpp_level;
> +        break;
> +    case MV64340_GPP_VALUE:
> +        ret = s->gpp_value;
> +        break;
> +    case MV64340_GPP_VALUE_SET:
> +    case MV64340_GPP_VALUE_CLEAR:
> +        ret = 0;
> +        break;
> +    case MV64340_GPP_INTERRUPT_CAUSE:
> +        ret = s->gpp_int_cr;
> +        break;
> +    case MV64340_GPP_INTERRUPT_MASK0:
> +    case MV64340_GPP_INTERRUPT_MASK1:
> +        ret = s->gpp_int_mask;
> +        break;
> +    default:
> +        qemu_log_mask(LOG_UNIMP, "%s: Unimplemented register read 0x%"
> +                      HWADDR_PRIx "\n", __func__, addr);
> +        break;
> +    }
> +    if (addr != MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG) {
> +        trace_mv64361_reg_read(addr, ret);
> +    }
> +    return ret;
> +}
> +
> +static void warn_swap_bit(uint64_t val)
> +{
> +    if ((val & 0x3000000ULL) >> 24 != 1) {
> +        qemu_log_mask(LOG_UNIMP, "%s: Data swap not implemented", __func__);
> +    }
> +}
> +
> +static void mv64361_set_pci_mem_remap(MV64361State *s, int bus, int idx,
> +                                      uint64_t val, bool high)
> +{
> +    if (high) {
> +        s->pci[bus].remap[idx] = val;
> +    } else {
> +        s->pci[bus].remap[idx] &= 0xffffffff00000000ULL;
> +        s->pci[bus].remap[idx] |= (val & 0xffffULL) << 16;
> +    }
> +}
> +
> +static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,
> +                          unsigned int size)
> +{
> +    MV64361State *s = MV64361(opaque);
> +
> +    trace_mv64361_reg_write(addr, val);
> +    switch (addr) {
> +    case MV64340_CPU_CONFIG:
> +        s->cpu_conf = val & 0xe4e3bffULL;
> +        s->cpu_conf |= BIT(23);
> +        break;
> +    case MV64340_PCI_0_IO_BASE_ADDR:
> +        s->pci[0].io_base = val & 0x30fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            s->pci[0].remap[4] = (val & 0xffffULL) << 16;
> +        }
> +        break;
> +    case MV64340_PCI_0_IO_SIZE:
> +        s->pci[0].io_size = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_0_IO_ADDR_REMAP:
> +        s->pci[0].remap[4] = (val & 0xffffULL) << 16;
> +        break;
> +    case MV64340_PCI_0_MEMORY0_BASE_ADDR:
> +        s->pci[0].mem_base[0] = val & 0x70fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            mv64361_set_pci_mem_remap(s, 0, 0, val, false);
> +        }
> +        break;
> +    case MV64340_PCI_0_MEMORY0_SIZE:
> +        s->pci[0].mem_size[0] = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_0_MEMORY0_LOW_ADDR_REMAP:
> +    case MV64340_PCI_0_MEMORY0_HIGH_ADDR_REMAP:
> +        mv64361_set_pci_mem_remap(s, 0, 0, val,
> +            (addr == MV64340_PCI_0_MEMORY0_HIGH_ADDR_REMAP));
> +        break;
> +    case MV64340_PCI_0_MEMORY1_BASE_ADDR:
> +        s->pci[0].mem_base[1] = val & 0x70fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            mv64361_set_pci_mem_remap(s, 0, 1, val, false);
> +        }
> +        break;
> +    case MV64340_PCI_0_MEMORY1_SIZE:
> +        s->pci[0].mem_size[1] = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_0_MEMORY1_LOW_ADDR_REMAP:
> +    case MV64340_PCI_0_MEMORY1_HIGH_ADDR_REMAP:
> +        mv64361_set_pci_mem_remap(s, 0, 1, val,
> +            (addr == MV64340_PCI_0_MEMORY1_HIGH_ADDR_REMAP));
> +        break;
> +    case MV64340_PCI_0_MEMORY2_BASE_ADDR:
> +        s->pci[0].mem_base[2] = val & 0x70fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            mv64361_set_pci_mem_remap(s, 0, 2, val, false);
> +        }
> +        break;
> +    case MV64340_PCI_0_MEMORY2_SIZE:
> +        s->pci[0].mem_size[2] = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_0_MEMORY2_LOW_ADDR_REMAP:
> +    case MV64340_PCI_0_MEMORY2_HIGH_ADDR_REMAP:
> +        mv64361_set_pci_mem_remap(s, 0, 2, val,
> +            (addr == MV64340_PCI_0_MEMORY2_HIGH_ADDR_REMAP));
> +        break;
> +    case MV64340_PCI_0_MEMORY3_BASE_ADDR:
> +        s->pci[0].mem_base[3] = val & 0x70fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            mv64361_set_pci_mem_remap(s, 0, 3, val, false);
> +        }
> +        break;
> +    case MV64340_PCI_0_MEMORY3_SIZE:
> +        s->pci[0].mem_size[3] = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_0_MEMORY3_LOW_ADDR_REMAP:
> +    case MV64340_PCI_0_MEMORY3_HIGH_ADDR_REMAP:
> +        mv64361_set_pci_mem_remap(s, 0, 3, val,
> +            (addr == MV64340_PCI_0_MEMORY3_HIGH_ADDR_REMAP));
> +        break;
> +    case MV64340_PCI_1_IO_BASE_ADDR:
> +        s->pci[1].io_base = val & 0x30fffffULL;
> +        warn_swap_bit(val);
> +        break;
> +        if (!(s->cpu_conf & BIT(27))) {
> +            s->pci[1].remap[4] = (val & 0xffffULL) << 16;
> +        }
> +        break;
> +    case MV64340_PCI_1_IO_SIZE:
> +        s->pci[1].io_size = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_1_MEMORY0_BASE_ADDR:
> +        s->pci[1].mem_base[0] = val & 0x70fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            mv64361_set_pci_mem_remap(s, 1, 0, val, false);
> +        }
> +        break;
> +    case MV64340_PCI_1_MEMORY0_SIZE:
> +        s->pci[1].mem_size[0] = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_1_MEMORY0_LOW_ADDR_REMAP:
> +    case MV64340_PCI_1_MEMORY0_HIGH_ADDR_REMAP:
> +        mv64361_set_pci_mem_remap(s, 1, 0, val,
> +            (addr == MV64340_PCI_1_MEMORY0_HIGH_ADDR_REMAP));
> +        break;
> +    case MV64340_PCI_1_MEMORY1_BASE_ADDR:
> +        s->pci[1].mem_base[1] = val & 0x70fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            mv64361_set_pci_mem_remap(s, 1, 1, val, false);
> +        }
> +        break;
> +    case MV64340_PCI_1_MEMORY1_SIZE:
> +        s->pci[1].mem_size[1] = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_1_MEMORY1_LOW_ADDR_REMAP:
> +    case MV64340_PCI_1_MEMORY1_HIGH_ADDR_REMAP:
> +        mv64361_set_pci_mem_remap(s, 1, 1, val,
> +            (addr == MV64340_PCI_1_MEMORY1_HIGH_ADDR_REMAP));
> +        break;
> +    case MV64340_PCI_1_MEMORY2_BASE_ADDR:
> +        s->pci[1].mem_base[2] = val & 0x70fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            mv64361_set_pci_mem_remap(s, 1, 2, val, false);
> +        }
> +        break;
> +    case MV64340_PCI_1_MEMORY2_SIZE:
> +        s->pci[1].mem_size[2] = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_1_MEMORY2_LOW_ADDR_REMAP:
> +    case MV64340_PCI_1_MEMORY2_HIGH_ADDR_REMAP:
> +        mv64361_set_pci_mem_remap(s, 1, 2, val,
> +            (addr == MV64340_PCI_1_MEMORY2_HIGH_ADDR_REMAP));
> +        break;
> +    case MV64340_PCI_1_MEMORY3_BASE_ADDR:
> +        s->pci[1].mem_base[3] = val & 0x70fffffULL;
> +        warn_swap_bit(val);
> +        if (!(s->cpu_conf & BIT(27))) {
> +            mv64361_set_pci_mem_remap(s, 1, 3, val, false);
> +        }
> +        break;
> +    case MV64340_PCI_1_MEMORY3_SIZE:
> +        s->pci[1].mem_size[3] = val & 0xffffULL;
> +        break;
> +    case MV64340_PCI_1_MEMORY3_LOW_ADDR_REMAP:
> +    case MV64340_PCI_1_MEMORY3_HIGH_ADDR_REMAP:
> +        mv64361_set_pci_mem_remap(s, 1, 3, val,
> +            (addr == MV64340_PCI_1_MEMORY3_HIGH_ADDR_REMAP));
> +        break;
> +    case MV64340_INTERNAL_SPACE_BASE_ADDR:
> +        s->regs_base = val & 0xfffffULL;
> +        break;
> +    case MV64340_BASE_ADDR_ENABLE:
> +        setup_mem_windows(s, val);
> +        s->base_addr_enable = val & 0x1fffffULL;

AFAICT every call to setup_mem_windows() is followed by an update to
base_addr_enable, so it probably makes sense to fold that update into
setup_mem_windows().

> +        break;
> +    case MV64340_PCI_0_CONFIG_ADDR:
> +        pci_host_conf_le_ops.write(PCI_HOST_BRIDGE(&s->pci[0]), 0, val, 
> size);
> +        break;
> +    case MV64340_PCI_0_CONFIG_DATA_VIRTUAL_REG ...
> +         MV64340_PCI_0_CONFIG_DATA_VIRTUAL_REG + 3:
> +        pci_host_data_le_ops.write(PCI_HOST_BRIDGE(&s->pci[0]),
> +            addr - MV64340_PCI_0_CONFIG_DATA_VIRTUAL_REG, val, size);
> +        break;
> +    case MV64340_PCI_1_CONFIG_ADDR:
> +        pci_host_conf_le_ops.write(PCI_HOST_BRIDGE(&s->pci[1]), 0, val, 
> size);
> +        break;
> +    case MV64340_PCI_1_CONFIG_DATA_VIRTUAL_REG ...
> +         MV64340_PCI_1_CONFIG_DATA_VIRTUAL_REG + 3:
> +        pci_host_data_le_ops.write(PCI_HOST_BRIDGE(&s->pci[1]),
> +            addr - MV64340_PCI_1_CONFIG_DATA_VIRTUAL_REG, val, size);
> +        break;
> +    case MV64340_CPU_INTERRUPT0_MASK_LOW:
> +        s->cpu0_int_mask &= 0xffffffff00000000ULL;
> +        s->cpu0_int_mask |= val & 0xffffffffULL;
> +        break;
> +    case MV64340_CPU_INTERRUPT0_MASK_HIGH:
> +        s->cpu0_int_mask &= 0xffffffffULL;
> +        s->cpu0_int_mask |= val << 32;
> +        break;
> +    case MV64340_CUNIT_ARBITER_CONTROL_REG:
> +        s->gpp_int_level = !!(val & BIT(10));
> +        break;
> +    case MV64340_GPP_IO_CONTROL:
> +        s->gpp_io = val;
> +        break;
> +    case MV64340_GPP_LEVEL_CONTROL:
> +        s->gpp_level = val;
> +        break;
> +    case MV64340_GPP_VALUE:
> +        s->gpp_value &= ~s->gpp_io;
> +        s->gpp_value |= val & s->gpp_io;
> +        break;
> +    case MV64340_GPP_VALUE_SET:
> +        s->gpp_value |= val & s->gpp_io;
> +        break;
> +    case MV64340_GPP_VALUE_CLEAR:
> +        s->gpp_value &= ~(val & s->gpp_io);
> +        break;
> +    case MV64340_GPP_INTERRUPT_CAUSE:
> +        if (!s->gpp_int_level && val != s->gpp_int_cr) {
> +            int i;
> +            uint32_t ch = s->gpp_int_cr ^ val;
> +            s->gpp_int_cr = val;
> +            for (i = 0; i < 4; i++) {
> +                if ((ch & 0xff << i) && !(val & 0xff << i)) {
> +                    mv64361_update_irq(opaque, MV64361_IRQ_P0_GPP0_7 + i, 0);
> +                }
> +            }
> +        } else {
> +            s->gpp_int_cr = val;
> +        }
> +        break;
> +    case MV64340_GPP_INTERRUPT_MASK0:
> +    case MV64340_GPP_INTERRUPT_MASK1:
> +        s->gpp_int_mask = val;
> +        break;
> +    default:
> +        qemu_log_mask(LOG_UNIMP, "%s: Unimplemented register write 0x%"
> +                      HWADDR_PRIx " = %"PRIx64"\n", __func__, addr, val);
> +        break;
> +    }
> +}
> +
> +static const MemoryRegionOps mv64361_ops = {
> +    .read = mv64361_read,
> +    .write = mv64361_write,
> +    .valid.min_access_size = 1,
> +    .valid.max_access_size = 4,
> +    .endianness = DEVICE_LITTLE_ENDIAN,
> +};
> +
> +static void mv64361_gpp_irq(void *opaque, int n, int level)
> +{
> +    MV64361State *s = opaque;
> +    uint32_t mask = BIT(n);
> +    uint32_t val = s->gpp_value & ~mask;
> +
> +    if (s->gpp_level & mask) {
> +        level = !level;
> +    }
> +    val |= level << n;
> +    if (val > s->gpp_value) {
> +        s->gpp_value = val;
> +        s->gpp_int_cr |= mask;
> +        if (s->gpp_int_mask & mask) {
> +            mv64361_update_irq(opaque, MV64361_IRQ_P0_GPP0_7 + n / 8, 1);
> +        }
> +    } else if (val < s->gpp_value) {
> +        int b = n / 8;
> +        s->gpp_value = val;
> +        if (s->gpp_int_level && !(val & 0xff << b)) {
> +            mv64361_update_irq(opaque, MV64361_IRQ_P0_GPP0_7 + b, 0);
> +        }
> +    }
> +}
> +
> +static void mv64361_realize(DeviceState *dev, Error **errp)
> +{
> +    MV64361State *s = MV64361(dev);
> +    int i;
> +
> +    s->base_addr_enable = 0x1fffff;
> +    memory_region_init_io(&s->regs, OBJECT(s), &mv64361_ops, s,
> +                          TYPE_MV64361, 0x10000);
> +    for (i = 0; i < 2; i++) {
> +        char *name = g_strdup_printf("pcihost%d", i);
> +        object_initialize_child(OBJECT(dev), name, &s->pci[i],
> +                                TYPE_MV64361_PCI);
> +        g_free(name);

You can avoid some of these awkward free()s using a g_autofree
annotation.

> +        DeviceState *pci = DEVICE(&s->pci[i]);
> +        qdev_prop_set_uint8(pci, "index", i);
> +        sysbus_realize_and_unref(SYS_BUS_DEVICE(pci), &error_fatal);
> +    }
> +    sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->cpu_irq);
> +    qdev_init_gpio_in_named(dev, mv64361_gpp_irq, "gpp", 32);
> +    /* FIXME: PCI IRQ connections may be board specific */
> +    for (i = 0; i < PCI_NUM_PINS; i++) {
> +        s->pci[1].irq[i] = qdev_get_gpio_in_named(dev, "gpp", 12 + i);
> +    }
> +}
> +
> +static void mv64361_reset(DeviceState *dev)
> +{
> +    MV64361State *s = MV64361(dev);
> +    int i, j;
> +
> +    /*
> +     * These values may be board specific
> +     * Real chip supports init from an eprom but that's not modelled
> +     */
> +    setup_mem_windows(s, 0x1fffff);
> +    s->base_addr_enable = 0x1fffff;
> +    s->cpu_conf = 0x28000ff;
> +    s->regs_base = 0x100f100;
> +    s->pci[0].io_base = 0x100f800;
> +    s->pci[0].io_size = 0xff;
> +    s->pci[0].mem_base[0] = 0x100c000;
> +    s->pci[0].mem_size[0] = 0x1fff;
> +    s->pci[0].mem_base[1] = 0x100f900;
> +    s->pci[0].mem_size[1] = 0xff;
> +    s->pci[0].mem_base[2] = 0x100f400;
> +    s->pci[0].mem_size[2] = 0x1ff;
> +    s->pci[0].mem_base[3] = 0x100f600;
> +    s->pci[0].mem_size[3] = 0x1ff;
> +    s->pci[1].io_base = 0x100fe00;
> +    s->pci[1].io_size = 0xff;
> +    s->pci[1].mem_base[0] = 0x1008000;
> +    s->pci[1].mem_size[0] = 0x3fff;
> +    s->pci[1].mem_base[1] = 0x100fd00;
> +    s->pci[1].mem_size[1] = 0xff;
> +    s->pci[1].mem_base[2] = 0x1002600;
> +    s->pci[1].mem_size[2] = 0x1ff;
> +    s->pci[1].mem_base[3] = 0x100ff80;
> +    s->pci[1].mem_size[3] = 0x7f;
> +    for (i = 0; i < 2; i++) {
> +        for (j = 0; j < 4; j++) {
> +            s->pci[i].remap[j] = s->pci[i].mem_base[j] << 16;
> +        }
> +    }
> +    s->pci[0].remap[1] = 0;
> +    s->pci[1].remap[1] = 0;
> +    setup_mem_windows(s, 0xfbfff);
> +    s->base_addr_enable = 0xfbfff;
> +}
> +
> +static void mv64361_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +
> +    dc->realize = mv64361_realize;
> +    dc->reset = mv64361_reset;
> +}
> +
> +static const TypeInfo mv64361_type_info = {
> +    .name = TYPE_MV64361,
> +    .parent = TYPE_SYS_BUS_DEVICE,
> +    .instance_size = sizeof(MV64361State),
> +    .class_init = mv64361_class_init,
> +};
> +
> +static void mv64361_register_types(void)
> +{
> +    type_register_static(&mv64361_type_info);
> +}
> +
> +type_init(mv64361_register_types)
> diff --git a/hw/pci-host/mv643xx.h b/hw/pci-host/mv643xx.h
> new file mode 100644
> index 0000000000..cd26a43f18
> --- /dev/null
> +++ b/hw/pci-host/mv643xx.h
> @@ -0,0 +1,918 @@
> +/*
> + * mv643xx.h - MV-643XX Internal registers definition file.
> + *
> + * Copyright 2002 Momentum Computer, Inc.
> + *      Author: Matthew Dharm <mdharm@momenco.com>
> + * Copyright 2002 GALILEO TECHNOLOGY, LTD.
> + *
> + * This program is free software; you can redistribute  it and/or modify it
> + * under  the terms of  the GNU General  Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */
> +#ifndef ASM_MV643XX_H
> +#define ASM_MV643XX_H
> +
> +/****************************************/
> +/* Processor Address Space              */
> +/****************************************/
> +
> +/* DDR SDRAM BAR and size registers */
> +
> +#define MV64340_CS_0_BASE_ADDR                                      0x008
> +#define MV64340_CS_0_SIZE                                           0x010
> +#define MV64340_CS_1_BASE_ADDR                                      0x208
> +#define MV64340_CS_1_SIZE                                           0x210
> +#define MV64340_CS_2_BASE_ADDR                                      0x018
> +#define MV64340_CS_2_SIZE                                           0x020
> +#define MV64340_CS_3_BASE_ADDR                                      0x218
> +#define MV64340_CS_3_SIZE                                           0x220
> +
> +/* Devices BAR and size registers */
> +
> +#define MV64340_DEV_CS0_BASE_ADDR                                   0x028
> +#define MV64340_DEV_CS0_SIZE                                        0x030
> +#define MV64340_DEV_CS1_BASE_ADDR                                   0x228
> +#define MV64340_DEV_CS1_SIZE                                        0x230
> +#define MV64340_DEV_CS2_BASE_ADDR                                   0x248
> +#define MV64340_DEV_CS2_SIZE                                        0x250
> +#define MV64340_DEV_CS3_BASE_ADDR                                   0x038
> +#define MV64340_DEV_CS3_SIZE                                        0x040
> +#define MV64340_BOOTCS_BASE_ADDR                                    0x238
> +#define MV64340_BOOTCS_SIZE                                         0x240
> +
> +/* PCI 0 BAR and size registers */
> +
> +#define MV64340_PCI_0_IO_BASE_ADDR                                  0x048
> +#define MV64340_PCI_0_IO_SIZE                                       0x050
> +#define MV64340_PCI_0_MEMORY0_BASE_ADDR                             0x058
> +#define MV64340_PCI_0_MEMORY0_SIZE                                  0x060
> +#define MV64340_PCI_0_MEMORY1_BASE_ADDR                             0x080
> +#define MV64340_PCI_0_MEMORY1_SIZE                                  0x088
> +#define MV64340_PCI_0_MEMORY2_BASE_ADDR                             0x258
> +#define MV64340_PCI_0_MEMORY2_SIZE                                  0x260
> +#define MV64340_PCI_0_MEMORY3_BASE_ADDR                             0x280
> +#define MV64340_PCI_0_MEMORY3_SIZE                                  0x288
> +
> +/* PCI 1 BAR and size registers */
> +#define MV64340_PCI_1_IO_BASE_ADDR                                  0x090
> +#define MV64340_PCI_1_IO_SIZE                                       0x098
> +#define MV64340_PCI_1_MEMORY0_BASE_ADDR                             0x0a0
> +#define MV64340_PCI_1_MEMORY0_SIZE                                  0x0a8
> +#define MV64340_PCI_1_MEMORY1_BASE_ADDR                             0x0b0
> +#define MV64340_PCI_1_MEMORY1_SIZE                                  0x0b8
> +#define MV64340_PCI_1_MEMORY2_BASE_ADDR                             0x2a0
> +#define MV64340_PCI_1_MEMORY2_SIZE                                  0x2a8
> +#define MV64340_PCI_1_MEMORY3_BASE_ADDR                             0x2b0
> +#define MV64340_PCI_1_MEMORY3_SIZE                                  0x2b8
> +
> +/* SRAM base address */
> +#define MV64340_INTEGRATED_SRAM_BASE_ADDR                           0x268
> +
> +/* internal registers space base address */
> +#define MV64340_INTERNAL_SPACE_BASE_ADDR                            0x068
> +
> +/* Enables the CS , DEV_CS , PCI 0 and PCI 1 windows above */
> +#define MV64340_BASE_ADDR_ENABLE                                    0x278
> +
> +/****************************************/
> +/* PCI remap registers                  */
> +/****************************************/
> +
> +      /* PCI 0 */
> +#define MV64340_PCI_0_IO_ADDR_REMAP                                 0x0f0
> +#define MV64340_PCI_0_MEMORY0_LOW_ADDR_REMAP                        0x0f8
> +#define MV64340_PCI_0_MEMORY0_HIGH_ADDR_REMAP                       0x320
> +#define MV64340_PCI_0_MEMORY1_LOW_ADDR_REMAP                        0x100
> +#define MV64340_PCI_0_MEMORY1_HIGH_ADDR_REMAP                       0x328
> +#define MV64340_PCI_0_MEMORY2_LOW_ADDR_REMAP                        0x2f8
> +#define MV64340_PCI_0_MEMORY2_HIGH_ADDR_REMAP                       0x330
> +#define MV64340_PCI_0_MEMORY3_LOW_ADDR_REMAP                        0x300
> +#define MV64340_PCI_0_MEMORY3_HIGH_ADDR_REMAP                       0x338
> +      /* PCI 1 */
> +#define MV64340_PCI_1_IO_ADDR_REMAP                                 0x108
> +#define MV64340_PCI_1_MEMORY0_LOW_ADDR_REMAP                        0x110
> +#define MV64340_PCI_1_MEMORY0_HIGH_ADDR_REMAP                       0x340
> +#define MV64340_PCI_1_MEMORY1_LOW_ADDR_REMAP                        0x118
> +#define MV64340_PCI_1_MEMORY1_HIGH_ADDR_REMAP                       0x348
> +#define MV64340_PCI_1_MEMORY2_LOW_ADDR_REMAP                        0x310
> +#define MV64340_PCI_1_MEMORY2_HIGH_ADDR_REMAP                       0x350
> +#define MV64340_PCI_1_MEMORY3_LOW_ADDR_REMAP                        0x318
> +#define MV64340_PCI_1_MEMORY3_HIGH_ADDR_REMAP                       0x358
> +
> +#define MV64340_CPU_PCI_0_HEADERS_RETARGET_CONTROL                  0x3b0
> +#define MV64340_CPU_PCI_0_HEADERS_RETARGET_BASE                     0x3b8
> +#define MV64340_CPU_PCI_1_HEADERS_RETARGET_CONTROL                  0x3c0
> +#define MV64340_CPU_PCI_1_HEADERS_RETARGET_BASE                     0x3c8
> +#define MV64340_CPU_GE_HEADERS_RETARGET_CONTROL                     0x3d0
> +#define MV64340_CPU_GE_HEADERS_RETARGET_BASE                        0x3d8
> +#define MV64340_CPU_IDMA_HEADERS_RETARGET_CONTROL                   0x3e0
> +#define MV64340_CPU_IDMA_HEADERS_RETARGET_BASE                      0x3e8
> +
> +/****************************************/
> +/*         CPU Control Registers        */
> +/****************************************/
> +
> +#define MV64340_CPU_CONFIG                                          0x000
> +#define MV64340_CPU_MODE                                            0x120
> +#define MV64340_CPU_MASTER_CONTROL                                  0x160
> +#define MV64340_CPU_CROSS_BAR_CONTROL_LOW                           0x150
> +#define MV64340_CPU_CROSS_BAR_CONTROL_HIGH                          0x158
> +#define MV64340_CPU_CROSS_BAR_TIMEOUT                               0x168
> +
> +/****************************************/
> +/* SMP RegisterS                        */
> +/****************************************/
> +
> +#define MV64340_SMP_WHO_AM_I                                        0x200
> +#define MV64340_SMP_CPU0_DOORBELL                                   0x214
> +#define MV64340_SMP_CPU0_DOORBELL_CLEAR                             0x21C
> +#define MV64340_SMP_CPU1_DOORBELL                                   0x224
> +#define MV64340_SMP_CPU1_DOORBELL_CLEAR                             0x22C
> +#define MV64340_SMP_CPU0_DOORBELL_MASK                              0x234
> +#define MV64340_SMP_CPU1_DOORBELL_MASK                              0x23C
> +#define MV64340_SMP_SEMAPHOR0                                       0x244
> +#define MV64340_SMP_SEMAPHOR1                                       0x24c
> +#define MV64340_SMP_SEMAPHOR2                                       0x254
> +#define MV64340_SMP_SEMAPHOR3                                       0x25c
> +#define MV64340_SMP_SEMAPHOR4                                       0x264
> +#define MV64340_SMP_SEMAPHOR5                                       0x26c
> +#define MV64340_SMP_SEMAPHOR6                                       0x274
> +#define MV64340_SMP_SEMAPHOR7                                       0x27c
> +
> +/****************************************/
> +/*  CPU Sync Barrier Register           */
> +/****************************************/
> +
> +#define MV64340_CPU_0_SYNC_BARRIER_TRIGGER                          0x0c0
> +#define MV64340_CPU_0_SYNC_BARRIER_VIRTUAL                          0x0c8
> +#define MV64340_CPU_1_SYNC_BARRIER_TRIGGER                          0x0d0
> +#define MV64340_CPU_1_SYNC_BARRIER_VIRTUAL                          0x0d8
> +
> +/****************************************/
> +/* CPU Access Protect                   */
> +/****************************************/
> +
> +#define MV64340_CPU_PROTECT_WINDOW_0_BASE_ADDR                      0x180
> +#define MV64340_CPU_PROTECT_WINDOW_0_SIZE                           0x188
> +#define MV64340_CPU_PROTECT_WINDOW_1_BASE_ADDR                      0x190
> +#define MV64340_CPU_PROTECT_WINDOW_1_SIZE                           0x198
> +#define MV64340_CPU_PROTECT_WINDOW_2_BASE_ADDR                      0x1a0
> +#define MV64340_CPU_PROTECT_WINDOW_2_SIZE                           0x1a8
> +#define MV64340_CPU_PROTECT_WINDOW_3_BASE_ADDR                      0x1b0
> +#define MV64340_CPU_PROTECT_WINDOW_3_SIZE                           0x1b8
> +
> +
> +/****************************************/
> +/*          CPU Error Report            */
> +/****************************************/
> +
> +#define MV64340_CPU_ERROR_ADDR_LOW                                  0x070
> +#define MV64340_CPU_ERROR_ADDR_HIGH                                 0x078
> +#define MV64340_CPU_ERROR_DATA_LOW                                  0x128
> +#define MV64340_CPU_ERROR_DATA_HIGH                                 0x130
> +#define MV64340_CPU_ERROR_PARITY                                    0x138
> +#define MV64340_CPU_ERROR_CAUSE                                     0x140
> +#define MV64340_CPU_ERROR_MASK                                      0x148
> +
> +/****************************************/
> +/*      CPU Interface Debug Registers   */
> +/****************************************/
> +
> +#define MV64340_PUNIT_SLAVE_DEBUG_LOW                               0x360
> +#define MV64340_PUNIT_SLAVE_DEBUG_HIGH                              0x368
> +#define MV64340_PUNIT_MASTER_DEBUG_LOW                              0x370
> +#define MV64340_PUNIT_MASTER_DEBUG_HIGH                             0x378
> +#define MV64340_PUNIT_MMASK                                         0x3e4
> +
> +/****************************************/
> +/*  Integrated SRAM Registers           */
> +/****************************************/
> +
> +#define MV64340_SRAM_CONFIG                                         0x380
> +#define MV64340_SRAM_TEST_MODE                                      0X3F4
> +#define MV64340_SRAM_ERROR_CAUSE                                    0x388
> +#define MV64340_SRAM_ERROR_ADDR                                     0x390
> +#define MV64340_SRAM_ERROR_ADDR_HIGH                                0X3F8
> +#define MV64340_SRAM_ERROR_DATA_LOW                                 0x398
> +#define MV64340_SRAM_ERROR_DATA_HIGH                                0x3a0
> +#define MV64340_SRAM_ERROR_DATA_PARITY                              0x3a8
> +
> +/****************************************/
> +/* SDRAM Configuration                  */
> +/****************************************/
> +
> +#define MV64340_SDRAM_CONFIG                                        0x1400
> +#define MV64340_D_UNIT_CONTROL_LOW                                  0x1404
> +#define MV64340_D_UNIT_CONTROL_HIGH                                 0x1424
> +#define MV64340_SDRAM_TIMING_CONTROL_LOW                            0x1408
> +#define MV64340_SDRAM_TIMING_CONTROL_HIGH                           0x140c
> +#define MV64340_SDRAM_ADDR_CONTROL                                  0x1410
> +#define MV64340_SDRAM_OPEN_PAGES_CONTROL                            0x1414
> +#define MV64340_SDRAM_OPERATION                                     0x1418
> +#define MV64340_SDRAM_MODE                                          0x141c
> +#define MV64340_EXTENDED_DRAM_MODE                                  0x1420
> +#define MV64340_SDRAM_CROSS_BAR_CONTROL_LOW                         0x1430
> +#define MV64340_SDRAM_CROSS_BAR_CONTROL_HIGH                        0x1434
> +#define MV64340_SDRAM_CROSS_BAR_TIMEOUT                             0x1438
> +#define MV64340_SDRAM_ADDR_CTRL_PADS_CALIBRATION                    0x14c0
> +#define MV64340_SDRAM_DATA_PADS_CALIBRATION                         0x14c4
> +
> +/****************************************/
> +/* SDRAM Error Report                   */
> +/****************************************/
> +
> +#define MV64340_SDRAM_ERROR_DATA_LOW                                0x1444
> +#define MV64340_SDRAM_ERROR_DATA_HIGH                               0x1440
> +#define MV64340_SDRAM_ERROR_ADDR                                    0x1450
> +#define MV64340_SDRAM_RECEIVED_ECC                                  0x1448
> +#define MV64340_SDRAM_CALCULATED_ECC                                0x144c
> +#define MV64340_SDRAM_ECC_CONTROL                                   0x1454
> +#define MV64340_SDRAM_ECC_ERROR_COUNTER                             0x1458
> +
> +/******************************************/
> +/*  Controlled Delay Line (CDL) Registers */
> +/******************************************/
> +
> +#define MV64340_DFCDL_CONFIG0                                       0x1480
> +#define MV64340_DFCDL_CONFIG1                                       0x1484
> +#define MV64340_DLL_WRITE                                           0x1488
> +#define MV64340_DLL_READ                                            0x148c
> +#define MV64340_SRAM_ADDR                                           0x1490
> +#define MV64340_SRAM_DATA0                                          0x1494
> +#define MV64340_SRAM_DATA1                                          0x1498
> +#define MV64340_SRAM_DATA2                                          0x149c
> +#define MV64340_DFCL_PROBE                                          0x14a0
> +
> +/******************************************/
> +/*   Debug Registers                      */
> +/******************************************/
> +
> +#define MV64340_DUNIT_DEBUG_LOW                                     0x1460
> +#define MV64340_DUNIT_DEBUG_HIGH                                    0x1464
> +#define MV64340_DUNIT_MMASK                                         0X1b40
> +
> +/****************************************/
> +/* Device Parameters                    */
> +/****************************************/
> +
> +#define MV64340_DEVICE_BANK0_PARAMETERS                             0x45c
> +#define MV64340_DEVICE_BANK1_PARAMETERS                             0x460
> +#define MV64340_DEVICE_BANK2_PARAMETERS                             0x464
> +#define MV64340_DEVICE_BANK3_PARAMETERS                             0x468
> +#define MV64340_DEVICE_BOOT_BANK_PARAMETERS                         0x46c
> +#define MV64340_DEVICE_INTERFACE_CONTROL                            0x4c0
> +#define MV64340_DEVICE_INTERFACE_CROSS_BAR_CONTROL_LOW              0x4c8
> +#define MV64340_DEVICE_INTERFACE_CROSS_BAR_CONTROL_HIGH             0x4cc
> +#define MV64340_DEVICE_INTERFACE_CROSS_BAR_TIMEOUT                  0x4c4
> +
> +/****************************************/
> +/* Device interrupt registers           */
> +/****************************************/
> +
> +#define MV64340_DEVICE_INTERRUPT_CAUSE                              0x4d0
> +#define MV64340_DEVICE_INTERRUPT_MASK                               0x4d4
> +#define MV64340_DEVICE_ERROR_ADDR                                   0x4d8
> +#define MV64340_DEVICE_ERROR_DATA                                   0x4dc
> +#define MV64340_DEVICE_ERROR_PARITY                                 0x4e0
> +
> +/****************************************/
> +/* Device debug registers               */
> +/****************************************/
> +
> +#define MV64340_DEVICE_DEBUG_LOW                                    0x4e4
> +#define MV64340_DEVICE_DEBUG_HIGH                                   0x4e8
> +#define MV64340_RUNIT_MMASK                                         0x4f0
> +
> +/****************************************/
> +/* PCI Slave Address Decoding registers */
> +/****************************************/
> +
> +#define MV64340_PCI_0_CS_0_BANK_SIZE                                0xc08
> +#define MV64340_PCI_1_CS_0_BANK_SIZE                                0xc88
> +#define MV64340_PCI_0_CS_1_BANK_SIZE                                0xd08
> +#define MV64340_PCI_1_CS_1_BANK_SIZE                                0xd88
> +#define MV64340_PCI_0_CS_2_BANK_SIZE                                0xc0c
> +#define MV64340_PCI_1_CS_2_BANK_SIZE                                0xc8c
> +#define MV64340_PCI_0_CS_3_BANK_SIZE                                0xd0c
> +#define MV64340_PCI_1_CS_3_BANK_SIZE                                0xd8c
> +#define MV64340_PCI_0_DEVCS_0_BANK_SIZE                             0xc10
> +#define MV64340_PCI_1_DEVCS_0_BANK_SIZE                             0xc90
> +#define MV64340_PCI_0_DEVCS_1_BANK_SIZE                             0xd10
> +#define MV64340_PCI_1_DEVCS_1_BANK_SIZE                             0xd90
> +#define MV64340_PCI_0_DEVCS_2_BANK_SIZE                             0xd18
> +#define MV64340_PCI_1_DEVCS_2_BANK_SIZE                             0xd98
> +#define MV64340_PCI_0_DEVCS_3_BANK_SIZE                             0xc14
> +#define MV64340_PCI_1_DEVCS_3_BANK_SIZE                             0xc94
> +#define MV64340_PCI_0_DEVCS_BOOT_BANK_SIZE                          0xd14
> +#define MV64340_PCI_1_DEVCS_BOOT_BANK_SIZE                          0xd94
> +#define MV64340_PCI_0_P2P_MEM0_BAR_SIZE                             0xd1c
> +#define MV64340_PCI_1_P2P_MEM0_BAR_SIZE                             0xd9c
> +#define MV64340_PCI_0_P2P_MEM1_BAR_SIZE                             0xd20
> +#define MV64340_PCI_1_P2P_MEM1_BAR_SIZE                             0xda0
> +#define MV64340_PCI_0_P2P_I_O_BAR_SIZE                              0xd24
> +#define MV64340_PCI_1_P2P_I_O_BAR_SIZE                              0xda4
> +#define MV64340_PCI_0_CPU_BAR_SIZE                                  0xd28
> +#define MV64340_PCI_1_CPU_BAR_SIZE                                  0xda8
> +#define MV64340_PCI_0_INTERNAL_SRAM_BAR_SIZE                        0xe00
> +#define MV64340_PCI_1_INTERNAL_SRAM_BAR_SIZE                        0xe80
> +#define MV64340_PCI_0_EXPANSION_ROM_BAR_SIZE                        0xd2c
> +#define MV64340_PCI_1_EXPANSION_ROM_BAR_SIZE                        0xd9c
> +#define MV64340_PCI_0_BASE_ADDR_REG_ENABLE                          0xc3c
> +#define MV64340_PCI_1_BASE_ADDR_REG_ENABLE                          0xcbc
> +#define MV64340_PCI_0_CS_0_BASE_ADDR_REMAP                          0xc48
> +#define MV64340_PCI_1_CS_0_BASE_ADDR_REMAP                          0xcc8
> +#define MV64340_PCI_0_CS_1_BASE_ADDR_REMAP                          0xd48
> +#define MV64340_PCI_1_CS_1_BASE_ADDR_REMAP                          0xdc8
> +#define MV64340_PCI_0_CS_2_BASE_ADDR_REMAP                          0xc4c
> +#define MV64340_PCI_1_CS_2_BASE_ADDR_REMAP                          0xccc
> +#define MV64340_PCI_0_CS_3_BASE_ADDR_REMAP                          0xd4c
> +#define MV64340_PCI_1_CS_3_BASE_ADDR_REMAP                          0xdcc
> +#define MV64340_PCI_0_CS_0_BASE_HIGH_ADDR_REMAP                     0xF04
> +#define MV64340_PCI_1_CS_0_BASE_HIGH_ADDR_REMAP                     0xF84
> +#define MV64340_PCI_0_CS_1_BASE_HIGH_ADDR_REMAP                     0xF08
> +#define MV64340_PCI_1_CS_1_BASE_HIGH_ADDR_REMAP                     0xF88
> +#define MV64340_PCI_0_CS_2_BASE_HIGH_ADDR_REMAP                     0xF0C
> +#define MV64340_PCI_1_CS_2_BASE_HIGH_ADDR_REMAP                     0xF8C
> +#define MV64340_PCI_0_CS_3_BASE_HIGH_ADDR_REMAP                     0xF10
> +#define MV64340_PCI_1_CS_3_BASE_HIGH_ADDR_REMAP                     0xF90
> +#define MV64340_PCI_0_DEVCS_0_BASE_ADDR_REMAP                       0xc50
> +#define MV64340_PCI_1_DEVCS_0_BASE_ADDR_REMAP                       0xcd0
> +#define MV64340_PCI_0_DEVCS_1_BASE_ADDR_REMAP                       0xd50
> +#define MV64340_PCI_1_DEVCS_1_BASE_ADDR_REMAP                       0xdd0
> +#define MV64340_PCI_0_DEVCS_2_BASE_ADDR_REMAP                       0xd58
> +#define MV64340_PCI_1_DEVCS_2_BASE_ADDR_REMAP                       0xdd8
> +#define MV64340_PCI_0_DEVCS_3_BASE_ADDR_REMAP                       0xc54
> +#define MV64340_PCI_1_DEVCS_3_BASE_ADDR_REMAP                       0xcd4
> +#define MV64340_PCI_0_DEVCS_BOOTCS_BASE_ADDR_REMAP                  0xd54
> +#define MV64340_PCI_1_DEVCS_BOOTCS_BASE_ADDR_REMAP                  0xdd4
> +#define MV64340_PCI_0_P2P_MEM0_BASE_ADDR_REMAP_LOW                  0xd5c
> +#define MV64340_PCI_1_P2P_MEM0_BASE_ADDR_REMAP_LOW                  0xddc
> +#define MV64340_PCI_0_P2P_MEM0_BASE_ADDR_REMAP_HIGH                 0xd60
> +#define MV64340_PCI_1_P2P_MEM0_BASE_ADDR_REMAP_HIGH                 0xde0
> +#define MV64340_PCI_0_P2P_MEM1_BASE_ADDR_REMAP_LOW                  0xd64
> +#define MV64340_PCI_1_P2P_MEM1_BASE_ADDR_REMAP_LOW                  0xde4
> +#define MV64340_PCI_0_P2P_MEM1_BASE_ADDR_REMAP_HIGH                 0xd68
> +#define MV64340_PCI_1_P2P_MEM1_BASE_ADDR_REMAP_HIGH                 0xde8
> +#define MV64340_PCI_0_P2P_I_O_BASE_ADDR_REMAP                       0xd6c
> +#define MV64340_PCI_1_P2P_I_O_BASE_ADDR_REMAP                       0xdec
> +#define MV64340_PCI_0_CPU_BASE_ADDR_REMAP_LOW                       0xd70
> +#define MV64340_PCI_1_CPU_BASE_ADDR_REMAP_LOW                       0xdf0
> +#define MV64340_PCI_0_CPU_BASE_ADDR_REMAP_HIGH                      0xd74
> +#define MV64340_PCI_1_CPU_BASE_ADDR_REMAP_HIGH                      0xdf4
> +#define MV64340_PCI_0_INTEGRATED_SRAM_BASE_ADDR_REMAP               0xf00
> +#define MV64340_PCI_1_INTEGRATED_SRAM_BASE_ADDR_REMAP               0xf80
> +#define MV64340_PCI_0_EXPANSION_ROM_BASE_ADDR_REMAP                 0xf38
> +#define MV64340_PCI_1_EXPANSION_ROM_BASE_ADDR_REMAP                 0xfb8
> +#define MV64340_PCI_0_ADDR_DECODE_CONTROL                           0xd3c
> +#define MV64340_PCI_1_ADDR_DECODE_CONTROL                           0xdbc
> +#define MV64340_PCI_0_HEADERS_RETARGET_CONTROL                      0xF40
> +#define MV64340_PCI_1_HEADERS_RETARGET_CONTROL                      0xFc0
> +#define MV64340_PCI_0_HEADERS_RETARGET_BASE                         0xF44
> +#define MV64340_PCI_1_HEADERS_RETARGET_BASE                         0xFc4
> +#define MV64340_PCI_0_HEADERS_RETARGET_HIGH                         0xF48
> +#define MV64340_PCI_1_HEADERS_RETARGET_HIGH                         0xFc8
> +
> +/***********************************/
> +/*   PCI Control Register Map      */
> +/***********************************/
> +
> +#define MV64340_PCI_0_DLL_STATUS_AND_COMMAND                        0x1d20
> +#define MV64340_PCI_1_DLL_STATUS_AND_COMMAND                        0x1da0
> +#define MV64340_PCI_0_MPP_PADS_DRIVE_CONTROL                        0x1d1C
> +#define MV64340_PCI_1_MPP_PADS_DRIVE_CONTROL                        0x1d9C
> +#define MV64340_PCI_0_COMMAND                                       0xc00
> +#define MV64340_PCI_1_COMMAND                                       0xc80
> +#define MV64340_PCI_0_MODE                                          0xd00
> +#define MV64340_PCI_1_MODE                                          0xd80
> +#define MV64340_PCI_0_RETRY                                         0xc04
> +#define MV64340_PCI_1_RETRY                                         0xc84
> +#define MV64340_PCI_0_READ_BUFFER_DISCARD_TIMER                     0xd04
> +#define MV64340_PCI_1_READ_BUFFER_DISCARD_TIMER                     0xd84
> +#define MV64340_PCI_0_MSI_TRIGGER_TIMER                             0xc38
> +#define MV64340_PCI_1_MSI_TRIGGER_TIMER                             0xcb8
> +#define MV64340_PCI_0_ARBITER_CONTROL                               0x1d00
> +#define MV64340_PCI_1_ARBITER_CONTROL                               0x1d80
> +#define MV64340_PCI_0_CROSS_BAR_CONTROL_LOW                         0x1d08
> +#define MV64340_PCI_1_CROSS_BAR_CONTROL_LOW                         0x1d88
> +#define MV64340_PCI_0_CROSS_BAR_CONTROL_HIGH                        0x1d0c
> +#define MV64340_PCI_1_CROSS_BAR_CONTROL_HIGH                        0x1d8c
> +#define MV64340_PCI_0_CROSS_BAR_TIMEOUT                             0x1d04
> +#define MV64340_PCI_1_CROSS_BAR_TIMEOUT                             0x1d84
> +#define MV64340_PCI_0_SYNC_BARRIER_TRIGGER_REG                      0x1D18
> +#define MV64340_PCI_1_SYNC_BARRIER_TRIGGER_REG                      0x1D98
> +#define MV64340_PCI_0_SYNC_BARRIER_VIRTUAL_REG                      0x1d10
> +#define MV64340_PCI_1_SYNC_BARRIER_VIRTUAL_REG                      0x1d90
> +#define MV64340_PCI_0_P2P_CONFIG                                    0x1d14
> +#define MV64340_PCI_1_P2P_CONFIG                                    0x1d94
> +
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_0_LOW                     0x1e00
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_0_HIGH                    0x1e04
> +#define MV64340_PCI_0_ACCESS_CONTROL_SIZE_0                         0x1e08
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_1_LOW                     0x1e10
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_1_HIGH                    0x1e14
> +#define MV64340_PCI_0_ACCESS_CONTROL_SIZE_1                         0x1e18
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_2_LOW                     0x1e20
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_2_HIGH                    0x1e24
> +#define MV64340_PCI_0_ACCESS_CONTROL_SIZE_2                         0x1e28
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_3_LOW                     0x1e30
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_3_HIGH                    0x1e34
> +#define MV64340_PCI_0_ACCESS_CONTROL_SIZE_3                         0x1e38
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_4_LOW                     0x1e40
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_4_HIGH                    0x1e44
> +#define MV64340_PCI_0_ACCESS_CONTROL_SIZE_4                         0x1e48
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_5_LOW                     0x1e50
> +#define MV64340_PCI_0_ACCESS_CONTROL_BASE_5_HIGH                    0x1e54
> +#define MV64340_PCI_0_ACCESS_CONTROL_SIZE_5                         0x1e58
> +
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_0_LOW                     0x1e80
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_0_HIGH                    0x1e84
> +#define MV64340_PCI_1_ACCESS_CONTROL_SIZE_0                         0x1e88
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_1_LOW                     0x1e90
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_1_HIGH                    0x1e94
> +#define MV64340_PCI_1_ACCESS_CONTROL_SIZE_1                         0x1e98
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_2_LOW                     0x1ea0
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_2_HIGH                    0x1ea4
> +#define MV64340_PCI_1_ACCESS_CONTROL_SIZE_2                         0x1ea8
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_3_LOW                     0x1eb0
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_3_HIGH                    0x1eb4
> +#define MV64340_PCI_1_ACCESS_CONTROL_SIZE_3                         0x1eb8
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_4_LOW                     0x1ec0
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_4_HIGH                    0x1ec4
> +#define MV64340_PCI_1_ACCESS_CONTROL_SIZE_4                         0x1ec8
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_5_LOW                     0x1ed0
> +#define MV64340_PCI_1_ACCESS_CONTROL_BASE_5_HIGH                    0x1ed4
> +#define MV64340_PCI_1_ACCESS_CONTROL_SIZE_5                         0x1ed8
> +
> +/****************************************/
> +/*   PCI Configuration Access Registers */
> +/****************************************/
> +
> +#define MV64340_PCI_0_CONFIG_ADDR                                   0xcf8
> +#define MV64340_PCI_0_CONFIG_DATA_VIRTUAL_REG                       0xcfc
> +#define MV64340_PCI_1_CONFIG_ADDR                                   0xc78
> +#define MV64340_PCI_1_CONFIG_DATA_VIRTUAL_REG                       0xc7c
> +#define MV64340_PCI_0_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG             0xc34
> +#define MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG             0xcb4
> +
> +/****************************************/
> +/*   PCI Error Report Registers         */
> +/****************************************/
> +
> +#define MV64340_PCI_0_SERR_MASK                                     0xc28
> +#define MV64340_PCI_1_SERR_MASK                                     0xca8
> +#define MV64340_PCI_0_ERROR_ADDR_LOW                                0x1d40
> +#define MV64340_PCI_1_ERROR_ADDR_LOW                                0x1dc0
> +#define MV64340_PCI_0_ERROR_ADDR_HIGH                               0x1d44
> +#define MV64340_PCI_1_ERROR_ADDR_HIGH                               0x1dc4
> +#define MV64340_PCI_0_ERROR_ATTRIBUTE                               0x1d48
> +#define MV64340_PCI_1_ERROR_ATTRIBUTE                               0x1dc8
> +#define MV64340_PCI_0_ERROR_COMMAND                                 0x1d50
> +#define MV64340_PCI_1_ERROR_COMMAND                                 0x1dd0
> +#define MV64340_PCI_0_ERROR_CAUSE                                   0x1d58
> +#define MV64340_PCI_1_ERROR_CAUSE                                   0x1dd8
> +#define MV64340_PCI_0_ERROR_MASK                                    0x1d5c
> +#define MV64340_PCI_1_ERROR_MASK                                    0x1ddc
> +
> +/****************************************/
> +/*   PCI Debug Registers                */
> +/****************************************/
> +
> +#define MV64340_PCI_0_MMASK                                         0X1D24
> +#define MV64340_PCI_1_MMASK                                         0X1DA4
> +
> +/*********************************************/
> +/* PCI Configuration, Function 0, Registers  */
> +/*********************************************/
> +
> +#define MV64340_PCI_DEVICE_AND_VENDOR_ID                            0x000
> +#define MV64340_PCI_STATUS_AND_COMMAND                              0x004
> +#define MV64340_PCI_CLASS_CODE_AND_REVISION_ID                      0x008
> +#define MV64340_PCI_BIST_HEADER_TYPE_LATENCY_TIMER_CACHE_LINE       0x00C
> +
> +#define MV64340_PCI_SCS_0_BASE_ADDR_LOW                             0x010
> +#define MV64340_PCI_SCS_0_BASE_ADDR_HIGH                            0x014
> +#define MV64340_PCI_SCS_1_BASE_ADDR_LOW                             0x018
> +#define MV64340_PCI_SCS_1_BASE_ADDR_HIGH                            0x01C
> +#define MV64340_PCI_INTERNAL_REG_MEM_MAPPED_BASE_ADDR_LOW           0x020
> +#define MV64340_PCI_INTERNAL_REG_MEM_MAPPED_BASE_ADDR_HIGH          0x024
> +#define MV64340_PCI_SUBSYSTEM_ID_AND_SUBSYSTEM_VENDOR_ID            0x02c
> +#define MV64340_PCI_EXPANSION_ROM_BASE_ADDR_REG                     0x030
> +#define MV64340_PCI_CAPABILTY_LIST_POINTER                          0x034
> +#define MV64340_PCI_INTERRUPT_PIN_AND_LINE                          0x03C
> +       /* capability list */
> +#define MV64340_PCI_POWER_MANAGEMENT_CAPABILITY                     0x040
> +#define MV64340_PCI_POWER_MANAGEMENT_STATUS_AND_CONTROL             0x044
> +#define MV64340_PCI_VPD_ADDR                                        0x048
> +#define MV64340_PCI_VPD_DATA                                        0x04c
> +#define MV64340_PCI_MSI_MESSAGE_CONTROL                             0x050
> +#define MV64340_PCI_MSI_MESSAGE_ADDR                                0x054
> +#define MV64340_PCI_MSI_MESSAGE_UPPER_ADDR                          0x058
> +#define MV64340_PCI_MSI_MESSAGE_DATA                                0x05c
> +#define MV64340_PCI_X_COMMAND                                       0x060
> +#define MV64340_PCI_X_STATUS                                        0x064
> +#define MV64340_PCI_COMPACT_PCI_HOT_SWAP                            0x068
> +
> +/***********************************************/
> +/*   PCI Configuration, Function 1, Registers  */
> +/***********************************************/
> +
> +#define MV64340_PCI_SCS_2_BASE_ADDR_LOW                             0x110
> +#define MV64340_PCI_SCS_2_BASE_ADDR_HIGH                            0x114
> +#define MV64340_PCI_SCS_3_BASE_ADDR_LOW                             0x118
> +#define MV64340_PCI_SCS_3_BASE_ADDR_HIGH                            0x11c
> +#define MV64340_PCI_INTERNAL_SRAM_BASE_ADDR_LOW                     0x120
> +#define MV64340_PCI_INTERNAL_SRAM_BASE_ADDR_HIGH                    0x124
> +
> +/***********************************************/
> +/*  PCI Configuration, Function 2, Registers   */
> +/***********************************************/
> +
> +#define MV64340_PCI_DEVCS_0_BASE_ADDR_LOW                           0x210
> +#define MV64340_PCI_DEVCS_0_BASE_ADDR_HIGH                          0x214
> +#define MV64340_PCI_DEVCS_1_BASE_ADDR_LOW                           0x218
> +#define MV64340_PCI_DEVCS_1_BASE_ADDR_HIGH                          0x21c
> +#define MV64340_PCI_DEVCS_2_BASE_ADDR_LOW                           0x220
> +#define MV64340_PCI_DEVCS_2_BASE_ADDR_HIGH                          0x224
> +
> +/***********************************************/
> +/*  PCI Configuration, Function 3, Registers   */
> +/***********************************************/
> +
> +#define MV64340_PCI_DEVCS_3_BASE_ADDR_LOW                           0x310
> +#define MV64340_PCI_DEVCS_3_BASE_ADDR_HIGH                          0x314
> +#define MV64340_PCI_BOOT_CS_BASE_ADDR_LOW                           0x318
> +#define MV64340_PCI_BOOT_CS_BASE_ADDR_HIGH                          0x31c
> +#define MV64340_PCI_CPU_BASE_ADDR_LOW                               0x220
> +#define MV64340_PCI_CPU_BASE_ADDR_HIGH                              0x224
> +
> +/***********************************************/
> +/*  PCI Configuration, Function 4, Registers   */
> +/***********************************************/
> +
> +#define MV64340_PCI_P2P_MEM0_BASE_ADDR_LOW                          0x410
> +#define MV64340_PCI_P2P_MEM0_BASE_ADDR_HIGH                         0x414
> +#define MV64340_PCI_P2P_MEM1_BASE_ADDR_LOW                          0x418
> +#define MV64340_PCI_P2P_MEM1_BASE_ADDR_HIGH                         0x41c
> +#define MV64340_PCI_P2P_I_O_BASE_ADDR                               0x420
> +#define MV64340_PCI_INTERNAL_REGS_I_O_MAPPED_BASE_ADDR              0x424
> +
> +/****************************************/
> +/* Messaging Unit Registers (I20)       */
> +/****************************************/
> +
> +#define MV64340_I2O_INBOUND_MESSAGE_REG0_PCI_0_SIDE                 0x010
> +#define MV64340_I2O_INBOUND_MESSAGE_REG1_PCI_0_SIDE                 0x014
> +#define MV64340_I2O_OUTBOUND_MESSAGE_REG0_PCI_0_SIDE                0x018
> +#define MV64340_I2O_OUTBOUND_MESSAGE_REG1_PCI_0_SIDE                0x01C
> +#define MV64340_I2O_INBOUND_DOORBELL_REG_PCI_0_SIDE                 0x020
> +#define MV64340_I2O_INBOUND_INTERRUPT_CAUSE_REG_PCI_0_SIDE          0x024
> +#define MV64340_I2O_INBOUND_INTERRUPT_MASK_REG_PCI_0_SIDE           0x028
> +#define MV64340_I2O_OUTBOUND_DOORBELL_REG_PCI_0_SIDE                0x02C
> +#define MV64340_I2O_OUTBOUND_INTERRUPT_CAUSE_REG_PCI_0_SIDE         0x030
> +#define MV64340_I2O_OUTBOUND_INTERRUPT_MASK_REG_PCI_0_SIDE          0x034
> +#define MV64340_I2O_INBOUND_QUEUE_PORT_VIRTUAL_REG_PCI_0_SIDE       0x040
> +#define MV64340_I2O_OUTBOUND_QUEUE_PORT_VIRTUAL_REG_PCI_0_SIDE      0x044
> +#define MV64340_I2O_QUEUE_CONTROL_REG_PCI_0_SIDE                    0x050
> +#define MV64340_I2O_QUEUE_BASE_ADDR_REG_PCI_0_SIDE                  0x054
> +#define MV64340_I2O_INBOUND_FREE_HEAD_POINTER_REG_PCI_0_SIDE        0x060
> +#define MV64340_I2O_INBOUND_FREE_TAIL_POINTER_REG_PCI_0_SIDE        0x064
> +#define MV64340_I2O_INBOUND_POST_HEAD_POINTER_REG_PCI_0_SIDE        0x068
> +#define MV64340_I2O_INBOUND_POST_TAIL_POINTER_REG_PCI_0_SIDE        0x06C
> +#define MV64340_I2O_OUTBOUND_FREE_HEAD_POINTER_REG_PCI_0_SIDE       0x070
> +#define MV64340_I2O_OUTBOUND_FREE_TAIL_POINTER_REG_PCI_0_SIDE       0x074
> +#define MV64340_I2O_OUTBOUND_POST_HEAD_POINTER_REG_PCI_0_SIDE       0x0F8
> +#define MV64340_I2O_OUTBOUND_POST_TAIL_POINTER_REG_PCI_0_SIDE       0x0FC
> +
> +#define MV64340_I2O_INBOUND_MESSAGE_REG0_PCI_1_SIDE                 0x090
> +#define MV64340_I2O_INBOUND_MESSAGE_REG1_PCI_1_SIDE                 0x094
> +#define MV64340_I2O_OUTBOUND_MESSAGE_REG0_PCI_1_SIDE                0x098
> +#define MV64340_I2O_OUTBOUND_MESSAGE_REG1_PCI_1_SIDE                0x09C
> +#define MV64340_I2O_INBOUND_DOORBELL_REG_PCI_1_SIDE                 0x0A0
> +#define MV64340_I2O_INBOUND_INTERRUPT_CAUSE_REG_PCI_1_SIDE          0x0A4
> +#define MV64340_I2O_INBOUND_INTERRUPT_MASK_REG_PCI_1_SIDE           0x0A8
> +#define MV64340_I2O_OUTBOUND_DOORBELL_REG_PCI_1_SIDE                0x0AC
> +#define MV64340_I2O_OUTBOUND_INTERRUPT_CAUSE_REG_PCI_1_SIDE         0x0B0
> +#define MV64340_I2O_OUTBOUND_INTERRUPT_MASK_REG_PCI_1_SIDE          0x0B4
> +#define MV64340_I2O_INBOUND_QUEUE_PORT_VIRTUAL_REG_PCI_1_SIDE       0x0C0
> +#define MV64340_I2O_OUTBOUND_QUEUE_PORT_VIRTUAL_REG_PCI_1_SIDE      0x0C4
> +#define MV64340_I2O_QUEUE_CONTROL_REG_PCI_1_SIDE                    0x0D0
> +#define MV64340_I2O_QUEUE_BASE_ADDR_REG_PCI_1_SIDE                  0x0D4
> +#define MV64340_I2O_INBOUND_FREE_HEAD_POINTER_REG_PCI_1_SIDE        0x0E0
> +#define MV64340_I2O_INBOUND_FREE_TAIL_POINTER_REG_PCI_1_SIDE        0x0E4
> +#define MV64340_I2O_INBOUND_POST_HEAD_POINTER_REG_PCI_1_SIDE        0x0E8
> +#define MV64340_I2O_INBOUND_POST_TAIL_POINTER_REG_PCI_1_SIDE        0x0EC
> +#define MV64340_I2O_OUTBOUND_FREE_HEAD_POINTER_REG_PCI_1_SIDE       0x0F0
> +#define MV64340_I2O_OUTBOUND_FREE_TAIL_POINTER_REG_PCI_1_SIDE       0x0F4
> +#define MV64340_I2O_OUTBOUND_POST_HEAD_POINTER_REG_PCI_1_SIDE       0x078
> +#define MV64340_I2O_OUTBOUND_POST_TAIL_POINTER_REG_PCI_1_SIDE       0x07C
> +
> +#define MV64340_I2O_INBOUND_MESSAGE_REG0_CPU0_SIDE                  0x1C10
> +#define MV64340_I2O_INBOUND_MESSAGE_REG1_CPU0_SIDE                  0x1C14
> +#define MV64340_I2O_OUTBOUND_MESSAGE_REG0_CPU0_SIDE                 0x1C18
> +#define MV64340_I2O_OUTBOUND_MESSAGE_REG1_CPU0_SIDE                 0x1C1C
> +#define MV64340_I2O_INBOUND_DOORBELL_REG_CPU0_SIDE                  0x1C20
> +#define MV64340_I2O_INBOUND_INTERRUPT_CAUSE_REG_CPU0_SIDE           0x1C24
> +#define MV64340_I2O_INBOUND_INTERRUPT_MASK_REG_CPU0_SIDE            0x1C28
> +#define MV64340_I2O_OUTBOUND_DOORBELL_REG_CPU0_SIDE                 0x1C2C
> +#define MV64340_I2O_OUTBOUND_INTERRUPT_CAUSE_REG_CPU0_SIDE          0x1C30
> +#define MV64340_I2O_OUTBOUND_INTERRUPT_MASK_REG_CPU0_SIDE           0x1C34
> +#define MV64340_I2O_INBOUND_QUEUE_PORT_VIRTUAL_REG_CPU0_SIDE        0x1C40
> +#define MV64340_I2O_OUTBOUND_QUEUE_PORT_VIRTUAL_REG_CPU0_SIDE       0x1C44
> +#define MV64340_I2O_QUEUE_CONTROL_REG_CPU0_SIDE                     0x1C50
> +#define MV64340_I2O_QUEUE_BASE_ADDR_REG_CPU0_SIDE                   0x1C54
> +#define MV64340_I2O_INBOUND_FREE_HEAD_POINTER_REG_CPU0_SIDE         0x1C60
> +#define MV64340_I2O_INBOUND_FREE_TAIL_POINTER_REG_CPU0_SIDE         0x1C64
> +#define MV64340_I2O_INBOUND_POST_HEAD_POINTER_REG_CPU0_SIDE         0x1C68
> +#define MV64340_I2O_INBOUND_POST_TAIL_POINTER_REG_CPU0_SIDE         0x1C6C
> +#define MV64340_I2O_OUTBOUND_FREE_HEAD_POINTER_REG_CPU0_SIDE        0x1C70
> +#define MV64340_I2O_OUTBOUND_FREE_TAIL_POINTER_REG_CPU0_SIDE        0x1C74
> +#define MV64340_I2O_OUTBOUND_POST_HEAD_POINTER_REG_CPU0_SIDE        0x1CF8
> +#define MV64340_I2O_OUTBOUND_POST_TAIL_POINTER_REG_CPU0_SIDE        0x1CFC
> +#define MV64340_I2O_INBOUND_MESSAGE_REG0_CPU1_SIDE                  0x1C90
> +#define MV64340_I2O_INBOUND_MESSAGE_REG1_CPU1_SIDE                  0x1C94
> +#define MV64340_I2O_OUTBOUND_MESSAGE_REG0_CPU1_SIDE                 0x1C98
> +#define MV64340_I2O_OUTBOUND_MESSAGE_REG1_CPU1_SIDE                 0x1C9C
> +#define MV64340_I2O_INBOUND_DOORBELL_REG_CPU1_SIDE                  0x1CA0
> +#define MV64340_I2O_INBOUND_INTERRUPT_CAUSE_REG_CPU1_SIDE           0x1CA4
> +#define MV64340_I2O_INBOUND_INTERRUPT_MASK_REG_CPU1_SIDE            0x1CA8
> +#define MV64340_I2O_OUTBOUND_DOORBELL_REG_CPU1_SIDE                 0x1CAC
> +#define MV64340_I2O_OUTBOUND_INTERRUPT_CAUSE_REG_CPU1_SIDE          0x1CB0
> +#define MV64340_I2O_OUTBOUND_INTERRUPT_MASK_REG_CPU1_SIDE           0x1CB4
> +#define MV64340_I2O_INBOUND_QUEUE_PORT_VIRTUAL_REG_CPU1_SIDE        0x1CC0
> +#define MV64340_I2O_OUTBOUND_QUEUE_PORT_VIRTUAL_REG_CPU1_SIDE       0x1CC4
> +#define MV64340_I2O_QUEUE_CONTROL_REG_CPU1_SIDE                     0x1CD0
> +#define MV64340_I2O_QUEUE_BASE_ADDR_REG_CPU1_SIDE                   0x1CD4
> +#define MV64340_I2O_INBOUND_FREE_HEAD_POINTER_REG_CPU1_SIDE         0x1CE0
> +#define MV64340_I2O_INBOUND_FREE_TAIL_POINTER_REG_CPU1_SIDE         0x1CE4
> +#define MV64340_I2O_INBOUND_POST_HEAD_POINTER_REG_CPU1_SIDE         0x1CE8
> +#define MV64340_I2O_INBOUND_POST_TAIL_POINTER_REG_CPU1_SIDE         0x1CEC
> +#define MV64340_I2O_OUTBOUND_FREE_HEAD_POINTER_REG_CPU1_SIDE        0x1CF0
> +#define MV64340_I2O_OUTBOUND_FREE_TAIL_POINTER_REG_CPU1_SIDE        0x1CF4
> +#define MV64340_I2O_OUTBOUND_POST_HEAD_POINTER_REG_CPU1_SIDE        0x1C78
> +#define MV64340_I2O_OUTBOUND_POST_TAIL_POINTER_REG_CPU1_SIDE        0x1C7C
> +
> +/****************************************/
> +/*        Ethernet Unit Registers       */
> +/****************************************/
> +
> +/*******************************************/
> +/*          CUNIT  Registers               */
> +/*******************************************/
> +
> +         /* Address Decoding Register Map */
> +
> +#define MV64340_CUNIT_BASE_ADDR_REG0                                0xf200
> +#define MV64340_CUNIT_BASE_ADDR_REG1                                0xf208
> +#define MV64340_CUNIT_BASE_ADDR_REG2                                0xf210
> +#define MV64340_CUNIT_BASE_ADDR_REG3                                0xf218
> +#define MV64340_CUNIT_SIZE0                                         0xf204
> +#define MV64340_CUNIT_SIZE1                                         0xf20c
> +#define MV64340_CUNIT_SIZE2                                         0xf214
> +#define MV64340_CUNIT_SIZE3                                         0xf21c
> +#define MV64340_CUNIT_HIGH_ADDR_REMAP_REG0                          0xf240
> +#define MV64340_CUNIT_HIGH_ADDR_REMAP_REG1                          0xf244
> +#define MV64340_CUNIT_BASE_ADDR_ENABLE_REG                          0xf250
> +#define MV64340_MPSC0_ACCESS_PROTECTION_REG                         0xf254
> +#define MV64340_MPSC1_ACCESS_PROTECTION_REG                         0xf258
> +#define MV64340_CUNIT_INTERNAL_SPACE_BASE_ADDR_REG                  0xf25C
> +
> +        /*  Error Report Registers  */
> +
> +#define MV64340_CUNIT_INTERRUPT_CAUSE_REG                           0xf310
> +#define MV64340_CUNIT_INTERRUPT_MASK_REG                            0xf314
> +#define MV64340_CUNIT_ERROR_ADDR                                    0xf318
> +
> +        /*  Cunit Control Registers */
> +
> +#define MV64340_CUNIT_ARBITER_CONTROL_REG                           0xf300
> +#define MV64340_CUNIT_CONFIG_REG                                    0xb40c
> +#define MV64340_CUNIT_CRROSBAR_TIMEOUT_REG                          0xf304
> +
> +        /*  Cunit Debug Registers   */
> +
> +#define MV64340_CUNIT_DEBUG_LOW                                     0xf340
> +#define MV64340_CUNIT_DEBUG_HIGH                                    0xf344
> +#define MV64340_CUNIT_MMASK                                         0xf380
> +
> +        /*  MPSCs Clocks Routing Registers  */
> +
> +#define MV64340_MPSC_ROUTING_REG                                    0xb400
> +#define MV64340_MPSC_RX_CLOCK_ROUTING_REG                           0xb404
> +#define MV64340_MPSC_TX_CLOCK_ROUTING_REG                           0xb408
> +
> +        /*  MPSCs Interrupts Registers    */
> +
> +#define MV64340_MPSC_CAUSE_REG(port)                     (0xb804 + (port << 
> 3))
> +#define MV64340_MPSC_MASK_REG(port)                      (0xb884 + (port << 
> 3))
> +
> +#define MV64340_MPSC_MAIN_CONFIG_LOW(port)              (0x8000 + (port << 
> 12))
> +#define MV64340_MPSC_MAIN_CONFIG_HIGH(port)             (0x8004 + (port << 
> 12))
> +#define MV64340_MPSC_PROTOCOL_CONFIG(port)              (0x8008 + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG1(port)                 (0x800c + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG2(port)                 (0x8010 + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG3(port)                 (0x8014 + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG4(port)                 (0x8018 + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG5(port)                 (0x801c + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG6(port)                 (0x8020 + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG7(port)                 (0x8024 + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG8(port)                 (0x8028 + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG9(port)                 (0x802c + (port << 
> 12))
> +#define MV64340_MPSC_CHANNEL_REG10(port)                (0x8030 + (port << 
> 12))
> +
> +        /*  MPSC0 Registers      */
> +
> +
> +/***************************************/
> +/*          SDMA Registers             */
> +/***************************************/
> +
> +#define MV64340_SDMA_CONFIG_REG(channel)                    (0x4000 + 
> (channel << 13))
> +#define MV64340_SDMA_COMMAND_REG(channel)                   (0x4008 + 
> (channel << 13))
> +#define MV64340_SDMA_CURRENT_RX_DESCRIPTOR_POINTER(channel) (0x4810 + 
> (channel << 13))
> +#define MV64340_SDMA_CURRENT_TX_DESCRIPTOR_POINTER(channel) (0x4c10 + 
> (channel << 13))
> +#define MV64340_SDMA_FIRST_TX_DESCRIPTOR_POINTER(channel)   (0x4c14 + 
> (channel << 13))
> +
> +#define MV64340_SDMA_CAUSE_REG                                      0xb800
> +#define MV64340_SDMA_MASK_REG                                       0xb880
> +
> +/* BRG Interrupts */
> +
> +#define MV64340_BRG_CONFIG_REG(brg)                       (0xb200 + (brg << 
> 3))
> +#define MV64340_BRG_BAUDE_TUNING_REG(brg)                 (0xb208 + (brg << 
> 3))
> +#define MV64340_BRG_CAUSE_REG                                       0xb834
> +#define MV64340_BRG_MASK_REG                                        0xb8b4
> +
> +/****************************************/
> +/* DMA Channel Control                  */
> +/****************************************/
> +
> +#define MV64340_DMA_CHANNEL0_CONTROL                                0x840
> +#define MV64340_DMA_CHANNEL0_CONTROL_HIGH                           0x880
> +#define MV64340_DMA_CHANNEL1_CONTROL                                0x844
> +#define MV64340_DMA_CHANNEL1_CONTROL_HIGH                           0x884
> +#define MV64340_DMA_CHANNEL2_CONTROL                                0x848
> +#define MV64340_DMA_CHANNEL2_CONTROL_HIGH                           0x888
> +#define MV64340_DMA_CHANNEL3_CONTROL                                0x84C
> +#define MV64340_DMA_CHANNEL3_CONTROL_HIGH                           0x88C
> +
> +
> +/****************************************/
> +/*           IDMA Registers             */
> +/****************************************/
> +
> +#define MV64340_DMA_CHANNEL0_BYTE_COUNT                             0x800
> +#define MV64340_DMA_CHANNEL1_BYTE_COUNT                             0x804
> +#define MV64340_DMA_CHANNEL2_BYTE_COUNT                             0x808
> +#define MV64340_DMA_CHANNEL3_BYTE_COUNT                             0x80C
> +#define MV64340_DMA_CHANNEL0_SOURCE_ADDR                            0x810
> +#define MV64340_DMA_CHANNEL1_SOURCE_ADDR                            0x814
> +#define MV64340_DMA_CHANNEL2_SOURCE_ADDR                            0x818
> +#define MV64340_DMA_CHANNEL3_SOURCE_ADDR                            0x81c
> +#define MV64340_DMA_CHANNEL0_DESTINATION_ADDR                       0x820
> +#define MV64340_DMA_CHANNEL1_DESTINATION_ADDR                       0x824
> +#define MV64340_DMA_CHANNEL2_DESTINATION_ADDR                       0x828
> +#define MV64340_DMA_CHANNEL3_DESTINATION_ADDR                       0x82C
> +#define MV64340_DMA_CHANNEL0_NEXT_DESCRIPTOR_POINTER                0x830
> +#define MV64340_DMA_CHANNEL1_NEXT_DESCRIPTOR_POINTER                0x834
> +#define MV64340_DMA_CHANNEL2_NEXT_DESCRIPTOR_POINTER                0x838
> +#define MV64340_DMA_CHANNEL3_NEXT_DESCRIPTOR_POINTER                0x83C
> +#define MV64340_DMA_CHANNEL0_CURRENT_DESCRIPTOR_POINTER             0x870
> +#define MV64340_DMA_CHANNEL1_CURRENT_DESCRIPTOR_POINTER             0x874
> +#define MV64340_DMA_CHANNEL2_CURRENT_DESCRIPTOR_POINTER             0x878
> +#define MV64340_DMA_CHANNEL3_CURRENT_DESCRIPTOR_POINTER             0x87C
> +
> + /*  IDMA Address Decoding Base Address Registers  */
> +
> +#define MV64340_DMA_BASE_ADDR_REG0                                  0xa00
> +#define MV64340_DMA_BASE_ADDR_REG1                                  0xa08
> +#define MV64340_DMA_BASE_ADDR_REG2                                  0xa10
> +#define MV64340_DMA_BASE_ADDR_REG3                                  0xa18
> +#define MV64340_DMA_BASE_ADDR_REG4                                  0xa20
> +#define MV64340_DMA_BASE_ADDR_REG5                                  0xa28
> +#define MV64340_DMA_BASE_ADDR_REG6                                  0xa30
> +#define MV64340_DMA_BASE_ADDR_REG7                                  0xa38
> +
> + /*  IDMA Address Decoding Size Address Register   */
> +
> +#define MV64340_DMA_SIZE_REG0                                       0xa04
> +#define MV64340_DMA_SIZE_REG1                                       0xa0c
> +#define MV64340_DMA_SIZE_REG2                                       0xa14
> +#define MV64340_DMA_SIZE_REG3                                       0xa1c
> +#define MV64340_DMA_SIZE_REG4                                       0xa24
> +#define MV64340_DMA_SIZE_REG5                                       0xa2c
> +#define MV64340_DMA_SIZE_REG6                                       0xa34
> +#define MV64340_DMA_SIZE_REG7                                       0xa3C
> +
> + /* IDMA Address Decoding High Address Remap and Access Protection Registers 
> */
> +
> +#define MV64340_DMA_HIGH_ADDR_REMAP_REG0                            0xa60
> +#define MV64340_DMA_HIGH_ADDR_REMAP_REG1                            0xa64
> +#define MV64340_DMA_HIGH_ADDR_REMAP_REG2                            0xa68
> +#define MV64340_DMA_HIGH_ADDR_REMAP_REG3                            0xa6C
> +#define MV64340_DMA_BASE_ADDR_ENABLE_REG                            0xa80
> +#define MV64340_DMA_CHANNEL0_ACCESS_PROTECTION_REG                  0xa70
> +#define MV64340_DMA_CHANNEL1_ACCESS_PROTECTION_REG                  0xa74
> +#define MV64340_DMA_CHANNEL2_ACCESS_PROTECTION_REG                  0xa78
> +#define MV64340_DMA_CHANNEL3_ACCESS_PROTECTION_REG                  0xa7c
> +#define MV64340_DMA_ARBITER_CONTROL                                 0x860
> +#define MV64340_DMA_CROSS_BAR_TIMEOUT                               0x8d0
> +
> + /*  IDMA Headers Retarget Registers   */
> +
> +#define MV64340_DMA_HEADERS_RETARGET_CONTROL                        0xa84
> +#define MV64340_DMA_HEADERS_RETARGET_BASE                           0xa88
> +
> + /*  IDMA Interrupt Register  */
> +
> +#define MV64340_DMA_INTERRUPT_CAUSE_REG                             0x8c0
> +#define MV64340_DMA_INTERRUPT_CAUSE_MASK                            0x8c4
> +#define MV64340_DMA_ERROR_ADDR                                      0x8c8
> +#define MV64340_DMA_ERROR_SELECT                                    0x8cc
> +
> + /*  IDMA Debug Register ( for internal use )    */
> +
> +#define MV64340_DMA_DEBUG_LOW                                       0x8e0
> +#define MV64340_DMA_DEBUG_HIGH                                      0x8e4
> +#define MV64340_DMA_SPARE                                           0xA8C
> +
> +/****************************************/
> +/* Timer_Counter                        */
> +/****************************************/
> +
> +#define MV64340_TIMER_COUNTER0                                      0x850
> +#define MV64340_TIMER_COUNTER1                                      0x854
> +#define MV64340_TIMER_COUNTER2                                      0x858
> +#define MV64340_TIMER_COUNTER3                                      0x85C
> +#define MV64340_TIMER_COUNTER_0_3_CONTROL                           0x864
> +#define MV64340_TIMER_COUNTER_0_3_INTERRUPT_CAUSE                   0x868
> +#define MV64340_TIMER_COUNTER_0_3_INTERRUPT_MASK                    0x86c
> +
> +/****************************************/
> +/*         Watchdog registers           */
> +/****************************************/
> +
> +#define MV64340_WATCHDOG_CONFIG_REG                                 0xb410
> +#define MV64340_WATCHDOG_VALUE_REG                                  0xb414
> +
> +/****************************************/
> +/* I2C Registers                        */
> +/****************************************/
> +
> +#define MV64XXX_I2C_OFFSET                                          0xc000
> +#define MV64XXX_I2C_REG_BLOCK_SIZE                                  0x0020
> +
> +/****************************************/
> +/* GPP Interface Registers              */
> +/****************************************/
> +
> +#define MV64340_GPP_IO_CONTROL                                      0xf100
> +#define MV64340_GPP_LEVEL_CONTROL                                   0xf110
> +#define MV64340_GPP_VALUE                                           0xf104
> +#define MV64340_GPP_INTERRUPT_CAUSE                                 0xf108
> +#define MV64340_GPP_INTERRUPT_MASK0                                 0xf10c
> +#define MV64340_GPP_INTERRUPT_MASK1                                 0xf114
> +#define MV64340_GPP_VALUE_SET                                       0xf118
> +#define MV64340_GPP_VALUE_CLEAR                                     0xf11c
> +
> +/****************************************/
> +/* Interrupt Controller Registers       */
> +/****************************************/
> +
> +/****************************************/
> +/* Interrupts                           */
> +/****************************************/
> +
> +#define MV64340_MAIN_INTERRUPT_CAUSE_LOW                            0x004
> +#define MV64340_MAIN_INTERRUPT_CAUSE_HIGH                           0x00c
> +#define MV64340_CPU_INTERRUPT0_MASK_LOW                             0x014
> +#define MV64340_CPU_INTERRUPT0_MASK_HIGH                            0x01c
> +#define MV64340_CPU_INTERRUPT0_SELECT_CAUSE                         0x024
> +#define MV64340_CPU_INTERRUPT1_MASK_LOW                             0x034
> +#define MV64340_CPU_INTERRUPT1_MASK_HIGH                            0x03c
> +#define MV64340_CPU_INTERRUPT1_SELECT_CAUSE                         0x044
> +#define MV64340_INTERRUPT0_MASK_0_LOW                               0x054
> +#define MV64340_INTERRUPT0_MASK_0_HIGH                              0x05c
> +#define MV64340_INTERRUPT0_SELECT_CAUSE                             0x064
> +#define MV64340_INTERRUPT1_MASK_0_LOW                               0x074
> +#define MV64340_INTERRUPT1_MASK_0_HIGH                              0x07c
> +#define MV64340_INTERRUPT1_SELECT_CAUSE                             0x084
> +
> +/****************************************/
> +/*      MPP Interface Registers         */
> +/****************************************/
> +
> +#define MV64340_MPP_CONTROL0                                        0xf000
> +#define MV64340_MPP_CONTROL1                                        0xf004
> +#define MV64340_MPP_CONTROL2                                        0xf008
> +#define MV64340_MPP_CONTROL3                                        0xf00c
> +
> +/****************************************/
> +/*    Serial Initialization registers   */
> +/****************************************/
> +
> +#define MV64340_SERIAL_INIT_LAST_DATA                               0xf324
> +#define MV64340_SERIAL_INIT_CONTROL                                 0xf328
> +#define MV64340_SERIAL_INIT_STATUS                                  0xf32c
> +
> +#endif /* ASM_MV643XX_H */
> diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events
> index 7d8063ac42..dac86ad3f0 100644
> --- a/hw/pci-host/trace-events
> +++ b/hw/pci-host/trace-events
> @@ -3,6 +3,12 @@
>  # grackle.c
>  grackle_set_irq(int irq_num, int level) "set_irq num %d level %d"
>  
> +# mv64361.c
> +mv64361_region_map(const char *name, uint64_t poffs, uint64_t size, uint64_t 
> moffs) "Mapping %s 0x%"PRIx64"+0x%"PRIx64" @ 0x%"PRIx64
> +mv64361_region_enable(const char *op, int num) "Should %s region %d"
> +mv64361_reg_read(uint64_t addr, uint32_t val) "0x%"PRIx64" -> 0x%x"
> +mv64361_reg_write(uint64_t addr, uint64_t val) "0x%"PRIx64" <- 0x%"PRIx64
> +
>  # sabre.c
>  sabre_set_request(int irq_num) "request irq %d"
>  sabre_clear_request(int irq_num) "clear request irq %d"
> diff --git a/include/hw/pci-host/mv64361.h b/include/hw/pci-host/mv64361.h
> new file mode 100644
> index 0000000000..9cdb35cb3c
> --- /dev/null
> +++ b/include/hw/pci-host/mv64361.h
> @@ -0,0 +1,8 @@
> +#ifndef MV64361_H
> +#define MV64361_H
> +
> +#define TYPE_MV64361 "mv64361"
> +
> +PCIBus *mv64361_get_pci_bus(DeviceState *dev, int n);
> +
> +#endif
> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
> index ac0c23ebc7..5c14681b82 100644
> --- a/include/hw/pci/pci_ids.h
> +++ b/include/hw/pci/pci_ids.h
> @@ -214,6 +214,7 @@
>  #define PCI_DEVICE_ID_VIA_8231_PM        0x8235
>  
>  #define PCI_VENDOR_ID_MARVELL            0x11ab
> +#define PCI_DEVICE_ID_MARVELL_MV6436X    0x6460
>  
>  #define PCI_VENDOR_ID_SILICON_MOTION     0x126f
>  #define PCI_DEVICE_ID_SM501              0x0501

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]