Re: [PATCH v4 3/3] ppc: Enable 2nd DAWR support on p10

[Ravi Bangoria]

> > > +static void cap_dawr1_apply(SpaprMachineState *spapr, uint8_t val,
> > > +                               Error **errp)
> > > +{
> > > +    ERRP_GUARD();
> > > +    if (!val) {
> > > +        return; /* Disable by default */
> > > +    }
> > > +
> > > +    if (tcg_enabled()) {
> > > +        error_setg(errp, "DAWR1 not supported in TCG.");
> > > +        error_append_hint(errp, "Try appending -machine cap-dawr1=off\n");
> > > +    } else if (kvm_enabled()) {
> > > +        if (!kvmppc_has_cap_dawr1()) {
> > > +            error_setg(errp, "DAWR1 not supported by KVM.");
> > > +            error_append_hint(errp, "Try appending -machine cap-dawr1=off\n");
> > > +        } else if (kvmppc_set_cap_dawr1(val) < 0) {
> > > +            error_setg(errp, "DAWR1 not supported by KVM.");
> >
> > Well... technically KVM does support DAWR1 but something went wrong when
> > trying to enable it. In case you need to repost, maybe change the error
> > message in this path, e.g. like in cap_nested_kvm_hv_apply().
>
> This won't be going in until 6.1 anyway, so please to update the
> message.

Sure. Will post v5 with updated message.

> I'd probably prefer to actually wait until the 6.1 tree opens to apply
> this, rather than pre-queueing it in ppc-for-6.1, because there's a
> fairly good chance the header update patch will conflict with someone
> else's during the 6.1 merge flurry.

No worries.

Thanks Greg, David for the review.
Ravi