Re: [PATCH v3 3/7] target/ppc: remove unnecessary SPR functions

[David Gibson]

On Fri, Apr 30, 2021 at 05:58:46PM -0700, Richard Henderson wrote:
> On 4/30/21 12:35 PM, Bruno Larsen (billionai) wrote:
> > Removed functions gen_read_xer and gen_write_xer, moving their logic
> > directly into spr_read_xer and spr_write_xer, respectively.
> > 
> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> > ---
> 
> "Unnecessary" makes me believe that the code isn't used at all.
> A better description for this patch is
> 
> ---
> target/ppc: Fold gen_{read,write}_xer into spr_{read,write}_xer
> 
> Fold these functions into their single caller.
> ---

Agreed.
 
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

This one looks good to me now, whereas I still need to think about the
rest of the code motion here.  So, could you move this earlier in the
series, before the creation of spr_tcg.inc.c, so I can go ahead and
apply it while we continue discussing the rest.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature