|
From: | Daniel Henrique Barboza |
Subject: | Re: [PATCH v13 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c |
Date: | Fri, 25 Feb 2022 07:10:13 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 |
On 2/24/22 18:45, Richard Henderson wrote:
On 2/24/22 10:19, Daniel Henrique Barboza wrote:+void helper_ebb_perfm_excp(CPUPPCState *env)Please reserve the prefix "helper_" for something that is called from tcg generated code, which this is not.
The prefix is due to the fact that this is being declared as a translation helper in target/ppc/helper.h, which is also part of the problem you mentioned. I'll rename the function and not declare it as a translation helper. Thanks, Daniel
r~
[Prev in Thread] | Current Thread | [Next in Thread] |