[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/18] block: Change blk_{pread,pwrite}() param order
From: |
Eric Blake |
Subject: |
Re: [PATCH 03/18] block: Change blk_{pread,pwrite}() param order |
Date: |
Wed, 18 May 2022 09:05:39 -0500 |
User-agent: |
NeoMutt/20220429-71-6f7d3e |
On Tue, May 17, 2022 at 12:37:31PM +0100, Alberto Faria wrote:
> Swap 'buf' and 'bytes' around for consistency with
> blk_co_{pread,pwrite}(), and in preparation to implement these functions
> using generated_co_wrapper.
>
> Callers were updated using this Coccinelle script:
>
> @@ expression blk, offset, buf, bytes, flags; @@
> - blk_pread(blk, offset, buf, bytes, flags)
> + blk_pread(blk, offset, bytes, buf, flags)
>
> @@ expression blk, offset, buf, bytes, flags; @@
> - blk_pwrite(blk, offset, buf, bytes, flags)
> + blk_pwrite(blk, offset, bytes, buf, flags)
>
> It had no effect on hw/block/nand.c, presumably due to the #if, so that
> file was updated manually.
>
> Overly-long lines were then fixed by hand.
>
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH 00/18] Make block-backend-io.h API more consistent, Alberto Faria, 2022/05/17
- [PATCH 03/18] block: Change blk_{pread,pwrite}() param order, Alberto Faria, 2022/05/17
- Re: [PATCH 03/18] block: Change blk_{pread,pwrite}() param order,
Eric Blake <=
- [PATCH 02/18] block: Add a 'flags' param to blk_pread(), Alberto Faria, 2022/05/17
- [PATCH 01/18] block: Make blk_{pread,pwrite}() return 0 on success, Alberto Faria, 2022/05/17