Re: [PATCH v2 06/12] target/ppc: implement xscvspdpn with helper_todouble

[Daniel Henrique Barboza]

On 5/23/22 12:54, Richard Henderson wrote:
> On 5/23/22 06:48, Daniel Henrique Barboza wrote:
> > Checking 0006-target-ppc-declare-xscvspdpn-helper-with-call-flags.patch...
> > ERROR: spaces required around that '*' (ctx:WxV)
> > #69: FILE: target/ppc/translate/vsx-impl.c.inc:1049:
> > +bool trans_XSCVSPDPN(DisasContext *ctx, arg_XX2 *a)
> >                                                   ^
> >
> > My guess is that since the var 'arg_XX2' ends with a numeral the script
> > thinks that the following '*' is an arithmetic operation. Problem is that
> > we have other examples of this kind of declaration in the same file, e.g.:
> >
> >
> > static bool trans_XVCVBF16SPN(DisasContext *ctx, arg_XX2 *a)
> >
> >
> >
> > Is there a way to convince checkpatch.pl that this is an okay format?
>
> Not that I know of.  I just ignore these parsing errors.


Works for me. We should be aware that gitlab will complain about it when pushing
this to master though. E.g. https://gitlab.com/danielhb/qemu/-/jobs/2496047821 .

Thanks,


Daniel


> r~