[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 06/11] ppc/pnv: make pnv_ics_resend() use chip8->phbs[]
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH 06/11] ppc/pnv: make pnv_ics_resend() use chip8->phbs[] |
Date: |
Mon, 13 Jun 2022 12:44:51 -0300 |
pnv_ics_resend() is scrolling through all the child objects of the chip
to search for the PHBs. It's faster and simpler to just use the phbs[]
array.
pnv_ics_resend_child() was folded into pnv_ics_resend() since it's too
simple to justify its own function.
Signed-off-by: Daniel Henrique Barboza <danielhb@linux.ibm.com>
---
hw/ppc/pnv.c | 22 +++++++---------------
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 05a8d5034f..d70deffa1d 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -1993,28 +1993,20 @@ PnvChip *pnv_get_chip(PnvMachineState *pnv, uint32_t
chip_id)
return NULL;
}
-static int pnv_ics_resend_child(Object *child, void *opaque)
-{
- PnvPHB3 *phb3 = (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3);
-
- if (phb3) {
- ics_resend(&phb3->lsis);
- ics_resend(ICS(&phb3->msis));
- }
- return 0;
-}
-
static void pnv_ics_resend(XICSFabric *xi)
{
PnvMachineState *pnv = PNV_MACHINE(xi);
- int i;
+ int i, j;
for (i = 0; i < pnv->num_chips; i++) {
- PnvChip *chip = pnv->chips[i];
Pnv8Chip *chip8 = PNV8_CHIP(pnv->chips[i]);
- ics_resend(&chip8->psi.ics);
- object_child_foreach(OBJECT(chip), pnv_ics_resend_child, NULL);
+ for (j = 0; j < chip8->num_phbs; j++) {
+ PnvPHB3 *phb3 = &chip8->phbs[j];
+
+ ics_resend(&phb3->lsis);
+ ics_resend(ICS(&phb3->msis));
+ }
}
}
--
2.36.1
- Re: [PATCH 01/11] ppc/pnv: move root port attach to pnv_phb4_realize(), (continued)
- [PATCH 02/11] ppc/pnv: attach phb3/phb4 root ports in QOM tree, Daniel Henrique Barboza, 2022/06/13
- [PATCH 03/11] ppc/pnv: use dev->parent_bus->parent to get the PHB, Daniel Henrique Barboza, 2022/06/13
- [PATCH 06/11] ppc/pnv: make pnv_ics_resend() use chip8->phbs[],
Daniel Henrique Barboza <=
- [PATCH 05/11] ppc/pnv: make pnv_ics_get() use the chip8->phbs[] array, Daniel Henrique Barboza, 2022/06/13
- [PATCH 04/11] ppc/pnv: use dev instead of pci->qdev in root_port_realize(), Daniel Henrique Barboza, 2022/06/13
- [PATCH 08/11] ppc/pnv: turn chip8->phbs[] into a PnvPHB3* array, Daniel Henrique Barboza, 2022/06/13