[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 29/33] hw/isa/piix: Harmonize names of reset control memory re
From: |
Bernhard Beschow |
Subject: |
[PATCH v6 29/33] hw/isa/piix: Harmonize names of reset control memory regions |
Date: |
Mon, 9 Jan 2023 18:23:42 +0100 |
There is no need for having different names here. Having the same name
further allows code to be shared between PIIX3 and PIIX4.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20221022150508.26830-38-shentey@gmail.com>
---
hw/isa/piix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/isa/piix.c b/hw/isa/piix.c
index 81cb4e64ab..d8cd80e859 100644
--- a/hw/isa/piix.c
+++ b/hw/isa/piix.c
@@ -351,7 +351,7 @@ static void pci_piix3_realize(PCIDevice *dev, Error **errp)
isa_bus_irqs(isa_bus, d->pic.in_irqs);
memory_region_init_io(&d->rcr_mem, OBJECT(dev), &rcr_ops, d,
- "piix3-reset-control", 1);
+ "piix-reset-control", 1);
memory_region_add_subregion_overlap(pci_address_space_io(dev),
PIIX_RCR_IOPORT, &d->rcr_mem, 1);
@@ -547,7 +547,7 @@ static void piix4_realize(PCIDevice *dev, Error **errp)
}
memory_region_init_io(&s->rcr_mem, OBJECT(dev), &rcr_ops, s,
- "reset-control", 1);
+ "piix-reset-control", 1);
memory_region_add_subregion_overlap(pci_address_space_io(dev),
PIIX_RCR_IOPORT, &s->rcr_mem, 1);
--
2.39.0
[PATCH v6 26/33] hw/isa/piix4: Reuse struct PIIXState from PIIX3, Bernhard Beschow, 2023/01/09
[PATCH v6 29/33] hw/isa/piix: Harmonize names of reset control memory regions,
Bernhard Beschow <=
[PATCH v6 31/33] hw/isa/piix: Rename functions to be shared for interrupt triggering, Bernhard Beschow, 2023/01/09
[PATCH v6 30/33] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4, Bernhard Beschow, 2023/01/09
Re: [PATCH v6 00/33] Consolidate PIIX south bridges, Philippe Mathieu-Daudé, 2023/01/13