Re: [PATCH v5 5/9] tests/qtest/e1000e-test: Fabricate ethernet header

[Thomas Huth]

On 30/01/2023 15.08, Akihiko Odaki wrote:
> e1000e understands ethernet header so fabricate something convincing.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   tests/qtest/e1000e-test.c   | 17 +++++++++++------
>   tests/qtest/libqos/e1000e.h |  2 ++
>   2 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/tests/qtest/e1000e-test.c b/tests/qtest/e1000e-test.c
> index b63a4d3c91..98706355e3 100644
> --- a/tests/qtest/e1000e-test.c
> +++ b/tests/qtest/e1000e-test.c
> @@ -27,6 +27,7 @@
>   #include "qemu/osdep.h"
>   #include "libqtest-single.h"
>   #include "libqos/pci-pc.h"
> +#include "net/eth.h"
>   #include "qemu/sockets.h"
>   #include "qemu/iov.h"
>   #include "qemu/module.h"
> @@ -35,9 +36,13 @@
>   #include "libqos/e1000e.h"
>   #include "hw/net/e1000_regs.h"
>   
> +static const struct eth_header test = {

No need to respin, but in case you do it anyway: I'd suggest to use a 
different name here instead of "test". Maybe "testdata" or "test_hdr" or 
something like that?

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>