[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 0/7] VIA and general PCI IDE cleanup
From: |
Bernhard Beschow |
Subject: |
[PATCH v3 0/7] VIA and general PCI IDE cleanup |
Date: |
Wed, 31 May 2023 23:10:36 +0200 |
This series is split off from a more general PCI IDE refactoring aiming for a
common implementation of the PCI IDE controller specification for all
TYPE_PCI_IDE models [1].
The first three patches resolve a circular dependency between the VIA IDE
controller and its south bridge. The next three patches resolves redundant code
accross all TYPE_PCI_IDE models. The last patch modernizes VM state setup in
PIIX IDE.
Testing done:
* `make check`
* `make check-avocado`
* `qemu-system-ppc -machine pegasos2 -rtc base=localtime -device \
ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso \
-bios pegasos2.rom`
The machine booted successfully and a startup sound was hearable
* `qemu-system-ppc -machine sam460ex -rtc base=localtime -drive \
if=none,id=cd,file=morphos-3.17.iso,format=raw -device \
ide-cd,drive=cd,bus=ide.1`
The machine booted successfully into graphical desktop environment
v3:
* Fix formatting (Mark) ... and split into two commits (Bernhard)
v2:
* Add missing Signed-off-by tag to last commit (Zoltan)
Changes since [1]:
* Turn legacy IRQs into named GPIOs (Mark)
* Don't make VIA IDE legacy IRQs routable; just wire up in host device (Zoltan)
* Rename extracted bmdma_clear_status() (Zoltan)
... to bmdma_status_writeb() (Mark)
[1]
https://lore.kernel.org/qemu-devel/20230422150728.176512-1-shentey@gmail.com/
Bernhard Beschow (7):
hw/ide/pci: Expose legacy interrupts as named GPIOs
hw/ide/via: Wire up IDE legacy interrupts in host device
hw/isa/vt82c686: Remove via_isa_set_irq()
hw/ide: Extract IDEBus assignment into bmdma_init()
hw/ide: Extract bmdma_status_writeb()
hw/ide/pci: Replace some magic numbers by constants
hw/ide/piix: Move registration of VMStateDescription to DeviceClass
include/hw/ide/pci.h | 1 +
include/hw/isa/vt82c686.h | 2 --
hw/ide/cmd646.c | 3 +--
hw/ide/pci.c | 16 ++++++++++++++++
hw/ide/piix.c | 8 +++-----
hw/ide/sii3112.c | 7 ++-----
hw/ide/via.c | 9 +++++----
hw/isa/vt82c686.c | 11 +++++------
8 files changed, 33 insertions(+), 24 deletions(-)
--
2.40.1
- [PATCH v3 0/7] VIA and general PCI IDE cleanup,
Bernhard Beschow <=
- [PATCH v3 1/7] hw/ide/pci: Expose legacy interrupts as named GPIOs, Bernhard Beschow, 2023/05/31
- [PATCH v3 2/7] hw/ide/via: Wire up IDE legacy interrupts in host device, Bernhard Beschow, 2023/05/31
- [PATCH v3 3/7] hw/isa/vt82c686: Remove via_isa_set_irq(), Bernhard Beschow, 2023/05/31
- [PATCH v3 6/7] hw/ide/pci: Replace some magic numbers by constants, Bernhard Beschow, 2023/05/31
- [PATCH v3 5/7] hw/ide: Extract bmdma_status_writeb(), Bernhard Beschow, 2023/05/31
- [PATCH v3 7/7] hw/ide/piix: Move registration of VMStateDescription to DeviceClass, Bernhard Beschow, 2023/05/31
- [PATCH v3 4/7] hw/ide: Extract IDEBus assignment into bmdma_init(), Bernhard Beschow, 2023/05/31