Re: [PATCH 1/7] target/ppc: Remove single use function

[Cédric Le Goater]

On 5/30/23 15:28, BALATON Zoltan wrote:
> The get_physical_address() function is a trivial wrapper of
> get_physical_address_wtlb() that is only used once. Remove it and call
> get_physical_address_wtlb() directly instead.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> ---
>   target/ppc/mmu_helper.c | 11 +----------
>   1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
> index 64e30435f5..c0c71a68ff 100644
> --- a/target/ppc/mmu_helper.c
> +++ b/target/ppc/mmu_helper.c
> @@ -168,15 +168,6 @@ static void booke206_flush_tlb(CPUPPCState *env, int flags,
>       tlb_flush(env_cpu(env));
>   }
>   
> -static int get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx,
> -                                target_ulong eaddr, MMUAccessType access_type,
> -                                int type)
> -{
> -    return get_physical_address_wtlb(env, ctx, eaddr, access_type, type, 0);
> -}
> -
> -
> -
>   
> /*****************************************************************************/
>   /* BATs management */
>   #if !defined(FLUSH_ALL_TLBS)
> @@ -643,7 +634,7 @@ target_ulong helper_rac(CPUPPCState *env, target_ulong addr)
>        */
>       nb_BATs = env->nb_BATs;
>       env->nb_BATs = 0;
> -    if (get_physical_address(env, &ctx, addr, 0, ACCESS_INT) == 0) {
> +    if (get_physical_address_wtlb(env, &ctx, addr, 0, ACCESS_INT, 0) == 0) {
>           ret = ctx.raddr;
>       }
>       env->nb_BATs = nb_BATs;