|
From: | Pavel Dovgalyuk |
Subject: | Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events |
Date: | Tue, 8 Aug 2023 06:52:39 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
On 08.08.2023 06:09, Nicholas Piggin wrote:
On Sun Aug 6, 2023 at 9:46 PM AEST, Nicholas Piggin wrote:On Fri Aug 4, 2023 at 6:50 PM AEST, Pavel Dovgalyuk wrote:BTW, there is a function qemu_register_reset_nosnapshotload that can be used in similar cases. Can you just use it without changing the code of the reset handler?I didn't know that, thanks for pointing it out. I'll take a closer look at it before reposting.Seems a bit tricky because the device tree has to be rebuilt at reset time (including snapshot load), but it uses the random number. So
It seems strange to me, that loading the existing configuration has to randomize the device tree.
having a second nosnapshotload reset function might not be called in the correct order, I think? For now I will keep it as is.
Ok, let's wait for other reviewers. Pavel Dovgalyuk
[Prev in Thread] | Current Thread | [Next in Thread] |