[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/21] qapi: Inline and remove QERR_IO_ERROR definition
From: |
Juan Quintela |
Subject: |
Re: [PATCH 13/21] qapi: Inline and remove QERR_IO_ERROR definition |
Date: |
Wed, 04 Oct 2023 20:15:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> Address the comment added in commit 4629ed1e98
> ("qerror: Finally unused, clean up"), from 2015:
>
> /*
> * These macros will go away, please don't use
> * in new code, and do not add new ones!
> */
>
> Mechanical transformation using:
>
> $ sed -i -e 's/QERR_IO_ERROR/"An IO error has occurred"/' \
> $(git grep -wl QERR_IO_ERROR)
>
> then manually removing the definition in include/qapi/qmp/qerror.h.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
- [PATCH 05/21] qapi: Inline QERR_INVALID_PARAMETER definition (constant parameter), (continued)
- [PATCH 05/21] qapi: Inline QERR_INVALID_PARAMETER definition (constant parameter), Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 07/21] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant param), Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 08/21] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value), Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 10/21] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant value), Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 09/21] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 11/21] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant param), Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 13/21] qapi: Inline and remove QERR_IO_ERROR definition, Philippe Mathieu-Daudé, 2023/10/04
- Re: [PATCH 13/21] qapi: Inline and remove QERR_IO_ERROR definition,
Juan Quintela <=
- [PATCH 12/21] qapi: Inline and remove QERR_INVALID_PARAMETER_VALUE definition, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 14/21] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 15/21] qapi: Inline QERR_MISSING_PARAMETER definition (constant parameter), Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 16/21] qapi: Inline and remove QERR_MISSING_PARAMETER definition, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 18/21] qapi: Inline and remove QERR_PROPERTY_VALUE_OUT_OF_RANGE definition, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 17/21] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH 19/21] qapi: Inline and remove QERR_QGA_COMMAND_FAILED definition, Philippe Mathieu-Daudé, 2023/10/04