[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 13/25] target/arm: Move the reference to arm-core.xml
From: |
Alex Bennée |
Subject: |
[PATCH 13/25] target/arm: Move the reference to arm-core.xml |
Date: |
Mon, 9 Oct 2023 17:40:52 +0100 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Some subclasses overwrite gdb_core_xml_file member but others don't.
Always initialize the member in the subclasses for consistency.
This especially helps for AArch64; in a following change, the file
specified by gdb_core_xml_file is always looked up even if it's going to
be overwritten later. Looking up arm-core.xml results in an error as
it will not be embedded in the AArch64 build.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230912224107.29669-7-akihiko.odaki@daynix.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
target/arm/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 831295d7cd..b65e8cfea3 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -2392,7 +2392,6 @@ static void arm_cpu_class_init(ObjectClass *oc, void
*data)
cc->sysemu_ops = &arm_sysemu_ops;
#endif
cc->gdb_num_core_regs = 26;
- cc->gdb_core_xml_file = "arm-core.xml";
cc->gdb_arch_name = arm_gdb_arch_name;
cc->gdb_get_dynamic_xml = arm_gdb_get_dynamic_xml;
cc->gdb_stop_before_watchpoint = true;
@@ -2414,8 +2413,10 @@ static void arm_cpu_instance_init(Object *obj)
static void cpu_register_class_init(ObjectClass *oc, void *data)
{
ARMCPUClass *acc = ARM_CPU_CLASS(oc);
+ CPUClass *cc = CPU_CLASS(acc);
acc->info = data;
+ cc->gdb_core_xml_file = "arm-core.xml";
}
void arm_cpu_register(const ARMCPUInfo *info)
--
2.39.2
- [PATCH 10/25] plugins: Check if vCPU is realized, (continued)
- [PATCH 10/25] plugins: Check if vCPU is realized, Alex Bennée, 2023/10/09
- [PATCH 06/25] configure: allow user to override docker engine, Alex Bennée, 2023/10/09
- [PATCH 05/25] tests/docker: make docker engine choice entirely configure driven, Alex Bennée, 2023/10/09
- [PATCH 07/25] configure: remove gcc version suffixes, Alex Bennée, 2023/10/09
- [PATCH 09/25] gdbstub: Fix target.xml response, Alex Bennée, 2023/10/09
- [PATCH 14/25] hw/core/cpu: Return static value with gdb_arch_name(), Alex Bennée, 2023/10/09
- [PATCH 13/25] target/arm: Move the reference to arm-core.xml,
Alex Bennée <=
- [PATCH 23/25] contrib/plugins: fix coverity warning in cache, Alex Bennée, 2023/10/09
- [PATCH 11/25] contrib/plugins: Use GRWLock in execlog, Alex Bennée, 2023/10/09
- [PATCH 12/25] gdbstub: Introduce GDBFeature structure, Alex Bennée, 2023/10/09
- [PATCH 25/25] contrib/plugins: fix coverity warning in hotblocks, Alex Bennée, 2023/10/09
- [PATCH 19/25] gdbstub: Replace gdb_regs with an array, Alex Bennée, 2023/10/09
- [PATCH 22/25] plugins: Set final instruction count in plugin_gen_tb_end, Alex Bennée, 2023/10/09
- [PATCH 15/25] gdbstub: Use g_markup_printf_escaped(), Alex Bennée, 2023/10/09
- [PATCH 21/25] target/sh4: Disable decode_gusa when plugins enabled, Alex Bennée, 2023/10/09