[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 09/19] cpus: Filter for target specific CPU (x86)
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 09/19] cpus: Filter for target specific CPU (x86) |
Date: |
Fri, 20 Oct 2023 18:36:31 +0200 |
Enforce qemu_get_cpu() to return X86 CPUs in X86 specific files.
Mechanical change using the following coccinelle script:
@@ expression index; @@
- qemu_get_cpu(index, NULL)
+ qemu_get_cpu(index, TYPE_X86_CPU)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/hyperv/hyperv.c | 2 +-
hw/i386/kvm/xen_evtchn.c | 8 ++++----
target/i386/kvm/xen-emu.c | 14 +++++++-------
target/i386/monitor.c | 2 +-
4 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c
index a43f29ad8d..cdda93e14d 100644
--- a/hw/hyperv/hyperv.c
+++ b/hw/hyperv/hyperv.c
@@ -226,7 +226,7 @@ struct HvSintRoute {
static CPUState *hyperv_find_vcpu(uint32_t vp_index)
{
- CPUState *cs = qemu_get_cpu(vp_index, NULL);
+ CPUState *cs = qemu_get_cpu(vp_index, TYPE_X86_CPU);
assert(hyperv_vp_index(cs) == vp_index);
return cs;
}
diff --git a/hw/i386/kvm/xen_evtchn.c b/hw/i386/kvm/xen_evtchn.c
index de3650ba3b..d75b53934d 100644
--- a/hw/i386/kvm/xen_evtchn.c
+++ b/hw/i386/kvm/xen_evtchn.c
@@ -542,7 +542,7 @@ static void deassign_kernel_port(evtchn_port_t port)
static int assign_kernel_port(uint16_t type, evtchn_port_t port,
uint32_t vcpu_id)
{
- CPUState *cpu = qemu_get_cpu(vcpu_id, NULL);
+ CPUState *cpu = qemu_get_cpu(vcpu_id, TYPE_X86_CPU);
struct kvm_xen_hvm_attr ha;
if (!cpu) {
@@ -589,7 +589,7 @@ static bool valid_port(evtchn_port_t port)
static bool valid_vcpu(uint32_t vcpu)
{
- return !!qemu_get_cpu(vcpu, NULL);
+ return !!qemu_get_cpu(vcpu, TYPE_X86_CPU);
}
static void unbind_backend_ports(XenEvtchnState *s)
@@ -917,7 +917,7 @@ static int set_port_pending(XenEvtchnState *s,
evtchn_port_t port)
if (s->evtchn_in_kernel) {
XenEvtchnPort *p = &s->port_table[port];
- CPUState *cpu = qemu_get_cpu(p->vcpu, NULL);
+ CPUState *cpu = qemu_get_cpu(p->vcpu, TYPE_X86_CPU);
struct kvm_irq_routing_xen_evtchn evt;
if (!cpu) {
@@ -1779,7 +1779,7 @@ int xen_evtchn_translate_pirq_msi(struct
kvm_irq_routing_entry *route,
return -EINVAL;
}
- cpu = qemu_get_cpu(s->port_table[port].vcpu, NULL);
+ cpu = qemu_get_cpu(s->port_table[port].vcpu, TYPE_X86_CPU);
if (!cpu) {
return -EINVAL;
}
diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c
index f289af906c..0a973c0259 100644
--- a/target/i386/kvm/xen-emu.c
+++ b/target/i386/kvm/xen-emu.c
@@ -384,7 +384,7 @@ static void do_set_vcpu_info_gpa(CPUState *cs,
run_on_cpu_data data)
void *kvm_xen_get_vcpu_info_hva(uint32_t vcpu_id)
{
- CPUState *cs = qemu_get_cpu(vcpu_id, NULL);
+ CPUState *cs = qemu_get_cpu(vcpu_id, TYPE_X86_CPU);
if (!cs) {
return NULL;
}
@@ -418,7 +418,7 @@ void kvm_xen_maybe_deassert_callback(CPUState *cs)
void kvm_xen_set_callback_asserted(void)
{
- CPUState *cs = qemu_get_cpu(0, NULL);
+ CPUState *cs = qemu_get_cpu(0, TYPE_X86_CPU);
if (cs) {
X86_CPU(cs)->env.xen_callback_asserted = true;
@@ -427,7 +427,7 @@ void kvm_xen_set_callback_asserted(void)
void kvm_xen_inject_vcpu_callback_vector(uint32_t vcpu_id, int type)
{
- CPUState *cs = qemu_get_cpu(vcpu_id, NULL);
+ CPUState *cs = qemu_get_cpu(vcpu_id, TYPE_X86_CPU);
uint8_t vector;
if (!cs) {
@@ -491,7 +491,7 @@ static void do_set_vcpu_timer_virq(CPUState *cs,
run_on_cpu_data data)
int kvm_xen_set_vcpu_virq(uint32_t vcpu_id, uint16_t virq, uint16_t port)
{
- CPUState *cs = qemu_get_cpu(vcpu_id, NULL);
+ CPUState *cs = qemu_get_cpu(vcpu_id, TYPE_X86_CPU);
if (!cs) {
return -ENOENT;
@@ -588,7 +588,7 @@ static int xen_set_shared_info(uint64_t gfn)
trace_kvm_xen_set_shared_info(gfn);
for (i = 0; i < XEN_LEGACY_MAX_VCPUS; i++) {
- CPUState *cpu = qemu_get_cpu(i, NULL);
+ CPUState *cpu = qemu_get_cpu(i, TYPE_X86_CPU);
if (cpu) {
async_run_on_cpu(cpu, do_set_vcpu_info_default_gpa,
RUN_ON_CPU_HOST_ULONG(gpa));
@@ -834,7 +834,7 @@ static int kvm_xen_hcall_evtchn_upcall_vector(struct
kvm_xen_exit *exit,
return -EINVAL;
}
- target_cs = qemu_get_cpu(up.vcpu, NULL);
+ target_cs = qemu_get_cpu(up.vcpu, TYPE_X86_CPU);
if (!target_cs) {
return -EINVAL;
}
@@ -1161,7 +1161,7 @@ static bool kvm_xen_hcall_vcpu_op(struct kvm_xen_exit
*exit, X86CPU *cpu,
{
CPUState *cs = CPU(cpu);
CPUState *dest = cs->cpu_index == vcpu_id ? cs : qemu_get_cpu(vcpu_id,
- NULL);
+
TYPE_X86_CPU);
int err;
if (!dest) {
diff --git a/target/i386/monitor.c b/target/i386/monitor.c
index aca7be61dd..01bfb4e3f1 100644
--- a/target/i386/monitor.c
+++ b/target/i386/monitor.c
@@ -592,7 +592,7 @@ void hmp_mce(Monitor *mon, const QDict *qdict)
if (qdict_get_try_bool(qdict, "broadcast", false)) {
flags |= MCE_INJECT_BROADCAST;
}
- cs = qemu_get_cpu(cpu_index, NULL);
+ cs = qemu_get_cpu(cpu_index, TYPE_X86_CPU);
if (cs != NULL) {
cpu = X86_CPU(cs);
cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr, misc,
--
2.41.0
- Re: [RFC PATCH 01/19] cpus: Add argument to qemu_get_cpu() to filter CPUs by QOM type, (continued)
- [PATCH 02/19] cpus: Filter for target specific CPU (generic), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 03/19] cpus: Filter for target specific CPU (arm), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 05/19] cpus: Filter for target specific CPU (mips), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 06/19] cpus: Filter for target specific CPU (s390x), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 04/19] cpus: Filter for target specific CPU (loongarch), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 07/19] cpus: Filter for target specific CPU (riscv), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 08/19] cpus: Filter for target specific CPU (ppc), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 09/19] cpus: Filter for target specific CPU (x86),
Philippe Mathieu-Daudé <=
- [PATCH 10/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_ARM_CPU), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 11/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_POWERPC_CPU), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 12/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_MIPS_CPU), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 13/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_M68K_CPU), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 14/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_S390X_CPU), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 15/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_RISCV_CPU), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 16/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_TRICORE_CPU), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 17/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_SUPERH_CPU), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 18/19] cpus: Replace first_cpu by qemu_get_cpu(0, TYPE_RX_CPU), Philippe Mathieu-Daudé, 2023/10/20