[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 11/13] migration: Use vmstate_register_any() for audio
From: |
Volker Rümelin |
Subject: |
Re: [PATCH v2 11/13] migration: Use vmstate_register_any() for audio |
Date: |
Sat, 21 Oct 2023 16:55:59 +0200 |
User-agent: |
Mozilla Thunderbird |
Am 20.10.23 um 11:07 schrieb Juan Quintela:
> We can have more than one audio card.
Hi Juan,
I wouldn't use the term "audio card" here. In QEMU speak, Audiodev is an
"audio backend".
With best regards,
Volker
>
> void audio_init_audiodevs(void)
> {
> AudiodevListEntry *e;
>
> QSIMPLEQ_FOREACH(e, &audiodevs, next) {
> audio_init(e->dev, &error_fatal);
> }
> }
>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> audio/audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index e9815d6812..f91e05b72c 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -1781,7 +1781,7 @@ static AudioState *audio_init(Audiodev *dev, Error
> **errp)
>
> QTAILQ_INSERT_TAIL(&audio_states, s, list);
> QLIST_INIT (&s->card_head);
> - vmstate_register (NULL, 0, &vmstate_audio, s);
> + vmstate_register_any(NULL, &vmstate_audio, s);
> return s;
>
> out:
- Re: [PATCH v2 06/13] migration: Use VMSTATE_INSTANCE_ID_ANY for s390 devices, (continued)
- [PATCH v2 05/13] migration: Use VMSTATE_INSTANCE_ID_ANY for slirp, Juan Quintela, 2023/10/20
- [PATCH v2 08/13] migration: vmstate_register() check that instance_id is valid, Juan Quintela, 2023/10/20
- [PATCH v2 07/13] migration: Hack to maintain backwards compatibility for ppc, Juan Quintela, 2023/10/20
- [PATCH v2 10/13] migration: Improve example and documentation of vmstate_register(), Juan Quintela, 2023/10/20
- [PATCH v2 09/13] migration: Check in savevm_state_handler_insert for dups, Juan Quintela, 2023/10/20
- [PATCH v2 11/13] migration: Use vmstate_register_any() for audio, Juan Quintela, 2023/10/20
- Re: [PATCH v2 11/13] migration: Use vmstate_register_any() for audio,
Volker Rümelin <=
- [PATCH v2 12/13] migration: Use vmstate_register_any() for eeprom93xx, Juan Quintela, 2023/10/20
- [PATCH v2 13/13] migration: Use vmstate_register_any() for vmware_vga, Juan Quintela, 2023/10/20