[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/39] migration: Move ram_flush_compressed_data() to ram-compress
From: |
Juan Quintela |
Subject: |
[PULL 15/39] migration: Move ram_flush_compressed_data() to ram-compress.c |
Date: |
Tue, 24 Oct 2023 15:12:41 +0200 |
As we export it, rename it compress_flush_data().
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20231019110724.15324-10-quintela@redhat.com>
---
migration/ram-compress.h | 1 +
migration/ram-compress.c | 9 +++++++++
migration/ram.c | 17 ++++-------------
3 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/migration/ram-compress.h b/migration/ram-compress.h
index 636281ed97..7ba01e2882 100644
--- a/migration/ram-compress.h
+++ b/migration/ram-compress.h
@@ -73,5 +73,6 @@ uint64_t ram_compressed_pages(void);
void update_compress_thread_counts(const CompressParam *param, int bytes_xmit);
void compress_update_rates(uint64_t page_count);
int compress_send_queued_data(CompressParam *param);
+void compress_flush_data(void);
#endif
diff --git a/migration/ram-compress.c b/migration/ram-compress.c
index af42cab0fe..1443a1cb45 100644
--- a/migration/ram-compress.c
+++ b/migration/ram-compress.c
@@ -558,3 +558,12 @@ void compress_update_rates(uint64_t page_count)
compression_counters.compressed_size;
}
}
+
+void compress_flush_data(void)
+{
+ if (!migrate_compress()) {
+ return;
+ }
+
+ flush_compressed_data(compress_send_queued_data);
+}
diff --git a/migration/ram.c b/migration/ram.c
index b6d485358e..849752ef29 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1300,15 +1300,6 @@ int compress_send_queued_data(CompressParam *param)
return len;
}
-static void ram_flush_compressed_data(void)
-{
- if (!migrate_compress()) {
- return;
- }
-
- flush_compressed_data(compress_send_queued_data);
-}
-
#define PAGE_ALL_CLEAN 0
#define PAGE_TRY_AGAIN 1
#define PAGE_DIRTY_FOUND 2
@@ -1364,7 +1355,7 @@ static int find_dirty_block(RAMState *rs,
PageSearchStatus *pss)
* Also If xbzrle is on, stop using the data compression at this
* point. In theory, xbzrle can do better than compression.
*/
- ram_flush_compressed_data();
+ compress_flush_data();
/* Hit the end of the list */
pss->block = QLIST_FIRST_RCU(&ram_list.blocks);
@@ -2036,7 +2027,7 @@ static bool save_compress_page(RAMState *rs,
PageSearchStatus *pss,
* much CPU resource.
*/
if (pss->block != pss->last_sent_block) {
- ram_flush_compressed_data();
+ compress_flush_data();
return false;
}
@@ -3083,7 +3074,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
* page is sent in one chunk.
*/
if (migrate_postcopy_ram()) {
- ram_flush_compressed_data();
+ compress_flush_data();
}
/*
@@ -3184,7 +3175,7 @@ static int ram_save_complete(QEMUFile *f, void *opaque)
}
qemu_mutex_unlock(&rs->bitmap_mutex);
- ram_flush_compressed_data();
+ compress_flush_data();
int ret = rdma_registration_stop(f, RAM_CONTROL_FINISH);
if (ret < 0) {
--
2.41.0
- [PULL 04/39] migration/doc: We broke backwards compatibility, (continued)
- [PULL 04/39] migration/doc: We broke backwards compatibility, Juan Quintela, 2023/10/24
- [PULL 06/39] migration: Rename ram_handle_compressed() to ram_handle_zero(), Juan Quintela, 2023/10/24
- [PULL 08/39] migration: Give one error if trying to set COMPRESSION and XBZRLE, Juan Quintela, 2023/10/24
- [PULL 09/39] migration: Remove save_page_use_compression(), Juan Quintela, 2023/10/24
- [PULL 12/39] migration: Move busy++ to migrate_with_multithread, Juan Quintela, 2023/10/24
- [PULL 10/39] migration: Make compress_data_with_multithreads return bool, Juan Quintela, 2023/10/24
- [PULL 13/39] migration: Create compress_update_rates(), Juan Quintela, 2023/10/24
- [PULL 14/39] migration: Export send_queued_data(), Juan Quintela, 2023/10/24
- [PULL 11/39] migration: Simplify compress_page_with_multithread(), Juan Quintela, 2023/10/24
- [PULL 16/39] migration: Merge flush_compressed_data() and compress_flush_data(), Juan Quintela, 2023/10/24
- [PULL 15/39] migration: Move ram_flush_compressed_data() to ram-compress.c,
Juan Quintela <=
- [PULL 19/39] hw/s390x/s390-skeys: Don't call register_savevm_live() during instance_init(), Juan Quintela, 2023/10/24
- [PULL 18/39] hw/ipmi: Don't call vmstate_register() from instance_init() functions, Juan Quintela, 2023/10/24
- [PULL 20/39] hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" property, Juan Quintela, 2023/10/24
- [PULL 23/39] migration: rename vmstate_save_needed->vmstate_section_needed, Juan Quintela, 2023/10/24
- [PULL 21/39] hw/s390x/s390-stattrib: Don't call register_savevm_live() during instance_init(), Juan Quintela, 2023/10/24
- [PULL 22/39] migration/ram: Fix compilation with -Wshadow=local, Juan Quintela, 2023/10/24
- [PULL 25/39] migration: Create vmstate_register_any(), Juan Quintela, 2023/10/24
- [PULL 17/39] migration: Rename ram_compressed_pages() to compress_ram_pages(), Juan Quintela, 2023/10/24