Re: [PATCH v6 09/23] ui/console: allow to override the default VC

[Daniel P . Berrangé]

On Fri, Oct 27, 2023 at 05:53:19AM -0700, Andrea Bolognani wrote:
> On Wed, Oct 25, 2023 at 11:08:03PM +0400, marcandre.lureau@redhat.com wrote:
> > If a display is backed by a specialized VC, allow to override the
> > default "vc:80Cx24C". For that, set the dpy.type just before creating
> > the default serial/parallel/monitor.
> >
> > As suggested by Paolo, if the display doesn't implement a VC (get_vc()
> > returns NULL), use a fallback that will use a muxed console on stdio.
> >
> > This changes the behaviour of "qemu -display none", to create a muxed
> > serial/monitor by default.
> 
> Have you verified that this doesn't break libvirt? We use '-display
> none' for every single VM we run.

IIUC we're ok as this logic appears to be skipped when -nodefaults
is set.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|