Re: [PATCH 7/7] target/i386/cpu: Improve error message for property "vendor"

[Philippe Mathieu-Daudé]

On 31/10/23 12:10, Markus Armbruster wrote:
> Improve
>
>      $ qemu-system-x86_64 -device max-x86_64-cpu,vendor=me
>      qemu-system-x86_64: -device max-x86_64-cpu,vendor=me: Property '.vendor' 
> doesn't take value 'me'
>
> to
>
>      qemu-system-x86_64: -device max-x86_64-cpu,vendor=0123456789abc: value of 
> property 'vendor' must consist of excactly 12 characters
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   target/i386/cpu.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index fc8484cb5e..e708628c16 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -5192,7 +5192,8 @@ static void x86_cpuid_set_vendor(Object *obj, const char 
> *value,
>       int i;
>   
>       if (strlen(value) != CPUID_VENDOR_SZ) {
> -        error_setg(errp, QERR_PROPERTY_VALUE_BAD, "", "vendor", value);
> +        error_setg(errp, "value of property 'vendor' must consist of"
> +                   " excactly " stringify(CPUID_VENDOR_SZ) " characters");

Typo "exactly" (and in example), otherwise:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>           return;
>       }
>