Re: [PATCH-for-9.0 04/25] memory: Simplify memory_region_init_rom_nomigrate() calls

[Richard Henderson]

On 11/20/23 15:32, Philippe Mathieu-Daudé wrote:
> Mechanical change using the following coccinelle script:
>
> @@
> expression mr, owner, arg3, arg4, errp;
> @@
> -   memory_region_init_rom_nomigrate(mr, owner, arg3, arg4, &errp);
>      if (
> -       errp
> +       !memory_region_init_rom_nomigrate(mr, owner, arg3, arg4, &errp)

This coccinelle script doesn't quite match...

> @@ -3628,11 +3628,8 @@ void memory_region_init_rom(MemoryRegion *mr,
>                               Error **errp)
>   {
>       DeviceState *owner_dev;
> -    Error *err = NULL;
>   
> -    memory_region_init_rom_nomigrate(mr, owner, name, size, &err);

... this?

That said, the actual code change is good.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~