[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 39/71] hw/arm/bcm2836: Use ARM_CPU 'mp-affinity' property
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 39/71] hw/arm/bcm2836: Use ARM_CPU 'mp-affinity' property |
Date: |
Fri, 5 Jan 2024 16:42:32 +0100 |
The 'mp-affinity' property is present since commit 15a21fe028
("target-arm: Add mp-affinity property for ARM CPU class").
Use it and remove a /* TODO */ comment. Since all ARM CPUs
have this property, use &error_abort, because this call can
not fail.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20231123143813.42632-4-philmd@linaro.org>
---
hw/arm/bcm2836.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
index a1bd1406e1..289c30e6b6 100644
--- a/hw/arm/bcm2836.c
+++ b/hw/arm/bcm2836.c
@@ -127,8 +127,8 @@ static void bcm2836_realize(DeviceState *dev, Error **errp)
qdev_get_gpio_in_named(DEVICE(&s->control), "gpu-fiq", 0));
for (n = 0; n < BCM283X_NCPUS; n++) {
- /* TODO: this should be converted to a property of ARM_CPU */
- s->cpu[n].core.mp_affinity = (bc->clusterid << 8) | n;
+ object_property_set_int(OBJECT(&s->cpu[n].core), "mp-affinity",
+ (bc->clusterid << 8) | n, &error_abort);
/* set periphbase/CBAR value for CPU-local registers */
object_property_set_int(OBJECT(&s->cpu[n].core), "reset-cbar",
--
2.41.0
- [PULL 29/71] hw/arm/virt: Check CPU type in machine_run_board_init(), (continued)
- [PULL 29/71] hw/arm/virt: Check CPU type in machine_run_board_init(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 30/71] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 32/71] hw/riscv/shakti_c: Check CPU type in machine_run_board_init(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 34/71] hw/core/cpu: Update description of CPUState::node, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 35/71] hw/cpu/core: Cleanup unused included header in core.c, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 31/71] hw/arm: Check CPU type in machine_run_board_init(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 36/71] hw/cpu/cluster: Cleanup unused included header in cluster.c, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 33/71] hw/core/cpu: Remove final vestiges of dynamic state tracing, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 39/71] hw/arm/bcm2836: Use ARM_CPU 'mp-affinity' property,
Philippe Mathieu-Daudé <=
- [PULL 37/71] hw/audio/sb16: Do not migrate qdev properties, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 40/71] hw/ppc/spapr_cpu_core: Access QDev properties with proper API, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 41/71] hw: Simplify accesses to the CPUState::'start-powered-off' property, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 38/71] hw/arm/bcm2836: Simplify use of 'reset-cbar' property, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 44/71] memory: Have memory_region_init_ram_flags_nomigrate() return a boolean, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 42/71] hw/ppc/xive2_regs: Remove unnecessary 'cpu.h' inclusion, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 45/71] memory: Have memory_region_init_ram_nomigrate() handler return a boolean, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 43/71] hw/mips: Inline 'bios.h' definitions, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 46/71] memory: Have memory_region_init_rom_nomigrate() handler return a boolean, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 48/71] memory: Simplify memory_region_init_ram_from_fd() calls, Philippe Mathieu-Daudé, 2024/01/05