Re: [PATCH v3 32/33] target/ppc/mmu-radix64.c: Drop a local variable

[Nicholas Piggin]

On Wed May 8, 2024 at 10:15 AM AEST, BALATON Zoltan wrote:
> The value is only used once so no need to introduce a local variable
> for it.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  target/ppc/mmu-radix64.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 8daf71d2db..395ce3b782 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -185,7 +185,6 @@ static bool ppc_radix64_check_prot(PowerPCCPU *cpu, 
> MMUAccessType access_type,
>                                     int mmu_idx, bool partition_scoped)
>  {
>      CPUPPCState *env = &cpu->env;
> -    int need_prot;
>  
>      /* Check Page Attributes (pte58:59) */
>      if ((pte & R_PTE_ATT) == R_PTE_ATT_NI_IO && access_type == 
> MMU_INST_FETCH) {
> @@ -210,8 +209,8 @@ static bool ppc_radix64_check_prot(PowerPCCPU *cpu, 
> MMUAccessType access_type,
>      }
>  
>      /* Check if requested access type is allowed */
> -    need_prot = prot_for_access_type(access_type);
> -    if (need_prot & ~*prot) { /* Page Protected for that Access */
> +    if (prot_for_access_type(access_type) & ~*prot) {
> +        /* Page Protected for that Access */
>          *fault_cause |= access_type == MMU_INST_FETCH ? SRR1_NOEXEC_GUARD :
>                                                          DSISR_PROTFAULT;
>          return true;