[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 04/43] target/ppc/mmu_common.c: Remove single use local variable
From: |
BALATON Zoltan |
Subject: |
[PATCH 04/43] target/ppc/mmu_common.c: Remove single use local variable |
Date: |
Mon, 27 May 2024 01:12:39 +0200 (CEST) |
The ptev variable in ppc6xx_tlb_pte_check() is used only once and just
obfuscates an otherwise clear value. Get rid of it.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 371ec24485..16578f7fa5 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -98,13 +98,12 @@ static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx,
target_ulong pte0,
target_ulong pte1, int h,
MMUAccessType access_type)
{
- int ret, pteh, ptev, pp;
+ int ret, pteh, pp;
ret = -1;
/* Check validity and table match */
- ptev = pte_is_valid(pte0);
pteh = (pte0 >> 6) & 1;
- if (ptev && h == pteh) {
+ if (pte_is_valid(pte0) && h == pteh) {
/* Check vsid & api */
pp = pte1 & 0x00000003;
if ((pte0 & PTE_PTEM_MASK) == ctx->ptem) {
--
2.30.9
- [PATCH 00/43] Remaining MMU clean up patches, BALATON Zoltan, 2024/05/26
- [PATCH 04/43] target/ppc/mmu_common.c: Remove single use local variable,
BALATON Zoltan <=
- [PATCH 03/43] target/ppc/mmu_common.c: Remove single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 06/43] target/ppc/mmu_common.c: Remove yet another single use local variable, BALATON Zoltan, 2024/05/26
- [PATCH 08/43] target/ppc/mmu_common.c: Simplify ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 01/43] target/ppc: Reorganise and rename ppc_hash32_pp_prot(), BALATON Zoltan, 2024/05/26
- [PATCH 02/43] target/ppc/mmu_common.c: Remove local name for a constant, BALATON Zoltan, 2024/05/26
- [PATCH 16/43] target/ppc/mmu_common.c: Inline and remove ppc6xx_tlb_pte_check(), BALATON Zoltan, 2024/05/26
- [PATCH 15/43] target/ppc/mmu_common.c: Simplify a switch statement, BALATON Zoltan, 2024/05/26
- [PATCH 18/43] target/ppc: Add function to get protection key for hash32 MMU, BALATON Zoltan, 2024/05/26
- [PATCH 20/43] target/ppc/mmu_common.c: Init variable in function that relies on it, BALATON Zoltan, 2024/05/26
- [PATCH 05/43] target/ppc/mmu_common.c: Remove another single use local variable, BALATON Zoltan, 2024/05/26