[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 2/7] memory: Do not refer to "memory region's reference count"
From: |
Akihiko Odaki |
Subject: |
[PATCH v4 2/7] memory: Do not refer to "memory region's reference count" |
Date: |
Fri, 23 Aug 2024 15:13:07 +0900 |
Now MemoryRegions do have their own reference counts, but they will not
be used when their owners are not themselves. However, the documentation
of memory_region_ref() says it adds "1 to a memory region's reference
count", which is confusing. Avoid referring to "memory region's
reference count" and just say: "Add a reference to a memory region".
Make a similar change to memory_region_unref() too.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
include/exec/memory.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 02f7528ec060..b9f0ad09bfad 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -1217,7 +1217,7 @@ void memory_region_init(MemoryRegion *mr,
uint64_t size);
/**
- * memory_region_ref: Add 1 to a memory region's reference count
+ * memory_region_ref: Add a reference to a memory region
*
* Whenever memory regions are accessed outside the BQL, they need to be
* preserved against hot-unplug. MemoryRegions actually do not have their
@@ -1234,7 +1234,7 @@ void memory_region_init(MemoryRegion *mr,
void memory_region_ref(MemoryRegion *mr);
/**
- * memory_region_unref: Remove 1 to a memory region's reference count
+ * memory_region_unref: Remove a reference to a memory region
*
* Whenever memory regions are accessed outside the BQL, they need to be
* preserved against hot-unplug. MemoryRegions actually do not have their
--
2.46.0
- [PATCH v4 0/7] Fix check-qtest-ppc64 sanitizer errors, Akihiko Odaki, 2024/08/23
- [PATCH v4 1/7] migration: Free removed SaveStateEntry, Akihiko Odaki, 2024/08/23
- [PATCH v4 4/7] memory: Clarify that owner may be missing, Akihiko Odaki, 2024/08/23
- [PATCH v4 2/7] memory: Do not refer to "memory region's reference count",
Akihiko Odaki <=
- [PATCH v4 3/7] memory: Refer to docs/devel/memory.rst for "owner", Akihiko Odaki, 2024/08/23
- [PATCH v4 5/7] memory: Clarify owner must not call memory_region_ref(), Akihiko Odaki, 2024/08/23
- [PATCH v4 6/7] memory: Do not create circular reference with subregion, Akihiko Odaki, 2024/08/23
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Xu, 2024/08/26
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Maydell, 2024/08/26
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Xu, 2024/08/26
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Akihiko Odaki, 2024/08/27
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Peter Xu, 2024/08/27
- Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion, Akihiko Odaki, 2024/08/28